Josh Duck
b5dbbd5b2d
Add warning about object property order.
...
It's easy to misuse the properties-as-keys feature and end up with children rendered out of order. Add a note and example of how to avoid this.
2014-01-29 10:53:21 -08:00
Ben Newman
34e6a51e19
Merge pull request #981 from benjamn/upgrade-commoner-to-remove-output-directory-locking
...
Upgrade Commoner to v0.9.0 to get rid of output directory locking.
2014-01-27 19:21:32 -08:00
Ben Newman
933681b42c
Upgrade Commoner to v0.9.0 to get rid of output directory locking.
...
Closes #957 .
2014-01-27 19:07:00 -08:00
Ben Newman
0bca41fc93
Merge pull request #980 from benjamn/issue-856-delete-build-modules
...
Remove build/modules/ at beginning of `grunt` and `grunt test`.
2014-01-27 18:01:18 -08:00
Ben Newman
864366d082
Remove build/modules/ at beginning of grunt and grunt test.
...
Little-known fact: instead of writing copies of compiled module files to
build/modules/, the bin/jsx-internal script actually just makes hard links
to the master versions of files in the .module-cache/, so re-populating
build/modules/ is very inexpensive.
Closes #856 .
2014-01-27 16:46:01 -08:00
Ben Newman
36fd1def84
Move grunt/config/jsx/jsx.js to grunt/config/jsx.js.
...
There used to be more files in that subdirectory.
2014-01-27 12:09:55 -08:00
Paul O’Shannessy
0e5dfd3fec
Merge pull request #964 from bobeagan/patch-2
...
fix incorrect link
2014-01-27 11:26:33 -08:00
Pete Hunt and Paul O’Shannessy
526be1570e
Fix memory leak with renderComponentToString()
...
This is leaking memory. Move event registration to mount time.
2014-01-24 18:23:51 -08:00
Bob Eagan
e3342f31b2
add hash link for lifecycle section of working with the browser page
2014-01-24 16:46:09 -07:00
Bob Eagan
4aececb645
fix incorrect link
2014-01-24 11:10:16 -07:00
Pete Hunt
4975113f20
Merge pull request #958 from aymanosman/master
...
Fix typo
2014-01-24 03:38:14 -08:00
Jeff Morrison and Paul O’Shannessy
ce92efefc0
Codemod for whitespace change
...
This codemods to shim any old-style JSX whitespace so that it renders the same as before.
Basically it sticks explicit `{' '}` spaces in where spaces are no longer implicit.
2014-01-23 13:52:38 -08:00
Paul Shen and Paul O’Shannessy
4a5a6ad733
Transfer the key prop in cloneWithProps
...
`cloneWithProps` uses `ReactPropTransferer`, which ignores the `key`
prop. See https://github.com/facebook/react/pull/713
However, this is not the case with `cloneWithProps` because when someone
is cloning a component and provides a key, they mean for the clone to
take it.
2014-01-23 13:48:39 -08:00
Pete Hunt and Paul O’Shannessy
62b52e008e
Don't reconcile children unneccessarily
...
We've talked about this perf optimization for a while now. This prevents us from re-reconciling components that are above the component being
reconciled in the owner hierarchy.
2014-01-23 13:48:36 -08:00
Ben Newman
b1e6c4d0dd
Merge pull request #959 from benjamn/commoner-multiple-file-support
...
Upgrade Commoner to v0.8.14 for multiple file support.
2014-01-23 13:10:17 -08:00
Jeff Morrison
db04043eaa
Merge pull request #480 from syranide/whitespace
...
JSX whitespace coalescing rules
2014-01-23 12:32:57 -08:00
Ben Newman
1e702f7258
Upgrade Commoner to v0.8.14 for multiple file support.
...
See [Commoner's README.md](
https://github.com/benjamn/commoner#generating-multiple-files-from-one-source-module )
for further explanation of the new functionality.
Among other potential benefits, this upgrade allows us to generate source
maps as standalone files rather than appending them inline to every
compiled module file under `build/modules/` (see #833 ).
2014-01-23 15:25:20 -05:00
Ayman Osman
97518fd664
Fix typo
2014-01-23 19:21:20 +00:00
Paul O’Shannessy
38491c7c93
Merge pull request #952 from jeanlauliac/patch-1
...
Update broken link in 'why react' article
2014-01-23 09:40:28 -08:00
Jean Lauliac
b872100be6
Normalize internal links in 'why react' article
2014-01-22 22:01:20 +01:00
Jean Lauliac
14cb99c9aa
Update broken link in 'why react' article
2014-01-22 21:53:36 +01:00
Andreas Svensson
c16b5659a0
Implement stricter whitespace rules
2014-01-22 21:00:10 +01:00
Pete Hunt
0af9c3ebe7
Merge pull request #748 from spicyj/private-getvalue
...
Change LinkedValueMixin to a util class
2014-01-22 10:54:13 -08:00
Ben Alpert
95a80591dd
Change LinkedValueMixin to a util class
...
This makes it clear that .getValue() is not a public API.
2014-01-22 09:57:59 -08:00
Paul O’Shannessy
f0b01d0faa
Merge pull request #885 from syranide/natext
...
Remove unnecessary 'NA'-fallback for getTextContentAccessor()
2014-01-21 17:22:48 -08:00
Paul O’Shannessy
1d1a790df0
Merge pull request #901 from syranide/80chars
...
Fix lines longer than 80 chars
2014-01-21 17:09:24 -08:00
cpojer
ca02a068b8
Update propTypes documentation.
2014-01-21 16:45:34 -08:00
cpojer
8b12670ef9
Perf Test for the propTypes change.
2014-01-21 14:05:38 -08:00
cpojer
2cac321b27
Change ReactPropTypes invariant's to console.warn.
2014-01-21 14:05:33 -08:00
Paul O’Shannessy
9c91546451
Merge pull request #918 from spicyj/npm-react-rec
...
Fix copying files to build/npm-react recursively
2014-01-21 13:03:57 -08:00
Paul O’Shannessy
494f6e9c34
Merge pull request #921 from spicyj/grunt-jsx-no-dev
...
Remove unused grunt jsx config options
2014-01-21 11:40:43 -08:00
Pete Hunt
e3248efe92
Merge pull request #934 from syranide/minid
...
Shortened generated "data-reactid"
2014-01-20 13:26:42 -08:00
Andreas Svensson
559cd46181
Shortened generated "data-reactid"
2014-01-20 22:03:25 +01:00
Ben Alpert
e931dba107
Merge pull request #731 from fabiomcosta/jsxtransform-filename
...
Adds filename to JSXTransform error messages
2014-01-20 12:18:37 -08:00
Fabio M. Costa
de7a92afa7
Updating error message to also show part of the code, making it easier to find the error
2014-01-20 11:57:35 -08:00
Fabio M. Costa
d829d1ab9b
Adding current page's url for inline code and code improvement
2014-01-20 11:57:34 -08:00
Fabio M. Costa
b1a949ed45
Adds the filename to JSXTransform error message, making it easier to debug JSX syntax errors.
2014-01-20 11:55:17 -08:00
Cheng Lou
4b392f19a8
Merge pull request #861 from andrewdavey/unitless-css-props
...
Unitless css props
2014-01-17 21:49:24 -08:00
Ben Alpert
ffc31ed77b
Merge pull request #914 from chenglou/jsx
...
tweak frontpage first example code
2014-01-17 18:27:51 -08:00
Paul O’Shannessy
df8d092609
Merge pull request #924 from zpao/update-deps
...
Update build dependencies
2014-01-17 18:01:43 -08:00
Paul O’Shannessy
ca930efa7c
Upgrade (explicitly) grunt
...
They deprecated the use of some packaged modules and suggest using those modules
directly. http://gruntjs.com/blog/2013-11-21-grunt-0.4.2-released
Lodash was the only use we had.
2014-01-17 18:00:40 -08:00
Paul O’Shannessy
9558285f09
Update other dependencies
2014-01-17 18:00:40 -08:00
Paul O’Shannessy
c5f0e14985
Update browserify
...
Also update bundle.transform call site, which now takes options
2014-01-17 18:00:40 -08:00
Cheng Lou
d8d4120614
[docs] Tweak frontpage first example and jsx-compiler example
2014-01-17 17:53:44 -08:00
Ben Alpert
ea711f1d62
Simplify live editor execution logic
2014-01-17 17:42:53 -08:00
Ben Alpert
4440486a24
Properly clear live editor on JSX compile failure
2014-01-17 17:42:40 -08:00
Nick Thompson and Paul O’Shannessy
0d2510ad9c
Add span property to React DefaultDOMPropertyConfig
...
So that the `span` attribute on <colgroup> tags isn't swallowed by
React.
2014-01-17 17:17:31 -08:00
Tim Yung and Paul O’Shannessy
79beb71d69
Fix ChangeEventPlugin Dependencies
...
When React moved to attaching top-level event listeners on-demand, not all of the dependencies for `ChangeEventPlugin` were set. This led to `onChange` events not firing under certain circumstances. For example, listening to `onChange` on a checkbox will not work because it relies on `onClick` (unless something else on the page was listening to `onClick`).
2014-01-17 17:17:31 -08:00
Cheng Lou
d489637a4f
Merge pull request #931 from spicyj/master
...
Update homepage for new JSX/JS editor
2014-01-17 16:56:40 -08:00
Ben Alpert
2ac36178c6
Update homepage for new JSX/JS editor
2014-01-17 16:46:50 -08:00