Ben Alpert
db989bf686
Don't execute <script> tags w/ createElement mode
...
Each script will execute at most once so we could also set `.textContent` to something like `;`, then add it to the document, then change the `.textContent`, but this seems like the simplest approach. See http://dev.w3.org/html5/spec-preview/the-script-element.html for details.
2015-10-12 13:43:40 -07:00
Ben Alpert
b03b195759
Merge pull request #5130 from matiassingers/jasmine-spy-call-args-consistency
...
Jasmine spies call args property consistency
2015-10-12 10:24:56 -07:00
Alan Plum
0e451162bc
Removed eslint warning.
2015-10-12 17:42:38 +02:00
Matias Singers
f8f2be05ce
Consistently use calls[n].args[n] instead of argsForCall[n][n] for Jasmine spies
2015-10-12 22:39:19 +08:00
Matias Singers
dd0b1a643b
Consistently use calls.length instead of callCount for Jasmine spies, take II
...
See #3105 for take I
2015-10-11 15:42:24 +08:00
Ben Alpert
8210299437
Add SVG/MathML support for createElement mode
2015-10-09 14:56:57 -07:00
Ben Alpert
1dca72ebfa
Thread native-parent pointers through everything
...
Now we don't repurpose context for our own secret needs (hi Dan). In this diff I avoid storing the native parent on native (DOM) components and store it only on composites, but we'll probably want to store it on native components too soon for event bubbling.
2015-10-09 14:56:08 -07:00
Ben Alpert
a907da9430
Make Danger-test simpler and more robust
2015-10-09 14:54:42 -07:00
Jim
15c731edca
Merge pull request #5109 from Josh-a-e/undefined_this_on_controlled_components
...
add test to show `this` is indeed undefined - closes #3613
2015-10-09 11:44:19 -07:00
Ben Alpert
d95381387e
Merge pull request #5111 from spicyj/vdn-current
...
validateDOMNesting: parentTag -> current
2015-10-09 11:43:31 -07:00
Ben Alpert
9c836b09f2
validateDOMNesting: parentTag -> current
2015-10-09 11:40:55 -07:00
Joshua Evans
8f4c2997a0
add test to show this is indeed undefined - closes #3613
2015-10-09 19:37:58 +01:00
Kevin Cheng
ff17bc25d1
Fixed punctuation
2015-10-08 19:36:05 -07:00
Ben Alpert
d4420eca8a
Remove duplication in ReactServerRendering
2015-10-08 15:06:09 -07:00
Ben Alpert
3f5747009d
Merge pull request #5083 from spicyj/warn-min
...
Warn when using a minified copy of dev React
2015-10-08 14:08:50 -07:00
Ben Alpert
f3a506bc0c
Warn when using a minified copy of dev React
...
Fixes #4842 .
2015-10-08 11:44:56 -07:00
Ben Alpert
2253405dcc
Merge pull request #5085 from spicyj/cdp
...
Extract defineProperty feature testing to one file
2015-10-08 11:33:07 -07:00
Ben Alpert
4fb39ce984
Merge pull request #5081 from spicyj/svg-tu
...
Don't break on SVG tags in scryRenderedDOMComponentsWithClass
2015-10-08 08:38:32 -07:00
Ben Alpert
4bb83d237e
Don't break on SVG tags in scryRenderedDOMComponentsWithClass
...
Fixes #5076 .
2015-10-08 08:29:53 -07:00
Ben Alpert
e9796cc447
Merge pull request #5084 from spicyj/rearrange-utils
...
Move escapeTextContentForBrowser and quoteAttributeValueForBrowser to DOM directory
2015-10-08 08:28:40 -07:00
Ben Alpert
3fb2d3f5d4
Extract defineProperty feature testing to one file
...
This makes it slightly more bearable to debug in IE8 with an exception breakpoint. Also the old way was just silly and could mask other bugs.
2015-10-07 18:33:13 -07:00
Ben Alpert
2637a8eaf4
Move escapeTextContentForBrowser and quoteAttributeValueForBrowser to DOM directory
...
Only DOM files use these.
2015-10-07 18:11:15 -07:00
Ben Alpert
a7189c57fc
Merge pull request #5057 from camsong/patch-1
...
Text fix in ReactClass.js
2015-10-07 17:19:19 -07:00
Cam Song
9af15d3ecd
Text fix in ReactClass.js
...
Rename 'component class' to 'function' as it should be.
2015-10-08 08:13:27 +08:00
Jim
d0970ee8b8
Merge pull request #5063 from facebook/revert-5062-revert-4959-no-shams
...
Remove dependence on ES5 shams per #4189
2015-10-07 14:23:35 -07:00
Jim
f97d759db1
Merge pull request #5032 from jimfb/remove-react-link
...
Added warning for use of ReactLink.
2015-10-07 14:23:11 -07:00
Ben Alpert
f31a46cb18
Merge pull request #4983 from spicyj/id-swap
...
Refactor how composite type changes work, fix memory leak in ReactMount caching
2015-10-07 13:02:58 -07:00
Ben Alpert
34d84a36d6
Merge pull request #5066 from camsong/patch-2
...
Always use ANONYMOUS const in ReactPropTypes.js
2015-10-07 12:57:59 -07:00
Ben Alpert
8ce7b7120c
ReactMount now never expects invalid nodes in its cache
...
It never really made sense for us to have "invalid" nodes in the cache -- when we unmount things, we should always remove them from the cache properly. Now that swapping composite types doesn't repopulate the cache, we should be okay to now assume that everything in the cache is good.
2015-10-07 12:57:34 -07:00
Ben Alpert
fe9a76ef25
Rewrite ReactInstanceHandles-test to be less brittle
2015-10-07 12:57:34 -07:00
Ben Alpert
60491d89f8
Use returned native node for composite type-change
...
With this change, all unmounted components should be properly purged from ReactMount's cache.
2015-10-07 12:57:34 -07:00
Ben Alpert
743ccf090f
Cache native node on native components, return it when unmounting
...
This is probably slightly slower for unmounts in the case that no updates were ever performed, but caching the node on the instance should make updates faster. In any case, the more important consequence of this change is that we can fix the current memory leak that happens when swapping composite types.
2015-10-07 12:57:34 -07:00
Ben Alpert
e4a43389b8
Don't use existing "root" ID if non-root
...
Before, if you had
```
container = <div data-reactid=".0"><div data-reactid=".0.0" /></div>;
```
and did `ReactDOM.render(<span />, container)` you would get
```
<div data-reactid=".0"><span data-reactid=".0" /></div>;
```
(along with a warning not to replace React-rendered children with a new tree like that). But that makes no sense -- the span should have a new index, not truncate the ID of the old child it's replacing.
(Now tests pass again with useCreateElement on; before they threw a "valid but unequal" on our test for this warning.)
2015-10-07 12:57:34 -07:00
Ben Alpert
8ebbb7802c
Merge pull request #4918 from glenjamin/shallow-getinstance
...
Expose component instance in shallow rendering
2015-10-07 12:52:09 -07:00
Ben Alpert
501a2765ac
Merge pull request #4947 from fabiomcosta/server_render_index
...
[react] making sure ReactDOMServer always uses ServerReactRootIndex, …
2015-10-07 12:51:59 -07:00
Ben Alpert
4a29fd892a
Merge pull request #4779 from mnordick/master
...
Support CSS3 Grid Layout Module for inline styles
2015-10-07 12:51:26 -07:00
Paul O’Shannessy
59cd224a03
Bump version in master for 0.15 development
2015-10-07 09:57:53 -07:00
Cam Song
a69f05c881
Always use ANONYMOUS const in ReactPropTypes.js
2015-10-07 11:28:38 +08:00
Sebastian Markbåge
6d3a11e602
Merge pull request #4943 from bspaulding/throw-stateless-ref
...
Composite component throws on attaching ref to stateless component #4939
2015-10-06 14:33:48 -07:00
Jim
fc043bb3a5
Revert "Revert "Remove dependence on ES5 shams per #4189 ""
2015-10-06 14:31:20 -07:00
Jim
571edd85c2
Revert "Remove dependence on ES5 shams per #4189 "
2015-10-06 14:30:03 -07:00
David Greenspan
f95747b929
Remove dependence on ES5 shams per #4189
...
Docs not updated
2015-10-06 13:49:47 -07:00
Bradley Spaulding
c6a3eb14db
Wrapping StatelessComponent ref warning in __DEV__ block
2015-10-05 21:44:42 -07:00
Jim
5a9dea00b9
React->ReactDOM in src/
2015-10-05 16:29:33 -07:00
Ben Alpert
94ccda8543
Merge pull request #5041 from spicyj/val-key-err
...
Don't blow up in key warning for undefined type
2015-10-05 13:57:25 -07:00
KimCoding
f316839b90
rename renderSubtreeIntoContainer.js to renderSubtreeIntoContainer-test.js
...
To distinguish between testing file and implementation file.
2015-10-03 18:11:48 +09:00
Jim
c103c8d065
Added warning for use of ReactLink.
2015-10-02 11:33:48 -07:00
Ben Alpert
1959aaa1f9
Don't blow up in key warning for undefined type
2015-10-02 11:31:28 -07:00
Paul O’Shannessy
9aa4546410
Merge pull request #5034 from zpao/fbjs-0.3
...
Update to fbjs@0.3
2015-10-01 14:33:40 -07:00
Paul O’Shannessy
693dd3567b
Update to fbjs@0.3
...
As far as we're concerned, the only difference is that we moved some files from React to fbjs.
2015-10-01 14:30:05 -07:00