Commit Graph
1657 Commits
Author SHA1 Message Date
petehunt aaada5e212 Add a complementary tools page 2014-02-01 17:43:56 -08:00
Ben Alpert 98432365d9 [docs] Fix comma splice 2014-01-31 22:30:38 -08:00
Ben Alpert a2e805b26e Disable CodeMirror smart indentation
Fixes #966.
2014-01-31 22:10:37 -08:00
Paul O’Shannessy fce6d114fe Merge pull request #973 from syranide/hidethekill
Fix references to the old ReactID syntax
2014-01-31 15:33:57 -08:00
Christopher Chedeau f1b54bc310 s/Mock DOM/Virtual DOM/
Let's be consistent with the naming
2014-01-31 10:57:06 -08:00
Sebastian Markbåge 1666935878 Merge pull request #1001 from kmeht/renderComponentDocs
Add documentation about React.renderComponent
2014-01-30 17:29:59 -08:00
Kunal Mehta 43a242b67f Add documentation about React.renderComponent
Recently learned that components passed into `React.renderComponent` may not be the ones actually mounted. Also learned that it returns the mounted component. Added some documentation describing this.
2014-01-30 17:14:59 -08:00
Josh Duck 5d7563f706 Fix warning for numeric properties
Number('.1') === 0.1, and react uses dot-prefixed keys
for children. Whoops. Nuke the non-numeric requirement, and just
check a regex. This seems performant enough in micro-benchmarks:
http://jsperf.com/numericlike
2014-01-30 16:54:01 -08:00
Pete Hunt 4cbc4b58f6 Support children and ref for cloneWithProps()
We're not handling these correctly.
2014-01-30 16:53:47 -08:00
Pete Hunt b225b34f91 Merge pull request #985 from petehunt/remove-react-page
Remove references to react-page
2014-01-30 10:40:48 -08:00
Pete Hunt 32f69713fc Merge pull request #995 from Contra/patch-1
fix grammar mistake (reconciliation docs)
2014-01-30 10:40:28 -08:00
Eric Schoffstall cf1089fa0e fix grammar mistake 2014-01-29 20:19:51 -07:00
Josh Duck 00f2a053f0 Warn for numeric object properties
Numeric keys will be ordered sequentially in Chrome/Firefox.

Warn the user if such keys are set on a child.
2014-01-29 14:08:23 -08:00
Ben Newman 65490a09e6 Use querySelectorAll instead of getElementsByName in ReactDOMInput.
We've been able to use `querySelectorAll` in all the browsers that we
support for some time now, but we haven't been able to test code that uses
it in the older version of `jsdom` that we were using, until recently.

Besides the general goal of modernizing our code, the impetus for this
specific change is that I'm trying to support testing without having to
render nodes into an actual document. The `.getElementsByName` method is
only defined on `document` and only works if the nodes you care about are
contained by the document.

On the other hand, `querySelectorAll` works on any DOM node, and allows a
more precise selection of just the `<input type="radio">` elements that
have the appropriate name.

IE8's implementation of `querySelectorAll` supports attribute-based
selectors, which is all we need here.
2014-01-29 14:08:21 -08:00
Paul O’Shannessy d8e9eb978b Fix animation example code
key should never be index into an array or there are bugs. Especially in
transitions.

Fixes #853
2014-01-29 13:06:22 -08:00
Pete Hunt 46c6ac5bb0 Update 09.2-form-input-binding-sugar.md 2014-01-29 12:45:46 -08:00
Pete Hunt 132e8b3c43 Merge pull request #880 from jbaiter/reactlink_checkbox
Support two-way binding for checkboxes in LinkedValueMixin via 'checkedLink' property
2014-01-29 12:44:30 -08:00
Ben Alpert 4894055114 Fix docs typo 2014-01-29 11:19:45 -08:00
petehunt 470a7d11ee remove references to react-page 2014-01-28 16:02:16 -08:00
Ben Newman 34e6a51e19 Merge pull request #981 from benjamn/upgrade-commoner-to-remove-output-directory-locking
Upgrade Commoner to v0.9.0 to get rid of output directory locking.
2014-01-27 19:21:32 -08:00
Ben Newman 933681b42c Upgrade Commoner to v0.9.0 to get rid of output directory locking.
Closes #957.
2014-01-27 19:07:00 -08:00
Ben Newman 0bca41fc93 Merge pull request #980 from benjamn/issue-856-delete-build-modules
Remove build/modules/ at beginning of `grunt` and `grunt test`.
2014-01-27 18:01:18 -08:00
Ben Newman 864366d082 Remove build/modules/ at beginning of grunt and grunt test.
Little-known fact: instead of writing copies of compiled module files to
build/modules/, the bin/jsx-internal script actually just makes hard links
to the master versions of files in the .module-cache/, so re-populating
build/modules/ is very inexpensive.

Closes #856.
2014-01-27 16:46:01 -08:00
Ben Newman 36fd1def84 Move grunt/config/jsx/jsx.js to grunt/config/jsx.js.
There used to be more files in that subdirectory.
2014-01-27 12:09:55 -08:00
Paul O’Shannessy 0e5dfd3fec Merge pull request #964 from bobeagan/patch-2
fix incorrect link
2014-01-27 11:26:33 -08:00
Andreas Svensson 989eb2e7d9 Fix references to the old ReactID syntax 2014-01-26 21:26:58 +01:00
Pete Hunt 526be1570e Fix memory leak with renderComponentToString()
This is leaking memory. Move event registration to mount time.
2014-01-24 18:23:51 -08:00
Bob Eagan e3342f31b2 add hash link for lifecycle section of working with the browser page 2014-01-24 16:46:09 -07:00
Bob Eagan 4aececb645 fix incorrect link 2014-01-24 11:10:16 -07:00
Pete Hunt 4975113f20 Merge pull request #958 from aymanosman/master
Fix typo
2014-01-24 03:38:14 -08:00
Jeff Morrison ce92efefc0 Codemod for whitespace change
This codemods to shim any old-style JSX whitespace so that it renders the same as before.
Basically it sticks explicit `{' '}` spaces in where spaces are no longer implicit.
2014-01-23 13:52:38 -08:00
Paul Shen 4a5a6ad733 Transfer the key prop in cloneWithProps
`cloneWithProps` uses `ReactPropTransferer`, which ignores the `key`
prop. See https://github.com/facebook/react/pull/713

However, this is not the case with `cloneWithProps` because when someone
is cloning a component and provides a key, they mean for the clone to
take it.
2014-01-23 13:48:39 -08:00
Pete Hunt 62b52e008e Don't reconcile children unneccessarily
We've talked about this perf optimization for a while now. This prevents us from re-reconciling components that are above the component being
reconciled in the owner hierarchy.
2014-01-23 13:48:36 -08:00
Ben Newman b1e6c4d0dd Merge pull request #959 from benjamn/commoner-multiple-file-support
Upgrade Commoner to v0.8.14 for multiple file support.
2014-01-23 13:10:17 -08:00
Jeff Morrison db04043eaa Merge pull request #480 from syranide/whitespace
JSX whitespace coalescing rules
2014-01-23 12:32:57 -08:00
Ben Newman 1e702f7258 Upgrade Commoner to v0.8.14 for multiple file support.
See [Commoner's README.md](
https://github.com/benjamn/commoner#generating-multiple-files-from-one-source-module)
for further explanation of the new functionality.

Among other potential benefits, this upgrade allows us to generate source
maps as standalone files rather than appending them inline to every
compiled module file under `build/modules/` (see #833).
2014-01-23 15:25:20 -05:00
Ayman Osman 97518fd664 Fix typo 2014-01-23 19:21:20 +00:00
Paul O’Shannessy 38491c7c93 Merge pull request #952 from jeanlauliac/patch-1
Update broken link in 'why react' article
2014-01-23 09:40:28 -08:00
Johannes Baiter ad9c5e9242 Use Simulate.click instead of Simulate.input for simulating input on
checkbox.
2014-01-23 10:53:36 +01:00
Johannes Baiter 91ef878ca8 Fix comparison in _handleLinkedCheckChange 2014-01-23 10:53:36 +01:00
Johannes Baiter 2521b47707 Fix typo in ReactDOMInput-test 2014-01-23 10:52:55 +01:00
Johannes Baiter 79995a05c7 Add invariant if both checkedLink and valueLink are provided 2014-01-23 10:52:54 +01:00
Johannes Baiter 7b047111a0 Support two-way binding for checkboxes in LinkedValueMixin via 'checkedLink' property 2014-01-23 10:49:02 +01:00
Jean Lauliac b872100be6 Normalize internal links in 'why react' article 2014-01-22 22:01:20 +01:00
Jean Lauliac 14cb99c9aa Update broken link in 'why react' article 2014-01-22 21:53:36 +01:00
Andreas Svensson c16b5659a0 Implement stricter whitespace rules 2014-01-22 21:00:10 +01:00
Pete Hunt 0af9c3ebe7 Merge pull request #748 from spicyj/private-getvalue
Change LinkedValueMixin to a util class
2014-01-22 10:54:13 -08:00
Ben Alpert 95a80591dd Change LinkedValueMixin to a util class
This makes it clear that .getValue() is not a public API.
2014-01-22 09:57:59 -08:00
Paul O’Shannessy f0b01d0faa Merge pull request #885 from syranide/natext
Remove unnecessary 'NA'-fallback for getTextContentAccessor()
2014-01-21 17:22:48 -08:00
Paul O’Shannessy 1d1a790df0 Merge pull request #901 from syranide/80chars
Fix lines longer than 80 chars
2014-01-21 17:09:24 -08:00