Commit Graph
2369 Commits
Author SHA1 Message Date
Marshall Roch a6cd945d9f Fix 'this' in static methods
binds static methods on the descriptor to the component's actual constructor, so that `foo.constructor.bar()` and `Foo.bar()` run with the same `this`.
2014-06-14 20:37:51 -07:00
Tim Yung 431155d2e2 Revert #1536
It's causing issues in product code. Reverting until it can be
investigated further.
2014-06-14 20:36:07 -07:00
Kunal Mehta 0f7423f31d Merge pull request #1661 from spicyj/test-ie10-select-multiple
Fix select switching to multiple in IE
2014-06-13 14:24:50 -07:00
Cheng Lou 3eb36415bd Merge pull request #1206 from brandonbloom/apply
$apply directive for update
2014-06-12 20:34:29 -07:00
Cheng Lou 4329d5ac38 Merge pull request #1611 from mathieumg/master
Added 'objectOf' PropType validator to iterate on objects and validate properties.
2014-06-12 20:19:33 -07:00
Brandon Bloom 86161c9c48 $apply command for update 2014-06-12 23:10:14 -04:00
Ben Alpert 7ab5769e18 Merge pull request #1687 from KyleAMathews/patch-2
typo fix
2014-06-12 16:29:19 -07:00
Kyle Mathews cfdc884582 typo 2014-06-12 16:27:40 -07:00
Ben Alpert 5758f8da35 Merge pull request #1685 from randallsquared/patch-1
Fix correlation direction of wording in Ballmer Peak example.
2014-06-12 12:34:53 -07:00
Randall Randall 6d0e2feb52 Fix wording.
The Ballmer Peak XKCD suggests that it's a graph of ability, rather than bug frequency, which should be inversely correlated with ability.  A simple change of the wording fixes this terrible mishandling of Ballmer Peak data.
2014-06-12 10:15:13 -04:00
Mathieu M-Gosselin 4852c30d62 Added 'objectOf' PropType validator to iterate on object literals and
validate properties.
2014-06-11 21:12:05 -04:00
Cheng Lou 303a719f92 Merge pull request #1658 from spicyj/test-ie10-submit-label
Fix submit-button value test in IE10
2014-06-11 13:44:27 -07:00
Cheng Lou 9eff32c80c Merge pull request #1659 from spicyj/test-ie10-iframe
Fix EnterLeaveEventPlugin-test in IE10
2014-06-11 13:44:16 -07:00
Cheng Lou 92c174fec8 Merge pull request #1671 from gasi/fix-unset-style
Prevent null reference access when unsetting styles
2014-06-11 11:27:37 -07:00
Cheng Lou 36f2999d47 Merge pull request #1660 from spicyj/test-ie10-proptypesname
Fix PropTypes test in IE10
2014-06-11 10:34:28 -07:00
Ben Alpert 8e2dcceee3 Merge pull request #1597 from spicyj/defaultprops-autobind
Auto-bind before getDefaultProps
2014-06-11 10:14:31 -07:00
Ben Alpert 927eb570b9 Merge pull request #1631 from dblandin/master
Update link to @petehunt's react-server-rendering GitHub repo
2014-06-10 13:53:37 -07:00
Ben Alpert e1e2fbdcf7 Merge pull request #1636 from harshadsabne/master
Update 2014-03-21-react-v0.10.md
2014-06-10 13:45:46 -07:00
Daniel Gasienica 7c2dec5bd3 Prevent null reference access when unsetting styles 2014-06-10 13:33:32 -07:00
Ben Alpert 2f61996ec3 [docs] Point to renderComponent over setProps 2014-06-08 13:04:40 -07:00
Ben Alpert eaa68b8e6b Fix select switching to multiple in IE
This one was an actual behavioral bug rather than a bug with the tests; our intention was that the first element from the `defaultValue` array would remain selected but IE seemed to be choosing the last one instead. Now we set the value for uncontrolled components in componentDidUpdate when switching from multiple to non-multiple to ensure that a consistent option gets selected.

Test Plan: Ran the ReactDOMSelect tests in jest, phantomjs, IE10, Chrome, and Firefox. Also tested an uncontrolled select manually to make sure that nothing crazy happened when switching between options.
2014-06-07 19:16:34 -07:00
Ben Alpert 7cd5e9b399 Fix PropTypes test in IE10
Test Plan: Ran the test in jest, phantomjs, IE10, Chrome, and Firefox.
2014-06-07 18:56:28 -07:00
Ben Alpert 5790a75622 Fix submit-button value test in IE10
Test Plan: Ran test in jest, phantomjs, IE10, Chrome, and Firefox.
2014-06-07 18:50:29 -07:00
Ben Alpert e938116549 Fix EnterLeaveEventPlugin-test in IE10
Previously this was failing because iframeDocument.body wasn't properly initialized. Creating the document this way seems to work in all environments

Test Plan: Ran the test in jest, phantomjs, IE10, Chrome, and Firefox.
2014-06-07 18:45:32 -07:00
cpojer eebcf9f888 Fix ExecutionEnvironment.canUseDOM for IE8. 2014-06-05 12:44:24 -07:00
Christoph Pojer 41ed67d222 Merge pull request #1638 from spicyj/getmodifierstate-2
Fix getEventModifierState, no allocations
2014-06-03 14:36:16 -07:00
Ben Alpert e501238c10 Fix getEventModifierState, no allocations
Alternative to #1637 that doesn't allocate on every event.

Test Plan: Crossed fingers.
2014-06-03 14:35:29 -07:00
Harshad Sabne 7172b1d5da Update 2014-03-21-react-v0.10.md
Fix link to React v0.10 RC
2014-06-03 21:35:49 +05:30
Pete Hunt 87bcbff218 Merge pull request #1632 from spicyj/img-load-error
Fix onLoad and onError on images
2014-05-30 17:04:41 -07:00
Ben Alpert 3e34739cb9 Fix onLoad and onError on images
Fixes bug introduced in c62c2c5.

Test Plan: Tested that the onLoad event was properly triggered on an image. Didn't test onError but I can only assume that it works equally well.
2014-05-30 16:53:46 -07:00
Devon Blandin d8a2f12498 Update link to @petehunt's react-server-rendering GitHub repo 2014-05-30 14:14:18 -05:00
Cheng Lou 6ce193614c Merge pull request #1627 from Enome/master
Typo: ClosureScript -> ClojureScript in latest blog post
2014-05-29 16:20:42 -04:00
enome b72d9f3aab Typo: ClosureScript -> ClojureScript 2014-05-29 22:10:15 +02:00
Ben Alpert 5a856c769d Merge pull request #1614 from chenglou/1-year
[Blog] One-year anniversary post
2014-05-29 11:41:51 -07:00
Cheng Lou c5f690a7c7 [Blog] One-year anniversary post 2014-05-29 14:39:59 -04:00
Ben Alpert 8d8dd4d336 Merge pull request #1620 from kmeht/jestDoc
Reference Jest in TestUtils documentation.
2014-05-28 23:53:37 -07:00
Kunal Mehta 055275b833 Reference Jest in TestUtils documentation. 2014-05-28 23:51:22 -07:00
Ben Alpert 3297909545 [docs] Fix grammar 2014-05-28 23:31:02 -07:00
Fred Zhao 50516585a4 Update findComponentRoot and processUpdates warnings for SVG
I ran into a really difficult-to-debug issue with a React app with SVG
elements. Christopher sat down with me for a while and we finally figured out
that the browser was moving non-SVG elements out of a parent `<svg>` node which
triggered the `processUpdates()` invariant. This updates the error message
thrown from there to include this scenario in the possible issues list.
2014-05-28 18:19:49 -07:00
Paul O’Shannessy 6c7abd36dd Sync upstream modules
crateObjectFrom is no longer used (was used in ReactPropTypes). Others are small changes.
2014-05-28 15:13:02 -07:00
Ben Alpert 2e3cf459ba Fix tutorial to have exact translation of example
Fixes #903.
2014-05-28 10:29:34 -07:00
Paul O’Shannessy 0ad8cfad1a Merge pull request #1590 from spicyj/svg-classname
Handle className properly on SVG nodes
2014-05-28 10:14:59 -07:00
Paul O’Shannessy f230e0a031 Merge pull request #1583 from nhunzaker/jsxtransform-parallel
Load external scripts in parallel in JSXTransformer
2014-05-27 14:31:25 -07:00
Timothy Yung bca1f0e352 Merge pull request #1536 from spicyj/gh-1169
Attach empty onclick listener to each node
2014-05-27 16:44:08 -04:00
Ben Alpert e096000bb5 Attach empty onclick listener to each node
Fixes #1169.

This is a more robust way of fixing what MobileSafariClickPlugin previously tried to. Now even if you don't want anything to do with touch events, click events still work properly.

Test Plan: Added a click handler to an `<img />` element and triggered it in the iOS simulator -- it didn't execute before.
2014-05-27 13:40:17 -07:00
Paul O’Shannessy fa6fe54432 Merge pull request #1596 from mindeavor/patch-1
Fix typo in Flux TodoMVC Tutorial
2014-05-27 11:07:09 -07:00
Tom Haggie cd3ba59cf1 Updated the ajax to tip to also mention that you need to check
that the component is still mounted before updating it's state.

Closes #1600.
2014-05-26 20:29:48 -07:00
Ben Alpert 03df8d7de0 Ignore built todomvc-flux bundles 2014-05-26 20:27:48 -07:00
Ben Alpert f761f770e1 Don't load todomvc-common/base.js
Fixes #1603.

It's unnecessary and makes a request to learn.json which doesn't exist.
2014-05-26 20:19:16 -07:00
Ben Alpert db4a90a9ef Capitalize README for consistency 2014-05-26 20:14:54 -07:00