Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity
12,917 Commits 681 Branches 148 Tags
a3bf6688121e69cfb377c25f362000b33d7984cd
Commit Graph
73 Commits
Author SHA1 Message Date
Simen Bekkhus 79a25125b1 feat: add recommended config eslint rule (#14762) 
* feat: add recommended config eslint rule

* add exhaustive-deps to recommended as well
 2020-02-28 02:01:17 +00:00
Sebastian Markbåge 549e418830 Move remaining things to named exports (#18165) 
* Move remaining things to named exports

The interesting case here is the noop renderers. The wrappers around the
reconciler now changed to use a local export that gets mutated.

ReactNoop and ReactNoopPersistent now have to destructure the object to
list out the names it's going to export. We should probably refactor
ReactNoop away from createReactNoop. Especially since it's also not Flow
typed.

* Switch interactions to star exports

This will have esModule compatibility flag on them. They should ideally
export default instead.
 2020-02-27 17:18:55 -08:00
Sunil Pai c1c5499cc3 update version numbers for 16.13 (#18143) 
also includes a bugfix when downloading error codes from circleci.
 2020-02-26 20:33:29 +00:00
Moji IzadmehrandLuke Kang bf13d3e3c6 [eslint-plugin-react-hooks] Fix cyclic caching for loops containing a… (#16853) 
* [eslint-plugin-react-hooks] Fix cyclic caching for loops containing a condition

* [eslint-plugin-react-hooks] prettier write

* [eslint-plugin-react-hooks] Fix set for tests

* Update packages/eslint-plugin-react-hooks/src/RulesOfHooks.js

Co-Authored-By: Luke Kang <kidkkr@icloud.com>

Co-authored-by: Luke Kang <kidkkr@icloud.com>
 2020-02-25 11:38:23 +00:00
Dan Abramov d533229fba Fix Prettier 2020-02-17 20:36:16 +00:00
Dan Abramov 56a8c35321 eslint-plugin-react-hooks@2.4.0 2020-02-17 20:26:56 +00:00
Will Douglas 93a229bab5 Update eslint rule exhaustive deps to use new suggestions feature (#17385) 
This closes #16313
 2020-02-17 20:24:27 +00:00
Tao 3ac81a57fb Update create-react-app note for eslint-plugin-react-hooks (#16982) 
eslint-plugin-react-hooks was added in react-scripts 3.0.0
 2020-01-09 13:47:05 -08:00
Dan Abramov b979db4e72 Bump Prettier (#17811) 
* Bump Prettier

* Reformat

* Use non-deprecated option
 2020-01-09 13:54:11 +00:00
Dan Abramov 897976600c [ESLint] Allow partial matches for custom Effect Hooks (#17663) 2019-12-19 17:04:17 +00:00
David Garner a807c307c4 [eslint] Check forwardRef callbacks (#17255) 
* [eslint] Check forwardRef callbacks (#17220)

* [eslint] Make tests more realistic (#17220)

* [eslint] Check anonymous callback of React.memo for rules-of-hooks (#17220)

* [eslint] Add tests for callbacks not known to be components (#17220)

* [eslint] Correct comments and add another test (#17220)
 2019-11-17 13:39:08 +00:00
Luna Ruan 9a5f28dbed update version numbers for 16.12 2019-11-14 16:02:18 -08:00
Andrew Clark 8075c8505b Update local package versions for 16.10 release 2019-10-22 14:30:06 -07:00
Andrew Clark d256f88ac6 Update local version numbers for 16.10.2 release 2019-10-03 14:14:10 -07:00
Rane Wallin 5943b1da6c Fixing grammatical errors in error message (#16973) 
* Fixing grammatical errors in error message

* Fixing grammar error in test file
 2019-10-03 18:14:48 +05:30
Andrew Clark 2a264a9dbe Update local version numbers for 16.10.1 release 2019-09-28 21:41:42 -07:00
Andrew Clark 93f5f11b79 Update local version numbers for 16.10 release 2019-09-27 13:31:35 -07:00
Dan Abramov 8a01b50fc3 eslint-plugin-react-hooks@2.0.1 2019-08-21 21:40:20 +01:00
Dan Abramov 0672829053 Bump ESLint plugin to 2.0 (#16528) 2019-08-21 19:14:34 +01:00
Dan Abramov c433fbb593 Revert "Revert "[ESLint] Forbid top-level use*() calls (#16455)"" (#16525) 
* Revert "Revert "[ESLint] Forbid top-level use*() calls (#16455)" (#16522)"

This reverts commit 507f0fb372.

* Update RulesOfHooks.js
 2019-08-21 15:43:31 +01:00
Sunil Pai 507f0fb372 Revert "[ESLint] Forbid top-level use*() calls (#16455)" (#16522) 
This reverts commit 96eb703bbf.
 2019-08-21 10:20:34 +01:00
Dan Abramov 96eb703bbf [ESLint] Forbid top-level use*() calls (#16455) 
* Add a way to skip/only tests to RulesOfHooks test

* [ESLint] Forbid top-level use*() calls

* Add a regression test for logical expressions

This is not a change. Just adding more coverage.
 2019-08-19 19:54:06 +01:00
Hristo Kanchev 9e64bf18e1 [eslint-plugin-react-hooks] Fixed crash when referencing arguments in arrow functions. (#16356) 
* Fixed issue with def being undefined while referencing arguments.

* Removed todo comment.

* Skip exhaustive deps check if def is null.

* Fixed code formatting in ExhaustiveDeps.

* Removed unneeded comment in ExhaustiveDeps.
 2019-08-14 14:44:06 +01:00
Simen BekkhusandSunil Pai e308a037be chore: make tests compatible with Jest 24 (#15779) 
* chore: make tests compatible with Jest 24

* remove fake rafs

* rollback jsdom for localstorage compat

* Apply suggestions from code review

Co-Authored-By: Sunil Pai <threepointone@oculus.com>

* chore: cleanup lockfile
 2019-08-14 12:32:26 +01:00
Andrew Clark 85d05b3a4d Bump package.json versions 2019-08-08 14:24:39 -07:00
Min ho Kim 2a0f6390ed Fix typos (#16076) 2019-07-08 11:51:29 +01:00
Dan Abramov d48db594ec eslint-plugin-react-hooks@1.6.1 2019-06-24 22:31:14 +01:00
Thomas Broyer 7439b48cf4 Add explicit support for ESLint 6.0.0 (#15974) 
Preemptively update tests wrt 'parser' requiring an absolute
path rather than a package name, even though the project is
still using ESLint 4.

Fixes #15971
 2019-06-24 22:30:12 +01:00
Jordan Rome a383c46788 [ESLint] don't warn for Flow type variables (#15804) 
In Exhaustive Deps check for react-hooks don't warn if the dependency is
a Flow type variable.
 2019-06-03 02:20:51 +01:00
Redmond Tran 793ef9b855 test(eslint-plugin-react-hooks): add coverage for unused custom hook (#15130) 2019-04-25 12:15:29 +01:00
Dan Abramov f33e5790b8 eslint-plugin-react-hooks@1.6.0 2019-03-22 13:56:07 +00:00
Dan Abramov b1cccd1ed1 Warn about setState directly in dep-less useEffect (#15184) 2019-03-22 13:41:10 +00:00
Dan Abramov 78968bb3d9 Validate useEffect without deps too (#15183) 2019-03-21 20:42:13 +00:00
Dan Abramov f0621fe232 Use same example code for async effect warning (#15118) 2019-03-15 19:27:55 +00:00
Dan Abramov f1ff4348c1 Don't suggest a function as its own dep (#15115) 2019-03-15 15:14:01 +00:00
Dan Abramov 935f60083f eslint-plugin-react-hooks@1.5.1 2019-03-14 20:11:22 +00:00
Sophie Alpert 1204c78977 [eslint] Wording tweaks (#15078) 
* [eslint] Wording tweaks

I think these are a little clearer.

* fix tests
 2019-03-13 18:31:39 +00:00
Dan Abramov d0289c7e3a eslint-plugin-react-hooks@1.5.0 2019-03-07 19:43:07 +00:00
Dan Abramov 03ad9c73e4 [ESLint] Tweak setState updater message and add useEffect(async) warning (#15055) 
* Use first letter in setCount(c => ...) suggestion

In-person testing showed using original variable name confuses people.

* Warn about async effects
 2019-03-07 19:40:23 +00:00
Dan Abramov eb6247a9ab More concise messages (#15053) 2019-03-07 15:21:44 +00:00
Dan Abramov 197703ecc7 [ESLint] Add more hints to lint messages (#15046) 
* A clearer message for props destructuring where applicable

* Add line number to the "move function" message

* Add a hint for how to fix callbacks from props

* Simplify code and harden tests

* Collect all dependency references for better warnings

* Suggest updater or reducer where appropriate
 2019-03-07 12:39:15 +00:00
Dan Abramov 6d2666bab1 Fix ESLint rule crash (#15044) 2019-03-07 00:39:39 +00:00
Dan Abramov 9b7e1d1389 [ESLint] Suggest moving inside a Hook or useCallback when bare function is a dependency (#15026) 
* Warn about bare function deps and suggest moving or useCallback

* Clearer wording
 2019-03-06 23:50:02 +00:00
Dan Abramov 5d49dafac8 Enforce deps array in useMemo and useCallback (#15025) 2019-03-06 18:17:54 +00:00
Dan Abramov fa5d4ee43b [ESLint] Treat functions that don't capture anything as static (#14996) 
* Treat functions that don't capture anything as static

* Fix comment
 2019-03-05 21:07:37 +00:00
Dan Abramov f16442a106 eslint-plugin-react-hooks@1.4.0 2019-03-01 20:29:06 +00:00
Dan Abramov e1e45fb367 [ESLint] Suggest to destructure props when they are only used as members (#14993) 
* Suggest to destructure props when they are only used as members

* Add more tests

* Fix a bug
 2019-03-01 19:48:48 +00:00
Dan Abramov 59ef28437a Warn about dependencies outside of render scope (#14990) 2019-03-01 18:16:17 +00:00
Dan Abramov df7b4768c7 [ESLint] Deduplicate suggested dependencies (#14982) 
* Deduplicate suggested dependencies

* Tweak test cases
 2019-03-01 16:10:22 +00:00
Dan Abramov 3ada82b741 Allow extraneous effect dependencies (#14967) 
This makes cases like

  useEffect(() => {
    window.scrollTo(0, 0);
  }, [activeTab]);

not warn.

However, it still warns for unused useCallback/useMemo deps.
 2019-02-27 16:59:11 +00:00