Facebook/react
1
0 Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity
6,760 Commits 681 Branches 148 Tags
9c22ef7e50bd54a67dadfd6c24f637957f0fee1f
Commit Graph
264 Commits
Author SHA1 Message Date
Dmitrii Abramov 5d332f22b4 ReactClassEquivalence 2016-05-25 21:49:31 +01:00
Dmitrii Abramov 517ed859b4 Upgrade to Jasmine 2 2016-05-25 21:48:32 +01:00
Paul O’Shannessy d8a0b9a662 Upgrade to jest-cli@0.9 and use Jasmine2 2016-05-25 21:48:32 +01:00
Ben Alpert 510155e027 Fix instrumentation in shallow rendering (#6867) 
Previously, this threw:

```
 FAIL  src/test/__tests__/ReactTestUtils-test.js (7.291s)
● ReactTestUtils › it can fail context when shallowly rendering
  - TypeError: Cannot read property '_source' of null
        at describeID (src/renderers/shared/devtools/ReactComponentTreeDevtool.js:70:46)
        at Object.ReactComponentTreeDevtool.getStackAddendumByID (src/renderers/shared/devtools/ReactComponentTreeDevtool.js:203:15)
        at checkReactTypeSpec (src/isomorphic/classic/types/checkReactTypeSpec.js:76:58)
        at ReactCompositeComponentMixin._checkContextTypes (src/renderers/shared/stack/reconciler/ReactCompositeComponent.js:668:5)
        at ReactCompositeComponentMixin._processContext (src/renderers/shared/stack/reconciler/ReactCompositeComponent.js:607:14)
        at ReactCompositeComponentMixin.mountComponent (src/renderers/shared/stack/reconciler/ReactCompositeComponent.js:191:30)
        at ReactShallowRenderer._render (src/test/ReactTestUtils.js:483:14)
        at _batchedRender (src/test/ReactTestUtils.js:460:12)
        at ReactDefaultBatchingStrategyTransaction.Mixin.perform (src/shared/utils/Transaction.js:140:20)
        at Object.ReactDefaultBatchingStrategy.batchedUpdates (src/renderers/shared/stack/reconciler/ReactDefaultBatchingStrategy.js:65:19)
        at Object.batchedUpdates (src/renderers/shared/stack/reconciler/ReactUpdates.js:112:20)
        at ReactShallowRenderer.render (src/test/ReactTestUtils.js:453:16)
        at Spec.eval (src/test/__tests__/ReactTestUtils-test.js:289:34)
        at jasmine.Block.execute (node_modules/jest-jasmine1/vendor/jasmine-1.3.0.js:1067:17)
        at jasmine.Queue.next_ (node_modules/jest-jasmine1/vendor/jasmine-1.3.0.js:2100:31)
        at jasmine.Queue.start (node_modules/jest-jasmine1/vendor/jasmine-1.3.0.js:2053:8)
        at Spec.jasmine.Spec.execute (node_modules/jest-jasmine1/vendor/jasmine-1.3.0.js:2380:14)
        at jasmine.Queue.next_ (node_modules/jest-jasmine1/vendor/jasmine-1.3.0.js:2100:31)
        at onComplete (node_modules/jest-jasmine1/vendor/jasmine-1.3.0.js:2096:18)
        at Spec.jasmine.Spec.finish (node_modules/jest-jasmine1/vendor/jasmine-1.3.0.js:2354:5)
        at eval [as onComplete] (node_modules/jest-jasmine1/vendor/jasmine-1.3.0.js:2381:10)
        at jasmine.Queue.next_ (node_modules/jest-jasmine1/vendor/jasmine-1.3.0.js:2110:14)
        at eval (node_modules/jest-jasmine1/vendor/jasmine-1.3.0.js:2090:18)
        at Timeout.e [as _onTimeout] (node_modules/jsdom/lib/jsdom/browser/Window.js:440:19)
        at tryOnTimeout (timers.js:224:11)
        at Timer.listOnTimeout (timers.js:198:5)
```
 2016-05-25 09:46:50 -07:00
Dan Abramov 1070b4aa6c Make sure element is reported correctly by tree devtool 
This adds some tests for getElement() and verifies that it works for text components too.
The code that calls the instrumentation is fixed where necessary so that the tests pass.
 2016-05-17 23:07:35 +01:00
Dan Abramov 4ab203cd73 Test that elements are tracked by tree devtool 
The test is currently failing because text elements are not reported in some cases.
 2016-05-17 22:16:53 +01:00
Dan Abramov 9301cfbc80 Refactor ReactComponentTreeDevtool test 
We extract common logic between DOM and native tests so they don't diverge.

Also, rather than build a tree object in advance for testing, we will walk the tree on the go.
This lets us have much more specific error messages with a clear path when something goes wrong.
 2016-05-17 20:51:00 +01:00
Ben Alpert ba9b985406 Rename host-y things to be "host" not "native" (#6754) 
For clarity.

I left "native event" as-is because there's a lot of it, it's not particularly ambiguous, and SimulateNative/nativeTouchData are public API in ReactTestUtils.
 2016-05-11 23:22:59 -07:00
Dan Abramov 9cebc26638 Fix a failing test and count IDs from one 2016-05-12 02:45:09 +01:00
Dan Abramov d80723b237 Check for missing debugID in ReactDebugTool 
TopLevelWrapper and empty components have ID of 0.
These are implementation details and we don't want to leak them to devtools.
 2016-05-12 00:45:07 +01:00
Paul O’Shannessy 873369cc7c Cleanup: remove @nolint (#6703) 2016-05-05 16:12:17 -07:00
Dan Abramov 5f8f1f6c16 Delete the old ReactPerf 2016-05-03 14:21:28 +01:00
Desmond Brand db175052c0 Add links to docs for addons and top level API (#6555) 
This makes it easier to figure out where the docs live.

Googling for e.g. `react-addons-update` also works, but this should
make things easier for people that hyperclick directly to the source.
 2016-05-02 06:14:28 -07:00
cpojer 8e34514096 Update to Jest 12. Codemod to new Jest APIs. 2016-04-28 14:54:57 +09:00
Ike Peters 9df54e0fce properly handling invalid scryRenderedDOMComponentsWithClass args (#6529) 
properly handling invalid scryRenderedDOMComponentsWithClass args

properly handle invalid scryRenderedDOMComponentsWithClass args
 2016-04-21 17:09:04 -07:00
Dan Abramov 3b28602220 Ignore DOM writes outside the batch in ReactPerf 
ReactDOMInput and a few other classes handle change event by scheduling updateWrapper() in an asap().
It gets executed after the batch, which confuses ReactPerf that expects all DOM writes to happen during a batch.
Since this implementation of ReactPerf relying on the stack is going away, let's plug the hole temporarily by ignoring DOM writes that occur during postponed updateWrapper(). In any case, they have no relation to actual calculations of wasted renders, as they don't occur due to updateComponent(), but rather due to onChange() special DOM behavior.

This fixes #5548
 2016-04-14 20:57:44 +01:00
Dan Abramov ae56910573 Merge pull request #6362 from gaearon/no-owner-in-test-utils 
Elements from functional components in TestUtils should have no owner
 2016-04-14 18:54:10 +01:00
Paul O’Shannessy 95cd88d07a Ensure default injection is injected for test utils 2016-04-06 17:43:08 -07:00
Paul O’Shannessy 42b1cba048 Make sure simulated events don't warn when providing extra event properties 2016-04-05 14:53:25 -07:00
Paul O’Shannessy 1573baaee8 Use Object.assign directly and inject object-assign at compile 2016-04-04 09:53:25 -07:00
Dan Abramov 291379c272 Elements from functional components in TestUtils should have no owner 
Fixes #5292 and #6194
 2016-03-28 21:46:33 +01:00
Dan Abramov 0f1240e877 Fix ReactPerf.printOperations() test to work with createElement = false 2016-03-23 22:24:32 +00:00
Dan Abramov cfec10bd51 Remove unused export from DOMChildrenOperations 2016-03-19 21:05:05 +00:00
Dan Abramov b6547734c6 Strip complex values from ReactPerf.printDOM() output 
Fixes #6288
 2016-03-17 21:23:43 +00:00
Dan Abramov ea55d66760 Rename ReactPerf methods to match the upcoming ReactPerf revamp 2016-03-17 20:18:42 +00:00
Dan Abramov b322d65320 Fix the ReactDefaultPerf test to match changes in #6286 2016-03-17 19:23:21 +00:00
Dan Abramov 51d37c64c3 Make ReactPerf measurements opaque 
We intend to change the measurement format significantly in #6046. In order to introduce the new ReactPerf during 15.x release cycle, we are making the measurement structure opaque-ish in 15.0.
 2016-03-17 18:48:55 +00:00
Paul O’Shannessy 093bb22030 Update lint config, dependencies, fix issues 
This also fixes messages from new synthetic events warnings
 2016-03-03 10:16:02 -08:00
Michael McDermott 18af9bc91e Fixed some linting warnings and some mis-spacing in SyntheticEvent warnings. 2016-03-02 18:40:23 -05:00
Ben Alpert e8fb8c7870 Fix text component rendering with server markup 
These weren't caught by CI in #5753 because we don't automatically test that yet... fixing that next.
 2016-02-19 09:48:05 -08:00
Michael Wiencek 203850013a Don't wrap text in <span> elements 
Instead, use opening and closing comment nodes to delimit text data.
 2016-02-18 13:49:14 -06:00
Ben Alpert 3a4e1dbb5b Fix merge conflict in #4940 2016-02-17 17:20:37 -08:00
Ben Alpert acb49363d5 Remove "construct" call except on composites 
This is a little simpler (and a teeny tiny bit faster). The one in ReactCompositeComponent stays because of the way we create ReactCompositeComponentWrapper inside instantiateReactComponent.
 2016-02-17 15:48:24 -08:00
cpojer 383e2f938d Update to jest-cli 0.9. 2016-02-17 13:01:14 +09:00
jim dd390b3e36 Errors in componentWillUnmount should be caught by error boundary on initial render. 2016-02-11 17:44:35 -08:00
Paul O’Shannessy 422b4e105c Merge pull request #5840 from koba04/release-event-target-on-destructor 
Release syntheticEvent.target on the destructor
 2016-01-15 16:38:42 -08:00
Toru Kobayashi be0551d01e Release syntheticEvent.target on the destructor 2016-01-14 15:09:56 +09:00
jim e8af100849 Removed getDOMNode from react classes. 2016-01-11 23:32:22 -08:00
Ben Alpert 0ebc7b60e1 Revert "Merge pull request #5689 from jimfb/cleanup-5151" 
This reverts commit 067547c1d1, reversing
changes made to 102cd29189.
 2016-01-05 15:08:15 -08:00
Jim 067547c1d1 Merge pull request #5689 from jimfb/cleanup-5151 
Get rid of getNativeNode()
 2016-01-05 14:42:05 -08:00
Rick Beerendonk bef45b0b1a Year-agnostic copyright message, like React Native uses, to prevent the need for yearly changes. 2015-12-29 20:20:32 +01:00
jim 8eabf84204 Get rid of getNativeNode() 2015-12-17 19:04:27 -08:00
Justas Brazauskas 0886273438 Fix few typos in React docs and comments 2015-12-13 16:39:07 +02:00
Ben Alpert 46f5251c66 Remove @typechecks 
These don't really do anything.

```
codemod.py -d src --extensions js -m '\s* \* @typechecks.*?\n' '\n'
```

with "yes to all".
 2015-12-10 11:26:45 -08:00
Scott Feeney 9c21e2f3c4 shallow render: fix setState in componentWillMount 2015-12-01 19:43:52 -08:00
Ben Alpert 418ba27485 Kill global queue in ReactMultiChild 
As we move away from using HTML for updates, this becomes less useful.
 2015-11-25 12:59:02 -08:00
Ben Alpert 812e1a877f Merge pull request #5500 from hejld/master 
Update DOM_OPERATION_TYPES mappings for ReactDefaultPerfAnalysis
 2015-11-20 11:21:06 -08:00
Sebastian Markbåge 64f795e5ef Merge pull request #5411 from simonewebdesign/master 
ReactShallowRenderer.render returns the rendered output
 2015-11-20 11:20:37 -08:00
hejld a3779421a1 Update DOM_OPERATION_TYPES mappings for ReactDefaultPerfAnalysis 2015-11-18 20:58:32 +01:00
Ben Alpert 1a6d1e74e0 Merge pull request #5330 from laskos/fix-shallow-rendering-function-refs 
Fix shallow renderer with ref as function
 2015-11-17 23:53:00 -08:00