Commit Graph
9369 Commits
Author SHA1 Message Date
Dan AbramovandGitHub 94907cdc5f Fix lint 2017-11-10 16:30:38 +00:00
Bernardo SmaniottoandDan Abramov 7c150a8078 Refactor SyntheticClipboardEvent tests to only use the public API (#11365)
* Refactor SyntheticClipboardEvent tests to only use the public API

* Replace local document creation by document body reset on each test case execution

* Set up and tear down container separately

* Tweak test assertion logic for clarity

* Remove simulate abstraction and create events directly

* Ensure the test covers IE8 behavior

* Verify that persistence works
2017-11-10 15:53:20 +00:00
Flarnie MarchanandGitHub 365c2db55e Add CODE_OF_CONDUCT.md (#11512)
**what is the change?:**
Adding a document linking to the Facebook Open Source Code of Conduct,
for visibility and to meet Github community standards.

**why make this change?:**
Facebook Open Source provides a Code of Conduct statement for all
projects to follow.

React already links to this Code of Conduct in the README, which is
great!

Exposing the COC via a separate markdown file is a standard being
promoted by Github via the Community Profile in order to meet their Open
Source Guide's recommended community standards.

As you can see, adding this file will complete [React's Community Profile](https://github.com/facebook/react/community)
checklist and increase the visibility of our COC.

**test plan:**
Viewing it on my branch -
(Flarnie will insert screenshot)

**issue:**
internal task t23481323
2017-11-10 12:17:36 +00:00
Andrew ClarkandGitHub c580082861 Measure time between scheduling an async callback and flushing it (#11506)
* Measure time between scheduling an async callback and flushing it

Helps detect starvation issues.

* Debug comments should print directly above the next measure

* Better warning message

Most users won't know what "expires" means
2017-11-10 12:14:25 +00:00
Audy TanudjajaandDan Abramov ae7639c116 Remove tests in ReactDOMComponent-test depending on internal API (#11337)
* Remove inputValueTracking from ReactDOMComponent-test dependency

* prettier

* use node._valueTracker and add some test cases to make sure that value being tracked

* using Object.getOwnPropertyDescriptor to get the tracked value

* move getValueTracker to each test case and use its corresponding prototype

* remove tests and move the value tracker definition before React is imported

* Delete these tests completely
2017-11-10 12:01:59 +00:00
Dan AbramovandGitHub 54051f9738 Fix accidental leftover requires (#11513) 2017-11-10 11:43:13 +00:00
Kristofer SelbekkandDan Abramov 5bfb878743 Add note about mistaken named / default export (#11505)
This commit adds a note about the possibility of erroneously
mistaking named and default exports to an existing error message.
2017-11-09 18:28:35 +00:00
Brian VaughnandGitHub ac0e670545 Release script tweaks (#11504)
* Added missing params object to execUnlessDry call

* Public package names are no longer hard-coded

* Added "v" prefix to git tag

* Show more accurate in-progress duration

* Properly bucket-bridage params

* Prettier

* Publish command logs stack with error
2017-11-09 16:29:51 +00:00
Clement HoangandGitHub dc48cc38ea Enable createRoot API in www (#11501) 2017-11-09 15:33:49 +00:00
Dan Abramov c3a529325f Fix the release script 2017-11-09 15:16:24 +00:00
Dan Abramov 1d3d791ca5 Updating CHANGELOG.md for 16.1.0 release v16.1.0 2017-11-09 15:04:27 +00:00
Dan Abramov 7d9b4ba35a Update bundle sizes for 16.1.0 release 16.1.0 2017-11-09 14:55:57 +00:00
Dan Abramov 7e8b0c5800 Updating package versions for release 16.1.0 2017-11-09 14:53:27 +00:00
Dan Abramov 17aa4d4682 Update bundle sizes for 16.1.0-rc release 16.1.0-rc 2017-11-08 22:59:38 +00:00
Dan Abramov 2437e2c3da Updating package versions for release 16.1.0-rc 2017-11-08 22:54:10 +00:00
Dan AbramovandGitHub c83596df65 Consolidate build process with GCC (#11483)
* Consolidate build process with GCC

* Record sizes

* Refactor header and footer wrapping

It is easier to understand if we just explicitly type them out.
2017-11-08 22:37:11 +00:00
Mitermayer ReisandDan Abramov e88f292041 Fixing typo on test (#11495)
- As ironicaly as it sounds the tests was checking for misspelling
2017-11-08 21:23:46 +00:00
Brian VaughnandGitHub 8a0285fb43 Release script follow-up (#11482)
* Add a timeout before querying npm right after publish

* Conditionally log some post publish steps

* Print ready-to-paste 'yarn add' instructions for CRA prerelease testing
2017-11-08 19:59:26 +00:00
Haroen ViaeneandDan Abramov a2ec771360 docs(readme): correct link for "your first PR" (#11489)
This info is now on the website and not in CONTRIBUTING.md
2017-11-08 18:48:19 +00:00
Dan AbramovandGitHub c932885e79 Fix React.createFactory() crash (#11484)
* Add a failing test for createFactory in production

* Fix createFactory() in production

* Add more prod-only tests

* Fix prettier

* Run prettier 1.8.1
2017-11-08 00:02:07 +00:00
Clement HoangandGitHub 94f44aeba7 Update prettier to 1.8.1 (#10785)
* Change prettier dependency in package.json version 1.8.1

* Update yarn.lock

* Apply prettier changes

* Fix ReactDOMServerIntegration-test.js

* Fix test for ReactDOMComponent-test.js
2017-11-07 18:09:33 +00:00
Andrew ClarkandGitHub 05f3ecc3ea Performance tool: Warn when interrupting an in-progress tree (#11480)
* Performance tool: Warn when interrupting an in-progress tree

* Include the name of the component that caused the interruption
2017-11-07 16:52:48 +00:00
Dan AbramovandGitHub de48ad1646 Add react-call-return to publish list 2017-11-07 16:16:46 +00:00
Dan Abramov 0bd2c2bb3d Fix error reporting in release script 2017-11-07 15:03:08 +00:00
Dan Abramov a653f910f8 Update bundle sizes for 16.1.0-beta.1 release 16.1.0-beta.1 2017-11-07 14:53:31 +00:00
Dan Abramov 0acde04377 Update error codes for 16.1.0-beta.1 release 2017-11-07 14:53:31 +00:00
Dan Abramov 97a7c5f0d4 Updating package versions for release 16.1.0-beta.1 2017-11-07 14:51:36 +00:00
Dan Abramov b2ff29d38c Add missing "files" field to react-call-return package 2017-11-07 14:07:37 +00:00
Dan AbramovandGitHub cbd6d43417 Amend changelog 2017-11-07 14:02:15 +00:00
TomandDan Abramov 48012ef839 Add warning for componentDidReceiveProps() (#11479)
* Add warning for componentDidReceiveProps()

* Adjust message for componentDidReceiveProps() warning
2017-11-07 14:00:31 +00:00
Kiho · ChamandDan Abramov acb268c577 minor typo (#11477)
concurently --> concurrently
2017-11-07 09:39:15 +00:00
Dan AbramovandGitHub 2c228f15a0 Correctly replace shims using relative requires (#11472) 2017-11-06 16:53:13 +00:00
Dan AbramovandGitHub 4480f75ff9 Amend changelog 2017-11-06 16:19:35 +00:00
Dan AbramovandGitHub 96914c98df Split static and dynamic www feature flags (#11471) 2017-11-06 16:17:43 +00:00
Dan AbramovandGitHub 3b27160f82 Put perf integration behind a feature flag (#11455)
* Enable User Timing API integration with a feature flag

* Expose a way to toggle user timing flag in www

* Update ReactNativeCSFeatureFlags.js

* Update ReactFeatureFlags.js
2017-11-06 16:07:08 +00:00
Dan Abramov 699496164d Record sizes 2017-11-06 15:34:42 +00:00
Dan AbramovandGitHub 46f7b0d945 Fix dead code elimination for feature flags (#11453)
* Fix dead code elimination for feature flags

Turning flags into named exports fixes dead code elimination.

This required some restructuring of how we verify that flag types match up. I used the Check<> trick combined with import typeof, as suggested by @calebmer.

For www, we can no longer re-export `require('ReactFeatureFlags')` directly, and instead destructure it. This means flags have to be known at init time. This is already the case so it's not a problem. In fact it may be better since it removes extra property access in tight paths.

For things that we *want* to be dynamic on www (currently, only performance flag) we can export a function to toggle it, and then put it on the secret exports. In fact this is better than just letting everyone mutate the flag at arbitrary times since we can provide, e.g., a ref counting interface to it.

* Record sizes
2017-11-06 14:14:48 +00:00
Dan AbramovandGitHub b6a7beefe4 Use Rollup legacy mode for www builds (#11469) 2017-11-06 13:57:15 +00:00
Dan AbramovandGitHub 8e7cb85788 Expose injectIntoDevTools() to renderers (#11463) 2017-11-06 13:09:02 +00:00
Raphael AmorimandDan Abramov bb3c22c66f Use const/let in more places (#11467)
* Convert ReactDOM to const/let
* Convert ReactDOMComponentTree to const/let
* Convert ReactDOMComponentTree to const/let
* Convert getNodeForCharacterOffset to const/let
* Convert getTextContentAccessor to const/let
* Convert inputValueTracking to const/let
* Convert setInnerHTML to const/let
* Convert setTextContent to const/let
* Convert validateDOMNesting to const/let
2017-11-06 11:30:03 +00:00
Joe LimandDan Abramov 1d1f7038ec Handle prettier error (#11466)
* handle prettier error

* error if prettier fail
2017-11-06 11:17:51 +00:00
Joe LimandDan Abramov 40fbed5721 Use prettier api (#11458)
* use prettier-api

* fix string to boolean

* fix eslint

* fix typo

* cleanup

* use object assign
2017-11-05 21:06:08 +00:00
Joe LimandDan Abramov e2e7fcce7e switch ordering of logical and (#11462) 2017-11-05 14:46:46 +00:00
Dan AbramovandGitHub 92b7b172cc Use named exports in more places (#11457)
* Convert EventPlugin{Hub,Registry} to named exports

* Convert EventPluginUtils to named exports

* Convert EventPropagators to named exports

* Convert ReactControlledComponent to named exports

* Convert ReactGenericBatching to named exports

* Convert ReactDOMComponentTree to named exports

* Convert ReactNativeComponentTree to named exports

* Convert ReactNativeRTComponentTree to named exports

* Convert FallbackCompositionState to named exports

* Convert ReactEventEmitterMixin to named exports

* Convert ReactBrowserEventEmitter to named exports

* Convert ReactNativeEventEmitter to named exports

* Convert ReactDOMEventListener to named exports

* Convert DOMMarkupOperations to named exports

* Convert DOMProperty to named exports

* Add suppression for existing Flow violation

Flow didn't see it before.

* Update sizes
2017-11-05 11:58:36 +00:00
Joe LimandDan Abramov 7432013872 make linc script cross platform (#11447)
* make linc script cross platform

* fix typo

* attempt to fix long command error

* use eslint node api

* Update linc.js
2017-11-04 18:09:28 +00:00
Jonathan SilvestriandDan Abramov 366600d0b2 Rewrite setInnerHTML tests to use Public API. (#11385)
* Rewrite setInnerHTML tests to use Public API.

* Rename variables and drop unnecessary variable assignments.

* Rename testfile to dangerouslySetInnerHTML-test.js

* Properly prettify test file.

* Rewrite SVG tests to verify we recover from missing innerHTML
2017-11-04 18:04:13 +00:00
Mike WilcoxandDan Abramov 51c101fc48 Update getEventKey tests to use public API (#11299) (#11317)
* Add flow annotation to getEventKey.

* Remove Simulate and SimulateNative for native events.

* Style nits

* Oops
2017-11-04 17:11:49 +00:00
Dan Abramov 646781b0b4 Tweak the bundle validation script
Exit on error, and minor nits.
2017-11-04 13:00:49 +00:00
Soo Jae HwangandDan Abramov da86a4553b Validate built bundles exists (#11452) 2017-11-04 12:57:48 +00:00
Dan AbramovandGitHub 028691b43d Update changelog 2017-11-04 00:26:29 +00:00