Commit Graph
880 Commits
Author SHA1 Message Date
Cheng Lou 775d2a3952 Merge pull request #1184 from spicyj/setInnerHTML
Consolidate innerHTML setting logic
2014-04-12 00:58:37 -07:00
Ben Alpert 534e7c06e9 Consolidate innerHTML setting logic
See https://github.com/facebook/react/commit/7eb33ef#commitcomment-5447724.
2014-04-12 00:41:54 -07:00
Cheng Lou ed1b4dbfb5 Merge pull request #1394 from spicyj/gh-1164
Add test for isValidDescriptor
2014-04-11 20:48:29 -07:00
Cheng Lou f4f6b055df Merge pull request #1190 from spicyj/custom-set-null
Remove custom attrs properly when setting to null
2014-04-11 18:02:02 -07:00
Paul O’Shannessy 3e2182fd16 Merge pull request #1231 from spicyj/gh-1227
Batch updates caused by handlers in multiple roots
2014-04-11 17:16:04 -07:00
Paul O'Shannessy 3bf12bba0d add displayName to component spec functions
closes #992
2014-04-11 16:39:45 -07:00
Cheng Lou d673e51044 Make PropType.object pass for Date and RegExp instances
8855d6153e gave more accurate error messages for date and regexp by returning 'date' and 'regexp' respectively from `getPropType`.
However, for the object primitive check, which compares the instance passed with `getPropType's` return string, `object` !== 'date'.
This adds special hanlding for those.
2014-04-11 16:39:02 -07:00
Ben Alpert 697bf73c5f Add test for isValidDescriptor
Fixes #1164.

Test Plan: grunt test
2014-04-09 22:53:22 -07:00
Justin Jaffray f88936977f Add tests for oneOfType with shape 2014-04-09 22:23:43 -07:00
Cheng Lou 8855d6153e Revamp and fix PropTypes
This uses the return value (an Error or nothing) to indicate whether a prop passes validation or not. It used to be done through calling `console.warn` as a side-effect, except this didn't work well with and `oneOfType`, which calls each validator.

The solution was to insert a `.weak` prop to each validator to suppress the warning message. This is overkill and also doesn't work well in because it increases the potential API surface. Plus, letting the validators warn it can't be easily used for logging, especially for custom validators.

So `.weak` is no longer needed: fixes https://github.com/facebook/react/issues/863.

Backward compatibility for custom validators: since they didn't return anything and directly call `console.warn` or something, this doesn't break them.

Improvements:

  - `arrayOf`, `oneOfType` and `oneOf` got better message now, since they can get hold of their validator's message and output that instead of a generic `warning: bla`.
  - More complete tests, including testing custom types and `isRequired` on everything.

Bug fixes:

  - oneOfType(...).isRequired didn't work. The workaround was to use `oneOfType(a.isRequired, b.isRequired, ...)`. This means `oneOfType(a.isRequired, b)` doesn't make sense. The new version simply makes `oneOfType(...).isRequired` possible.
  - `oneOf([true])` worked for 'true' boolean because it converted everything to string before comparing. It no longer does.
- `oneOf([true]).isRequired` didn't work.

(see #1294)
2014-04-09 18:50:53 -07:00
Cheng Lou 5a9d0c6a12 Update invalid render error message
forgot to update the message following the previous diff on rendering null.
2014-04-09 18:50:11 -07:00
Tim Yung 356e85cd6a Separate performanceNow into own project 2014-04-09 18:50:11 -07:00
Josh Yudaken 5c9d616735 Add start property that is used by the <ol> tag
Property was missing
2014-04-09 17:50:34 -07:00
Paul O’Shannessy bff6d50796 Merge pull request #1364 from spicyj/key-collisions-2
Ignore children with clashing keys
2014-04-08 18:11:36 -07:00
Paul O’Shannessy ccafb030cb Merge pull request #813 from spicyj/e-view-detail
Normalize view and detail properties
2014-04-08 14:23:46 -07:00
Ben Alpert 348399a594 Let early returns do their thing 2014-04-08 14:08:16 -07:00
Ben Alpert 4d62e1ef59 Don't fail if target.ownerDocument is null
See f71dbab.
2014-04-08 14:08:16 -07:00
Ben Alpert 5fa001b12c Normalize view and detail properties 2014-04-08 14:08:16 -07:00
Cheng Lou f0f59877aa Make rendering to null work and make it injectable
This allows render to return `null`. Under the hood, this renders a `script` tag.

closes #1127
2014-04-08 10:12:18 -07:00
Paul O'Shannessy af3c04b43b Warn better for key issues
We weren't warning for key issues at the top level (renderComponent)
level at all. This makes us do that, even if it's not quite perfect.

closes #1351
2014-04-07 18:18:50 -07:00
Ben Alpert 216fcdeb42 Ignore children with clashing keys
Fixes #566.
2014-04-07 13:50:42 -07:00
Ben Alpert ec6da04f6a Make MountReady more reusable, reduce allocations
Test Plan:
grunt test
2014-04-06 17:06:12 -07:00
Ben Alpert 933dde9c6d Batch updates caused by handlers in multiple roots
Fixes #1227.

It seems rare that event handlers in two roots nested in the DOM will update the same component in the same tick, but if that happens, the updates should be batched together.
2014-04-03 17:41:04 -07:00
Paul O’Shannessy 4f6800c2a4 Merge pull request #1306 from twobit/master
Add dx and dy attributes for SVG text
2014-04-03 15:05:44 -07:00
Paul O’Shannessy 00aa33446b Merge pull request #1325 from venmo/add-scrolling-attribute
Add scrolling attribute for <iframe>
2014-04-03 09:56:07 -07:00
Paul O’Shannessy 0aba933911 Merge pull request #1313 from spicyj/ms-prefix
Support `ms` vendor prefix when generating markup
2014-04-03 09:25:41 -07:00
Sebastian Markbage b44761135e Remove toJSON
This was temporarily needed since clone on mount introduced a cyclic reference
in __DEV__. This reverts that change since we now have descriptors.

To avoid a problem where toJSON may collide.
2014-04-01 17:07:57 -07:00
Paul O’Shannessy 8ccb363a8e Merge pull request #1308 from chenglou/pure
add `ReactComponentWithPureRenderMixin` to addons
2014-04-01 14:32:18 -07:00
Paul O’Shannessy c8fc3e38ab Merge pull request #1329 from irae/transition-group-leftovers
Remove leftovers from ReactTransitionGroup rewrite
2014-04-01 10:16:53 -07:00
Ben Newman 60d16be90b Merge pull request #1330 from spicyj/clone-imm
Clone objects in immutable tests.
2014-03-30 19:25:56 -04:00
Cheng Lou 7cbbff01e7 Merge pull request #1334 from spicyj/non-numeric-top-level
Don't break on top-level non-numeric object keys
2014-03-30 14:03:18 -07:00
Ben Alpert a89ed9b8dc Don't break on top-level non-numeric object keys
Previously, this threw (in `__DEV__` only) in `ReactCurrentOwner.current.constructor.displayName` because `ReactCurrentOwner.current` is null:

```
React.renderComponent(<div>{{1: <div />, 2: <div />}}</div>, document.body);
```
2014-03-30 13:55:45 -07:00
Stephen Murphy 468007612f Merge branch 'master' of github.com:facebook/react 2014-03-30 12:53:26 -07:00
Cheng Lou 09ca4a9c80 [Jshint] Allow Jasmine globals in *-test.js
Editors that inline lint use`.jshintrc and directly lint the open
*-test.js files. This makes those linters actually useful.
2014-03-30 12:52:49 -07:00
Ben Alpert 99e943dd13 Clone objects in immutable tests
Fixes #1314, fixes #1328.

Test Plan:
`grunt test`, `grunt test --debug` in Chrome and Firefox.
2014-03-29 17:01:23 -10:00
Irae 27ea2c7e51 Remove leftovers from ReactTransitionGroup rewrite
Looks like while rewriting @petehunt forgot to remove this block.
See: 9ac27cb551
This block used to contain the only `runNextTick` ocurrences in the whole project.
No tests broken after removal, no documentation affected.
2014-03-29 14:46:02 -07:00
Thomas Boyt 8a69b5bc98 Add scrolling attribute for <iframe> 2014-03-29 13:41:34 -04:00
Ben Alpert c0de6b51ff Fix spelling of 'existence' 2014-03-28 10:44:03 -10:00
Paul O’Shannessy 7982ba0571 Merge pull request #1310 from plievone/patch-1
Fix hasOwnProperty check typo in mixStaticSpecIntoComponent
2014-03-28 13:09:14 -07:00
Isaac Salier-Hellendag 807e3dc423 BeforeInputEventPlugin: Support Opera <= 12
Add support for Opera <= 12 (Presto) in `BeforeInputEventPlugin`.

It turns out that Opera 12 has a `TextEvent` in `window`, but doesn't actually fire any input events. Even `input` apparently doesn't fire. Fall back to keypress handling in this case.
2014-03-28 12:33:10 -07:00
Sebastian Markbage c40e06f728 First phase to true descriptors
This moves all convenience constructors to use frozen ReactDescriptors.
2014-03-28 12:32:53 -07:00
Ben Alpert 6406183f78 Support ms vendor prefix when generating markup 2014-03-27 19:46:02 -10:00
Paul O'Shannessy fe9cecd507 Clean up assertions on descriptors
By making this fail, we catch a lot of tests that are expecting rendered
instances but are actually operating on descriptors.
2014-03-27 13:41:18 -07:00
Pete Hunt 976826aec0 Remove extraneous assert 2014-03-27 13:41:10 -07:00
plievone 65d16883a5 Fix hasOwnProperty check typo in mixStaticSpecIntoComponent 2014-03-27 21:21:12 +02:00
Cheng Lou 0a483e3799 add ReactComponentWithPureRenderMixin to addons 2014-03-27 11:27:45 -07:00
Ben Alpert 3cdef1a86a Fix docstring arg order in createDOMComponentClass 2014-03-27 08:27:19 -10:00
Stephen Murphy 94c2f961fd added dx and dy for laying out text with relative offsets 2014-03-26 16:57:50 -07:00
Isaac Salier-Hellendag 5476f9168b Repair spacebar textInput
Browsers that natively support the `textInput` event appear to have a bug: when preventing default behavior for a `textInput` event occurring for a spacebar keypress, the character is prevented from being inserted **but the browser scrolls down**.

Minimal repro example: http://jsfiddle.net/salier/bX4fw/

This is ridiculous, since scrolling makes no sense when the user is focused in a textinput or contenteditable. Preventing default at the `textInput` stage should mean to prevent the character from being inserted, and should have no impact at all on scrolling behavior. I have filed this as a Chromium bug (https://code.google.com/p/chromium/issues/detail?id=355103) but I'm not going to hold out much hope that they'll fix it.

To resolve this, I'm special-casing the spacebar character at the plugin level, in `BeforeInputEventPlugin`. I looked for ways to do this at the component level, but it seems to me that this is simply a browser bug and it's cleaner to handle it there.

In browsers that can use the native `textInput` event, I'm checking the code of the pressed key. If it's the spacebar, we dispatch the synthetic event as if there were no native `textInput` event -- as if we were running Firefox. Then, if the synthetic event is not canceled and we make it through to the native `textInput` event, bail if the character data is a space character.
2014-03-25 13:05:44 -07:00
Cheng Lou 09333a3819 Remove last uses of {' '} in docs and tests
Whitespace fix is in, so no need for {' '} anymore.
2014-03-25 13:05:44 -07:00