Commit Graph
1689 Commits
Author SHA1 Message Date
Isaac Salier-Hellendag 4ff99a2873 Merge pull request #3639 from salier/select-event-plugin
Skip SelectEventPlugin extraction if no listeners
2015-04-09 18:29:37 -05:00
Isaac Salier-Hellendag 47b147f392 Skip SelectEventPlugin extraction if no listeners
If there are no listeners for `onSelect` yet, do not extract events. This way we can avoid issues where listeners have been set up for some event dependencies for `SelectEventPlugin`, but not all.

For instance, if `topMouseDown` has been registered but not `topMouseUp`, event extraction will set the `mouseDown` flag to true but never unset it. This leads to bugs when `onSelect` is registered and should be firing during normal key behavior. Since no `topMouseUp` has yet occurred to unset the flag, `onSelect` fails to fire.
2015-04-09 17:55:42 -05:00
Jim 0185c68c91 Merge pull request #3615 from jsfb/enable-new-context
Switch to parent-based context.  Fixes #2112.
2015-04-09 13:21:26 -07:00
Teodor Szente cdd359b710 check if is undefined 2015-04-09 20:12:22 +03:00
Teodor Szente 8f6bae21fb check if type.prototype is object 2015-04-09 19:29:25 +03:00
Jim f1cd867323 Merge pull request #3580 from robertknight/2402-warn-multiple-copies-of-react-on-same-page
Warn when multiple instances of React are loaded on the same page
2015-04-08 19:18:44 -07:00
Ben Alpert 50e08d4269 Merge pull request #3627 from spicyj/mut-warn-clone
Refer to cloneElement in mutation warning
2015-04-08 15:33:56 -07:00
Ben Alpert e60a26a682 Kill ReactDoNotBindDeprecated
No one uses this.
2015-04-08 15:15:02 -07:00
Ben Alpert 05f6e7de71 Refer to cloneElement in mutation warning 2015-04-08 14:51:17 -07:00
Ben Alpert 44f0e801df Merge pull request #3587 from spicyj/kill-plq
Kill ReactPutListenerQueue
2015-04-08 14:49:53 -07:00
Paul O’Shannessy a34cf222ba Merge pull request #3604 from Charca/firefox-tests-fixes
Fixes for several failing tests in Firefox and Safari
2015-04-08 10:34:57 -07:00
Baraa Hamodi d9d77bc9a5 Update ReactDOMIframe-test.js 2015-04-08 13:06:37 -04:00
Baraa Hamodi c9e3a32bc5 Update ReactCompositeComponentNestedState-test.js 2015-04-08 13:02:43 -04:00
Ben Alpert 057f41ec0f Merge pull request #3595 from spicyj/select-ssr
Fix server-side rendering of <select>
2015-04-07 16:49:10 -07:00
Ben Alpert ea089fdfe6 Fix server-side rendering of <select>
Fixes #1398.
2015-04-07 16:48:58 -07:00
Jim 7d44917531 Switch to parent-based context. Fixes #2112. 2015-04-07 14:49:29 -07:00
Jan Kassens eda9ec53b5 Fix for style not always reset when set to null
When the style property existed, but was set to null, `this._previousStyleCopy`
was not set back to `null` causing an old value to persist. This broke setting
the style to `null` the next time.

Fixes #3606.
2015-04-07 12:17:06 -07:00
Maxi Ferreira 49745e7bff Fixes for several failing tests in Firefox and Safari 2015-04-07 01:37:27 -03:00
Ben Alpert 7529e6de47 Kill ReactPutListenerQueue
As far as I can tell, this is almost equivalent and is simpler. When a component's componentDidMount is called, all the listeners for that subtree will have been attached which I think is all that matters.
2015-04-04 17:34:35 -07:00
Robert Knight 8ad58ae45a Warn when multiple instances of React are loaded on the same page
This causes a variety of hard-to-debug issues.
See #2402 for examples.

Fixes #2402
2015-04-03 11:46:58 +01:00
Cheng Lou f3e6436bee Remove last call to getDOMNode in tests 2015-04-02 17:26:19 -04:00
Ben Alpert dea7efbe16 Merge pull request #3555 from spicyj/native-overrides
Import ResponderEventPlugin from react-native
2015-04-02 14:13:35 -07:00
Ben Alpert 5a01f5f6a9 Fix ResponderEventPlugin to work in core React again
Test Plan: jest, grunt fasttest
2015-04-02 13:33:47 -07:00
Murad 6963ea4bfc Update shallowEqual.js 2015-04-03 03:44:37 +08:00
Murad d912329c97 Update shallowEqual.js
optimize for lint rules
2015-04-03 00:12:07 +08:00
Murad d2bb4728f0 Increase speed of shallowEqual
All testes successfully completed.

- for-in in browsers is slow, i replaced him by Object.keys + for(array)
- simple check of lengths let us not iterate if not same
- now we dont need to test for B's keys missing from A, because if length's is same and prev check success - objB hasn't more keys
- micro optimize: calling objB.hasOwnProperty
- micro optimize: replaced !objA || !obj for more speedy check === null

#inspiredby https://github.com/jurassix/react-immutable-render-mixin/pull/4
2015-04-02 23:43:29 +08:00
Jim 3fad007bdb Merge pull request #3560 from mariodu/mariodu
fix render order error in safari.  Fixes #3560.
2015-04-01 17:40:09 -07:00
Ben Alpert 08e4420019 Use setState transaction for TransitionGroup instead of extra property 2015-04-01 14:34:01 -07:00
Ben Alpert 205273d2ee Merge pull request #2549 from ashtuchkin/fix-transitiongroup-multiremove
Fix ReactTransitionGroup behavior when removing several children at once
2015-04-01 14:33:42 -07:00
Jeff Chan af7e43269f Fix immutability helper to check hasOwnProperty safely
This makes `update({}, {'hasOwnProperty': {$set: 'yolo'}})` work.
2015-04-01 12:25:12 -07:00
凌恒 6094ebbc39 update comment 2015-04-01 23:59:43 +08:00
凌恒 54a74d95bb deal IE8 out of size error 2015-04-01 23:56:05 +08:00
凌恒 d4adaee4eb use ie8 feature detect instead of try catch 2015-04-01 21:46:40 +08:00
凌恒 e1a8d69840 fix render order error in safari 2015-04-01 18:13:03 +08:00
Ben Alpert 036d342189 Fix unused variable lint from #3552 2015-03-31 17:06:42 -07:00
Ben Alpert 6ec3b65169 Import ResponderEventPlugin from react-native
This is a direct import of the files from react-native, with the license headers updated.
2015-03-31 15:21:47 -07:00
Paul O’Shannessy 94a3b0f8a3 Merge pull request #3552 from James-Dunn/fix-for-loops
Remove caching from for loops
2015-03-31 10:30:44 -07:00
James 90dcc1ffb7 Remove caching from for loops
Removed caching from for loops as it does not seem to increase
performance and makes the code harder to read.
2015-03-31 10:22:52 +04:00
Paul O’Shannessy 18d608820e Merge pull request #3519 from jonchester/patch-1
Add IE-specific 'unselectable' attribute
2015-03-30 15:27:13 -07:00
jonchester a0265fe8b7 Add IE-specific 'unselectable' attribute
I ended up needing to add this attribute to work around a common IE bug, that clicking on a scrollbar gives focus to the scroll container. I needed to set it as MUST_USE_ATTRIBUTE or the attribute would not be passed through by React successfully.

remove trailing spaces
2015-03-30 07:44:08 -07:00
Jim b3c75d82b2 Merge pull request #3521 from grant/master
Display error when trying to create an element of type `boolean`. Fixes #3478
2015-03-26 14:39:32 -07:00
Mert Kahyaoğlu 6248406d6a remove unrelated doc line 2015-03-26 21:08:32 +02:00
Grant Timmerman 59a914aac0 Disable numeric element types 2015-03-26 10:07:56 -07:00
Grant Timmerman 3c9ea72795 Display error when trying to create an element of type boolean. Fixes #3478 2015-03-26 01:21:54 -07:00
Ben Alpert b32fbef7c5 Add missing semicolon 2015-03-25 18:10:49 -07:00
Ben Alpert 7c6694987d Tweak validation message, add html support
The old message made no sense if you had a > div > a or similar. I'm clearly feeling sloppy today.
2015-03-25 17:24:13 -07:00
Ben Alpert 07b7e8424d Remove stray console.log comment 2015-03-25 17:06:42 -07:00
Ben Alpert 76bb96ef21 Validate only against problematic tag nesting
Turns out lots of people write invalid HTML all the time and no one, including your browser or React, cares. Most invalid HTML combinations don't cause magic reparented nodes; only some do. The HTML5 parsing spec (https://html.spec.whatwg.org/multipage/syntax.html) specifies which tag combinations cause strange parsing behavior. I did my best to encode the logic here. It's more lenient than before in some cases, but more strict in others (before we didn't look at the whole stack of tags; now we warn with deeply nested `p` or `form` or `a` tags).
2015-03-25 16:43:41 -07:00
Paul O’Shannessy 27a191e704 Merge pull request #3513 from agelter/master
Added support for the 'low', 'high', and 'optimum' attributes that are missing from the <meter> tag.
2015-03-25 12:17:07 -07:00
Paul O’Shannessy 56b180b464 Fix failing test
PR #3494 was based on master before we shifted to using console.error. This
just fixes the new test case.
2015-03-25 12:15:41 -07:00