Facebook/react
1
0 Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity
575 Commits 681 Branches 148 Tags
3bb837b683fcd41f48ca522b09ad7918e7fca6f7
Commit Graph
462 Commits
Author SHA1 Message Date
Dan Abramov 3bb837b683 Implement getPathForElement to serialize the selected path 
Note this doesn't restore the selection yet.
 2019-04-24 14:37:46 +01:00
Dan Abramov b1a7007cc5 Keep track of root insertion order in the renderer 
Normally, Fibers have key or index which we'll use to match things up between reloads. However, roots don't have such a concept. We'll use their insertion order as an approximation. If it's consistent, we'll be able to restore the selection.
 2019-04-24 14:37:46 +01:00
Dan Abramov d8abecdcf9 Persist and restore selection in agent 
This implements the infrastructure for saving and restoring renderer-specific selection state in the session storage.

Note this doesn't actually implement the calculation and tracking of paths in the renderer. It only simulates that the renderer can do it. The actual implementation will come in a later commit.
 2019-04-24 14:37:46 +01:00
Brian Vaughn 7262a30cf3 Reverted optimization to avoid re-sending inspected fiber unless it committed 2019-04-23 18:04:25 -07:00
Brian Vaughn 0aa7d2f800 Reverted optimization to avoid re-sending inspected fiber unless it committed 2019-04-23 14:03:58 -07:00
Brian Vaughn 1e5c0b7856 Re-added the selection message 2019-04-23 13:43:38 -07:00
Brian Vaughn 4dcb34ea32 Fixed Flow error 2019-04-23 11:32:07 -07:00
Brian Vaughn 53c7338420 Updated flow-bin to attempt to fix the error 2019-04-23 09:00:25 -07:00
Brian Vaughn d85f566d66 Merged master (tooltip changes) 2019-04-23 08:49:40 -07:00
Brian Vaughn 8b33dd673d Added @reach/tooltip 2019-04-23 08:41:52 -07:00
Brian Vaughn 7f1531044b Differentiate between no-change and no-element-found when inspecting element 2019-04-22 15:37:55 -07:00
Brian Vaughn 00872e2e51 Fixed suspense fallback issue by moving inspection message side effect before suspending render 2019-04-22 15:25:55 -07:00
Brian Vaughn 64bb2d31f9 Fixed bug with cache invalidation 2019-04-22 15:18:32 -07:00
Brian Vaughn 64bc49d523 Run first setState with explicit priority in case of non-React event handlers 2019-04-22 15:11:04 -07:00
Brian Vaughn 433934f55e Refactored TreeContext to use less memoization (based on feedback from Sebastian) 2019-04-22 10:39:21 -07:00
Brian Vaughn d53ae2ea8a Refactored TreeContext to use less memoization (based on feedback from Sebastian) 2019-04-22 10:19:59 -07:00
Brian Vaughn 70be637d48 Don't schedule an update with React unless the curent element was invalidated 2019-04-22 09:37:55 -07:00
Brian Vaughn 5970bf4b40 Changed polling approach. Fixed remove event typo. 2019-04-22 09:37:55 -07:00
Brian Vaughn 3de18de25e Tried to implement two setState pattern, but it does not feel right 2019-04-22 09:37:55 -07:00
Brian Vaughn 957c389566 Adding polling and initial stab at not serializing duplicate inspected Element props 2019-04-22 09:37:34 -07:00
Brian Vaughn c6b19cc141 Refactored insepected element cache to use the context API 2019-04-22 09:37:34 -07:00
Brian Vaughn 09b023a6e6 Naive suspense implementation for selected element panel 
This commit leaves a few major things uunresolved:
* We aren't yet polling for updates
* We aren't yet using the two setState pattern
* The resource cache will grow unbounded over time because we aren't yet clearing items from it
* The renderer interface is not smart enough to avoid resending unchanged data between requests
 2019-04-22 09:37:34 -07:00
Brian Vaughn 76b29ad0a9 Merge pull request #201 from gaearon/scroll-fix 
Fix scrolling to selected row in collapsed mode
 2019-04-22 09:37:15 -07:00
Brian Vaughn 52652f3456 Toggle method no longer emits 'mutated' event unless it mutated the store 2019-04-21 12:20:23 -07:00
Brian Vaughn 91f74a5134 Fixed focus styles for OwnersStack dropdown toggle button 2019-04-21 08:59:24 -07:00
Brian Vaughn 09b995ab1c Tidied up CSS variables 2019-04-21 08:38:58 -07:00
Brian Vaughn 66df03d179 Renamed CSS var color-text-color to color-text 2019-04-21 08:29:51 -07:00
Brian Vaughn 8220df734c Tweaked hover and focus colors. Temporarily disabled Tooltip. 2019-04-21 08:23:20 -07:00
Brian Vaughn a129089891 Tweaking focus/active colors and only showing focus rect on tab 2019-04-20 15:44:24 -07:00
Brian Vaughn 403bf49a78 Use new @reach/tooltip 2019-04-20 14:29:03 -07:00
Brian Vaughn 740993baa9 Merge branch 'master' into push-ops 2019-04-20 14:26:46 -07:00
Brian Vaughn 72156c744f Merge pull request #204 from gaearon/no-weakset 
Replace WeakSet with return pointer check
 2019-04-20 14:23:59 -07:00
Dan Abramov 006e03c38e Ignore leading edge of find-by-DOM throttle 2019-04-20 22:17:12 +01:00
Dan Abramov c0d7023a88 Replace WeakSet with return pointer check 2019-04-20 21:42:30 +01:00
Dan Abramov 02a3a22753 Push operations directly to the array 2019-04-20 21:05:52 +01:00
Brian Vaughn 4b9082eea1 Changed style and position of search-for-element button to more closely matchin Chrome ( based on user testing) 2019-04-20 10:44:03 -07:00
Dan Abramov 4ffdffb598 Fix scrolling to selected row in collapsed mode 2019-04-20 16:20:03 +01:00
Brian Vaughn 3697ed2bba Merge pull request #199 from gaearon/another-check 
Filter out dehydrated Suspense nodes
 2019-04-20 08:00:14 -07:00
Dan Abramov d05106e364 Clear DOM overlay on shutdown 2019-04-20 14:34:13 +01:00
Dan Abramov a186dc2e8d Filter out dehydrated Suspense nodes 2019-04-20 13:57:33 +01:00
Dan 9a395c2f2c No need to reorder empty children either 2019-04-19 13:21:09 +01:00
Dan fb8ad3486e Don't reorder a single child 2019-04-19 13:19:58 +01:00
Dan efb5855c8c Nits 2019-04-19 13:17:17 +01:00
Dan 3e657a6031 Prettier 2019-04-19 13:09:25 +01:00
Dan Abramov 37dd1ec8f8 Merge branch 'master' into more-suspensey-stuff 2019-04-19 13:09:01 +01:00
Brian Vaughn f286c0d901 Increased contrast for selected+inactive background color 2019-04-18 18:19:10 -07:00
Brian Vaughn 131e2e52db Merge pull request #188 from gaearon/humble-search 
Don't select search result unless user does something
 2019-04-18 18:04:28 -07:00
Brian Vaughn 60b614f527 Renamed TREE_OPERATION_RESET_CHILDREN -> TREE_OPERATION_REORDER_CHILDREN 2019-04-18 17:59:53 -07:00
Brian Vaughn 24736e4ff5 Hardened reorder child invariants 2019-04-18 17:58:48 -07:00
Dan Abramov 3d09b4aaa5 Don't select search result unless user does something 2019-04-19 01:54:39 +01:00