Dan Abramov
3863330524
Add ReactInstrumentation
...
This adds `ReactInstrumentation` for the isomorphic package that uses the same approach as `ReactDOMInstrumentation`. Currently it is gated behind `__DEV__` but we will likely change this later to a runtime flag determined by whether there are any active listeners.
The first few events we add here should be sufficient for React DevTools, as determined by the `hook.emit()` calls in https://github.com/facebook/react-devtools/blob/d90c43201617d5aef378669da926d79515b6a811/backend/attachRenderer.js .
These events will also be useful for reconstructing the parent tree in the ReactPerf rewrite in #6046 .
2016-02-18 22:52:22 +00:00
Ben Alpert
684ef3e320
Merge pull request #5753 from mwiencek/no-text-span-2
...
Don't wrap text in <span> elements
2016-02-18 12:02:17 -08:00
Michael Wiencek
203850013a
Don't wrap text in <span> elements
...
Instead, use opening and closing comment nodes to delimit text data.
2016-02-18 13:49:14 -06:00
Jim
5d7cd93b0e
Merge pull request #6064 from jimfb/provide-msunsafe-wrapper
...
Create ms-unsafe functions in one place, simplifies code.
2016-02-18 11:14:47 -08:00
Benjy Cui
c54249c868
Update comments for EventPluginHub.js
2016-02-18 16:23:00 +08:00
Jim
e8e56e8723
Merge pull request #5940 from kentcdodds/pr/warn-event-pool-access
...
Add warning when reading from event which has been returned to the pool
2016-02-17 21:51:40 -08:00
Kent C. Dodds
6312852688
warn(SyntheticEvent): Warn when accessing or setting properties on released syntheticEvents
...
Closes #5939
2016-02-17 22:46:12 -07:00
jim
51d16473b0
Create ms-unsafe functions in one place, simplifies code.
2016-02-17 21:10:20 -08:00
Andreww8xx8
8d08f3f00a
Wrap insertBefore in Windows 8 apps
2016-02-18 06:12:29 +03:00
Ben Alpert
3a4e1dbb5b
Fix merge conflict in #4940
2016-02-17 17:20:37 -08:00
Ben Alpert
acb49363d5
Remove "construct" call except on composites
...
This is a little simpler (and a teeny tiny bit faster). The one in ReactCompositeComponent stays because of the way we create ReactCompositeComponentWrapper inside instantiateReactComponent.
2016-02-17 15:48:24 -08:00
Jim
c9e0fc766f
Merge pull request #5720 from edmellum/master
...
Fix #4963 - SVG <use> swallows click events
2016-02-17 07:01:50 -08:00
David Ed Mellum
2fdaba49c7
Fix #4963 - SVG <use> swallows click events
2016-02-17 15:25:45 +01:00
cpojer
383e2f938d
Update to jest-cli 0.9.
2016-02-17 13:01:14 +09:00
Jim
3bee2d962a
Merge pull request #5744 from prometheansacrifice/warn-if-user-accesses-key-ref-props
...
Warns on access of `props.key` and `props.ref`
2016-02-16 10:11:28 -08:00
Manas
c3980a6d08
Warns on access of props.key and props.ref
2016-02-16 22:04:32 +05:30
Jim
2410dc7f15
Merge pull request #6028 from sambev/issue/6027-uncaught-type-error
...
Fix for issue/6027.
2016-02-13 13:19:11 -08:00
Sam Beveridge
57d59ea344
Remove check for _wrapperState.pendingUpdate.
...
We can just set it to true regardless.
2016-02-13 12:01:49 -07:00
Saiichi Hashimoto
0b87d7f56f
Update HTMLDOMPropertyConfig.js
2016-02-13 00:42:47 -08:00
Jim
d684b1598d
Merge pull request #5864 from TheBlasfem/master
...
Warn when an input switches between controlled and uncontrolled
2016-02-12 16:34:55 -08:00
Sam Beveridge
385cadf8e3
Forgot to 'not' the pendingUpdate condition.
2016-02-12 14:32:47 -07:00
Sam Beveridge
c4a2425eca
Fix for issue/6027.
...
ReactDOMSelect's _handleChange function tries to set
this._wrapperState.pendingUpdate = true after executing the onChange
function. However, if the select was removed as a result of said
fuction, this._wrapperState would be null. Resulting in an
Uncaught TypeError: Cannot set property 'pendingUpdate' of null.
2016-02-12 14:00:15 -07:00
Jim
bbd5a78efa
Merge pull request #6009 from jimfb/error-boundaries-initial-render-componentWillUnmount
...
Errors in componentWillUnmount should be caught by error boundary on initial render.
2016-02-11 18:11:35 -08:00
jim
dd390b3e36
Errors in componentWillUnmount should be caught by error boundary on initial render.
2016-02-11 17:44:35 -08:00
jim
428ef03bbb
Enable module pattern.
2016-02-11 12:59:25 -08:00
Ben Alpert
3e41da767f
Merge pull request #5892 from ianobermiller/children-map-key-slash
...
ReactChildren.map: only add slash if new child has key
2016-02-10 16:53:59 -08:00
Paul O’Shannessy
6fe495a5ab
Remove React.addons.batchedUpdates
2016-02-10 11:20:50 -08:00
Paul O’Shannessy
4a1b0b7dfa
Merge pull request #5977 from jfairbank/remove-new-call
...
Remove instance of invoking ReactElement with new operator
2016-02-08 14:14:50 -08:00
Paul O’Shannessy
a1dab9edbf
Fix lint
...
- Upgrade babel-eslint
- Ignore coverage
- Fix actual lint warning
2016-02-05 10:56:51 -08:00
jim
86305fba41
Error boundries should not unmount composite components which were not mounted.
2016-02-04 17:10:18 -08:00
Julio Lopez
b38b39a696
warn when an input switches between controlled and uncontrolled
...
added controlled key to DEV
warn for checkbox inputs
warn for radio inputs
compute controlled instead of value
displaying owner name in warning
displaying input type in warnings
2016-02-04 09:31:41 -05:00
Jeremy Fairbank
dbb54b1990
Remove instance of invoking ReactElement with new operator
2016-02-03 21:03:32 -05:00
karczk
ef2b1f26ef
Unnecessary type comparisons have been changed to value comparison
2016-02-02 19:35:58 +01:00
krystian.karczewski
8c7d743361
Fix for #5957 : Bug on resolving default props (HTMLAllCollection)
2016-02-02 11:51:31 +01:00
Dave
1beae0c4ff
test: get rid of 'should be 1' comment
...
This should not be 1, since boolean properties always get set.
2016-02-01 12:53:25 -08:00
Jim
188e8cde2f
Merge pull request #5884 from jimfb/component-extends-react-component
...
Enable null return values in plain functions
2016-01-29 15:05:08 -08:00
Jim
9d5825cf4b
Merge pull request #3372 from jonhester/void-elements
...
ReactDOMComponent should throw error when provided children for void elements
2016-01-29 13:27:35 -08:00
Jim
67e1291ef7
Merge pull request #1510 from syranide/propattr
...
Use removeAttribute to forcefully remove properties from the DOM
2016-01-29 12:48:25 -08:00
Paul O’Shannessy
b41f5a1cdf
v0.15.0-alpha.1
2016-01-20 20:07:37 -08:00
Ian Obermiller
30f7641873
ReactChildren.map: only add slash if new child has key
...
See the new test for the scenario I am trying to fix; if you clone an
element in React.cloneElement, vs just returning it directly, you will
get a different key (with a slash in front) even though the two
children are identical.
2016-01-20 19:20:22 -08:00
jim
757756f682
Enable null return values in plain functions
2016-01-20 14:11:41 -08:00
Ben Alpert
e420edda36
Merge pull request #5886 from goatslacker/cant-dangerouslysetinnerhtml-for-option
...
Only add children in ReactDOMOption when there are children
2016-01-19 15:12:09 -08:00
Josh Perez
3da6e2889b
Only add children when there are children
2016-01-19 14:48:47 -08:00
Paul O’Shannessy
31d3bfa763
Merge pull request #5811 from jontewks/warn-nan-style
...
Warn when a style object has NaN for a value
2016-01-18 17:06:19 -08:00
Jon Tewksbury
7a6000c093
Add warning for NaN in style object
2016-01-16 11:10:50 -08:00
Jim
2f792d5a60
Merge pull request #5859 from jimfb/clonewithprops
...
Removed cloneWithProps addon.
2016-01-15 17:25:24 -08:00
jim
accd0d874d
Removed cloneWithProps addon.
2016-01-15 17:17:36 -08:00
Paul O’Shannessy
422b4e105c
Merge pull request #5840 from koba04/release-event-target-on-destructor
...
Release syntheticEvent.target on the destructor
2016-01-15 16:38:42 -08:00
Toru Kobayashi
be0551d01e
Release syntheticEvent.target on the destructor
2016-01-14 15:09:56 +09:00
Jim
fcc63e1fff
Merge pull request #5832 from jimfb/cleanup-top-level-dom-api
...
Remove DOM functions from top-level isomorphic API
2016-01-13 15:41:03 -08:00