Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity
7,268 Commits 681 Branches 148 Tags
364d4a4ea116862800cccdaa59cd2917a0840bf6
Commit Graph
30 Commits
Author SHA1 Message Date
najisawasandAndrew Clark 7a11c572e6 Fixed typo on implementation notes page (#9258) 
Added paren to "mountComponent()" for consistency
 2017-04-07 14:06:58 -07:00
Giorgio PolvaraandAndrew Clark 9b4d42ca64 Fix typo (#7953) 2017-04-07 14:06:36 -07:00
JustinandAndrew Clark b9f9b3cce6 Fix grammar typo in Design Principles docs (#9324) 
features → feature
> There is nothing "bad" about using state or lifecycle hooks in components. Like any powerful feature**s**, they should be used in moderation, but we have no intention to remove them.

I can’t explain the exact grammatical principle this violates, but it sounds wrong to my native English ears that “feature” is plural here. Another way to check if the grammar sounds right is to change the order of the clauses: ”They should be used in moderation, like any powerful feature“ sounds right, whereas “They should be used in moderation, like any powerful features” does not.
 2017-04-07 14:03:46 -07:00
Dan AbramovandAndrew Clark c549c8b66e Update build paths in docs (#9340) 2017-04-07 14:03:09 -07:00
Andrew ClarkandBrandon Dail c5395d23e5 Merge pull request #9187 from acdlite/prettierci 
Failing to run prettier should block CI
(cherry picked from commit 9549ebfae5)
 2017-03-24 09:48:44 -05:00
Prayag VermaandDan Abramov 34b6e1f80c Fix a typo in design principles doc (#8985) 
unambigious → unambiguous
(cherry picked from commit c60f852cdb)
 2017-02-13 23:30:52 +00:00
Ragnar Þór ValgeirssonandDan Abramov d8700e8d4e Match eslint's line length settings (#8845) 
(cherry picked from commit 09b3ec5d3c)
 2017-01-23 17:19:23 +00:00
Jack CrossandBrandon Dail 5446c47c1d Add Flow reminder to PR template (#8805) 
* Added flow to PR template

* Added record-tests step to PR template and contribution docs

* Updated order of PR checks

(cherry picked from commit bfd5b1878e)
 2017-01-18 12:44:25 -06:00
Richie ThomasandBrandon Dail 9b0301345b Remove one extraneous backtick from line 116 of 'codebase-overview.md' (#8724). (#8726) 
(cherry picked from commit b2cc91e83a)
 2017-01-09 14:58:40 -06:00
Joel SequeiraandDan Abramov a824fbfd08 Fix typo in Proposing a Change section in how-to-contribute.md (#8498) 
* Fix typo in Proposing a Change section in how-to-contribute.md

Not sure if it was actually intended or was a typo but changed 'If you intend to change to the public API' --> 'If you intend to make a change to the public API'

* Simplify
 2017-01-04 17:30:16 +00:00
Brian VaughnandDan Abramov 4bfa07a929 Merge pull request #8671 from bonham000/update-docs 
update to codebase-overview.md
 2017-01-04 16:13:22 +00:00
Shuhei Kagawaandtomocchino 04f1fe7fbf Correct a method param in Implementation Notes (#8252) 
(cherry picked from commit fa4710fe51)
 2016-11-16 15:22:39 +00:00
Guilherme Oenningandtomocchino e5e387da9e fix broken docs links (#8163) 
* fix broken links to outdated code

* another broken links to outdated code

* update hash commit & folder structure to current

(cherry picked from commit b847226ec4)
 2016-11-16 15:22:38 +00:00
Lee SanghyeonandDan Abramov d128b45c6f Update codebase-overview.md (#8142) 
* Update codebase-overview.md

Fix the broken source code URL in 'Event System' section.

* Update codebase-overview.md

Re-fix link name
 2016-11-08 19:20:59 +00:00
Piper ChesterandDan Abramov 89defaa712 Fix grammatical error 2016-10-22 22:05:15 +01:00
Phil QuinnandDan Abramov 24dd09fea7 correct order of params in documentation (#7989) 2016-10-22 22:04:36 +01:00
CT WuandDan Abramov 1d108d8f6a Fix a typo in the doc (#7969) 2016-10-22 22:04:13 +01:00
Dan Abramov 60ec3c6b37 Fix redirects 2016-10-21 22:01:06 +01:00
Kevin LackerandDan Abramov 1cf81c1aa9 New Documentation 2016-10-21 21:00:10 +01:00
Alex BabkovandDan Abramov cd65b60960 Typo fixes in codebase-overview.md (#7938) 2016-10-11 12:09:33 +01:00
Aesop WolfandDan Abramov b52288cbcf Update codebase-overview.md (#7934) 
Fix typo
 2016-10-11 12:09:20 +01:00
Dan Abramov 2b5c43029e Add Implementation Notes and amend Codebase Overview (#7830) 
* Add more to Codebase Overview

* WIP

* Start a reconciler overview

* Add a few more sections

* todo

* WIP

* Finish it

* Whitespace

* Minor tweaks

* Minor tweaks
 2016-10-10 17:30:18 +01:00
Steve MaoandDan Abramov ffa70704ca simplify npm link script a little bit (#7862) 
We don't need to remove the folders before linking the modules
 2016-10-04 12:20:49 +01:00
Ivan ZotovandPaul O’Shannessy ecd66274a7 Fix mistakes in the codebase overview (#7834) 
(cherry picked from commit 16ac141f44)
 2016-10-03 15:54:26 -07:00
Dan Abramov 58d66ad47f Add Codebase Overview (#7828) 
* Add Codebase Overview

* Update codebase-overview.md

* Update codebase-overview.md
 2016-09-29 11:34:35 +01:00
Dan Abramov ae5ebe3d92 Move How to Contribute to documentation and update it (#7817) 
* Move How to Contribute to documentation and update it

* Consistent formatting
 2016-09-27 23:22:32 +01:00
Paul O’Shannessy dfebed11c2 Merge pull request #7308 from zpao/jekyll3 
Upgrade to Jekyll 3
(cherry picked from commit 5e3959e071)
 2016-07-19 16:36:23 -07:00
Dan Abramov 108f25350d Clarify the section about dogfooding (#7292) 2016-07-16 15:03:00 +01:00
Dan Abramov f40b5b5c47 Minor tweaks to Design Principles (#7283) 2016-07-14 21:30:13 +01:00
Dan Abramov b38bbde2fe Add Design Principles to the docs (#7282) 2016-07-14 20:39:41 +01:00