Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity
5,233 Commits 681 Branches 148 Tags
35b7fe175d673c8dcafe8f4c21fa811cc32acac8
Commit Graph
5233 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Sebastian Markbage 02aafb5162 Make setState in render a warning, not an invariant 
We keep track of the fact that something is rendering for a bunch of
warnings. (ReactCurrentOwner.current !== null)

Once we get rid of owner for string refs, I'll convert those to something
like "isRendering" instead. The interesting part is that feature `__DEV__`
only. It is only used for warnings. Except for this case.

This means that we can get rid of the special case for the isRendering
stack on in prod.
 2015-06-10 18:33:59 -07:00
Sebastian Markbåge 8b24b3d8b0 Merge pull request #4090 from sebmarkbage/fixdomcomponentest 
Use the public render API in ReactDOMComponent-test
 2015-06-10 17:57:33 -07:00
Sebastian Markbage 3cdf718504 Use the public render API in ReactDOMComponent-test 
Avoids testing a non-public API. First step towards refactoring more of
these internals to not be instances. Also gets rid of an _owner usage.
 2015-06-10 17:34:56 -07:00
Paul O’Shannessy f55b93672f Merge pull request #4088 from zpao/fix-class-test 
Fix Class tests
 2015-06-10 17:19:40 -07:00
Paul O’Shannessy d580a71293 Fix Class tests 
These were introduced in #4045 as a result of jest not running properly in CI.

I also fixed the places where we misspelled "misspelling".
 2015-06-10 17:06:04 -07:00
Ben Alpert 6c96f9f273 Merge pull request #4086 from spicyj/ta 
Remove stray call to ReactDOMTextarea.unmountWrapper
 2015-06-10 15:49:04 -07:00
Ben Alpert f073ce2ba7 Remove stray call to ReactDOMTextarea.unmountWrapper 
ReactDOMInput has this but ReactDOMTextarea doesn't so we shouldn't try to call it.
 2015-06-10 15:31:27 -07:00
Jim 88042b1b00 Merge pull request #4074 from jimfb/docs-context-parameter-confusing 
Fixed confusing use of the word/name `context` in documentation
 2015-06-10 13:32:03 -07:00
Ben Alpert 4f73ce2c95 Merge pull request #4077 from neojski/svg-namespace 
Add xmlns to svg wrap
 2015-06-10 12:19:45 -07:00
Jim 537a84183a Merge pull request #3752 from jhicken/Custom-Element-Support 
Ignore whitelisted attributes for native custom elements.
 2015-06-10 10:58:54 -07:00
Ben Alpert 46cec1949d Merge pull request #4071 from spicyj/warn-dom-props 
Fix IE8
 2015-06-10 10:16:57 -07:00
Jeff Hicken 7256f0976c Ignore whitelisted attributes for native custom elements that use the is attribute. 2015-06-10 10:00:21 -06:00
Tomasz Kołodziejski c9fab582c4 Add xmlns to svg wrap 
Closes #4072.
 2015-06-10 15:57:05 +02:00
Jim 5446ef1c14 Fixed confusing use of the word/name in documentation 2015-06-10 02:48:48 -07:00
Ben Alpert 13a8758fc8 Fix IE8 2015-06-09 18:45:29 -07:00
Ben Alpert 0abb350530 Merge pull request #4070 from tako-black/fix_md_file 
Fix code of getting-started-ja-JP
 2015-06-09 17:01:14 -07:00
Kohei TAKATA 005b65c17b Fix code of getting-started-ja-JP 2015-06-10 08:52:47 +09:00
yiminghe e704503dc7 optimize className check 2015-06-10 01:11:39 +08:00
Scott Feeney 61d8de3f3f Merge pull request #4003 from AnSavvides/on-change-vs-on-input 
[#3964] Add note about React's onChange vs. DOM's oninput
 2015-06-09 11:13:28 -04:00
Paul O’Shannessy 04a025f3b7 Merge pull request #4046 from basarat/patch-2 
📝 document changes for classes
 2015-06-08 21:46:39 -07:00
Paul O’Shannessy 3faad4f65f Merge pull request #4063 from zpao/fix-ja-docs 
fix japanese docs permalinks
 2015-06-08 20:16:49 -07:00
Basarat Ali Syed b7fe1ac0fc 📝 link to docs and not the blog post 2015-06-09 11:33:33 +10:00
Paul O’Shannessy 8488cb4dac fix japanese docs permalinks 2015-06-08 18:18:57 -07:00
Paul O’Shannessy 2b53acb00a Merge pull request #4045 from davemeetsworld/add-warning-for-mispelling-of-componentWillReceiveProps 
Added warning for mispelling of componentWillReceiveProps and updated…
 2015-06-08 15:12:40 -07:00
David Baker 2d8c4be000 Added warning for mispelling of componentWillReceiveProps and updated tests 2015-06-08 22:44:30 +01:00
Paul O’Shannessy 5955379753 Merge pull request #4060 from cody/addons 
Fix addon name in npm Readme
 2015-06-08 14:00:20 -07:00
Paul O’Shannessy a74138bdee Fix docblock of ReactFragment 2015-06-08 13:49:29 -07:00
Stefan Dombrowski c9ab11f5ff Fix addon name in npm Readme 2015-06-08 22:39:12 +02:00
Ben Alpert 6b8ed9b64e Merge pull request #3884 from glenjamin/patch-3 
Document boolean attributes in JSX
 2015-06-08 13:28:39 -07:00
Paul O’Shannessy 7f7528c454 Merge pull request #4059 from jquense/patch-3 
fix my embarrassing amount of typos in this 4 line change
 2015-06-08 13:01:15 -07:00
Benjamin Woodruff f27d130323 Merge pull request #4040 from PiPeep/eslint-updates 
Update eslint-related dependencies
 2015-06-08 13:00:13 -07:00
Jason Quense 813649cbc7 fix my embarrassing amount of typos in this 4 line change 2015-06-08 15:59:30 -04:00
Paul O’Shannessy 09993a1379 Merge pull request #4054 from jquense/patch-2 
Update npm Readme to new method of accessing addons
 2015-06-08 12:53:28 -07:00
Ben Alpert 8614dd3cf9 Merge pull request #3984 from neojski/uppercase-node-name 
Always toLowerCase when comparing nodeName or tagName
 2015-06-08 11:44:56 -07:00
Ben Alpert 0e3ae67418 Merge pull request #4043 from spicyj/80 
Remove line length lint warning
 2015-06-08 10:40:42 -07:00
Ben Alpert 39f232b9aa Merge pull request #4042 from spicyj/warn-dom-props 
Warn when accessing .props, .setProps on DOM components
 2015-06-08 10:40:26 -07:00
Ben Alpert bfcad9614a Warn when accessing .props, .setProps on DOM components 2015-06-08 10:36:20 -07:00
Benjamin Woodruff 52eca1eb69 Update eslint-related dependencies 
- babel-eslint ^3.1.14 fixes babel/babel-eslint#120
- babel updated from ^5.3.3 to ^3.5.5, which changes stuff, I guess
- eslint updated from ^0.21.2 to ^0.22.1, which makes `no-shadow` also
  check class declarations
 2015-06-08 08:41:13 -07:00
Jason Quense 7fa8c79d40 Update docs to new method of accessing addons 2015-06-07 19:07:36 -04:00
Andreas Savvides ae83e90ec7 [#3964] Add note about React's onChange vs. DOM's oninput 2015-06-07 10:39:08 +01:00
Tomasz Kołodziejski 2bb69328ae Always toLowerCase when comparing nodeName or tagName 
In xml node name casing is exactly the same as the node was originally named.
Make sure to convert node and tag names to lower case before making any node
and tag name checks.

Fixes #3960.
 2015-06-06 10:28:43 +02:00
Basarat Ali Syed b994d076d1 📝 document changes for classes 
Taking https://github.com/facebook/react/pull/4013#discussion_r31829922 into account
 2015-06-06 10:23:41 +10:00
Ben Alpert ba81b60ad8 Merge pull request #4037 from spicyj/ref-trans 
Only enqueue attachRefs if refs are present
 2015-06-05 12:42:09 -07:00
Ben Alpert edee1c7ed7 Merge pull request #4035 from spicyj/dc-os 
Convert select/option to not use wrappers
 2015-06-05 12:41:34 -07:00
Benjamin Woodruff 0dab63b905 Merge pull request #4034 from PiPeep/eslint-rules-as-a-plugin 
Load custom eslint rules as plugin, w/o --rulesdir
 2015-06-05 10:43:02 -07:00
Ben Alpert c6837507f9 Only enqueue attachRefs if refs are present 
for #4036
 2015-06-04 22:57:46 -07:00
Ben Alpert 06de43d73e Remove line length lint warning 
...because the current situation isn't helpful; no one looks at the list. Our style guide hasn't changed.
 2015-06-04 18:14:31 -07:00
Ben Alpert abfd151b90 Convert select/option to not use wrappers 2015-06-04 18:13:54 -07:00
Ben Alpert 806ff23f03 Merge pull request #4033 from spicyj/dc-events 
Convert form, iframe, img to not use wrappers
 2015-06-04 17:23:48 -07:00
Benjamin Woodruff 30cce21ae6 Load custom eslint rules as plugin, w/o --rulesdir 
This allows us to load the eslint rules without requiring command-line
arguments, which avoids breaking editors with eslint plugins.

https://github.com/eslint/eslint/issues/2180#issuecomment-87722150
 2015-06-04 17:04:45 -07:00