conorhastings
20ec78d9f0
update enqueueCallback invariant to more specifically explain what caused error
2015-10-16 11:57:08 -04:00
Paul O’Shannessy
ed7ab7b94a
Merge pull request #5176 from jimfb/tweak-props-change-wording
...
Tweak wording when talking about props changing
2015-10-15 12:21:14 -07:00
Paul O’Shannessy
e12ee95e09
[docs] Don't make authors links on all posts page
2015-10-15 12:18:15 -07:00
Paul O’Shannessy
ccfc2d8049
Merge pull request #5178 from jimfb/multiple-authors
...
Fix blog post authors
2015-10-15 12:04:56 -07:00
Paul O’Shannessy
95afe4608f
Merge pull request #5184 from zpao/fix-style-issues
...
Fix indentation issues
2015-10-15 11:55:37 -07:00
Paul O’Shannessy
0dc6596dc2
Fix indentation issues
2015-10-15 09:29:28 -07:00
Jim
b735dd4ab4
Merge pull request #5048 from antoaravinth/PR-5013
...
Issue: 5013 Added necessary code for firing warning if value is null
2015-10-14 23:06:54 -07:00
Ants
b42c1dafcc
Issue: 5013 Added necessary code for firing warning if value is null
...
Fixed the lint issues
Added logic for handling the warning only once and added the test cases for the same. Also moved the warning part to only DEV mode
Changed few lines related to the formatting issues
Removing the empty whitespace
2015-10-15 10:13:35 +05:30
Jim
5ae4f035c7
Fix blog post authors
2015-10-14 18:01:33 -07:00
Ben Alpert
8168c8eac6
Merge pull request #5175 from spicyj/text-no-frag
...
Don't test frag cases in ReactMultiChildText-test
2015-10-14 16:07:11 -07:00
Jim
c47d2cfada
Tweak wording when talking about props changing
2015-10-14 14:43:09 -07:00
Paul O’Shannessy
8e9682c542
Merge pull request #5174 from zpao/dom-attributes-track
...
Add srcLang and kind to better support track elements
2015-10-14 14:35:03 -07:00
Ben Alpert
5f8fe7d614
Don't test frag cases in ReactMultiChildText-test
...
These are now just testing the same as the array cases directly above. This should make this test a bunch faster because it (intentionally) has n^2 runtime.
2015-10-14 14:31:45 -07:00
Ben Alpert
8e67b7f624
Merge pull request #4988 from spicyj/fdn
...
Walk down internal tree to find DOM node
2015-10-14 14:31:28 -07:00
Ben Alpert
5c5d2ec182
Walk down internal tree to find DOM node
...
This reduces our reliance on hierarchical IDs.
2015-10-14 14:22:53 -07:00
Paul O’Shannessy
659172df50
Add srcLang and kind to better support track elements
2015-10-14 12:05:56 -07:00
Jim
555fd46c7e
Merge pull request #5140 from pluma/patch-1
...
Fix #1357 . Don't append "px" suffix to CSS string values.
2015-10-14 11:18:53 -07:00
Alan Plum
a299a366ce
Fix #1357 . Warn when appending "px" to strings.
2015-10-14 18:36:24 +02:00
Sebastian Markbåge
da1135618e
Merge pull request #5166 from spicyj/gh-5157
...
Add feature test for document.createEvent
2015-10-14 00:08:56 -07:00
Ben Alpert
4f9fdeeec1
Merge pull request #5165 from spicyj/cache-lenient
...
Be more lenient with invalid nodes in the cache
2015-10-13 17:22:12 -07:00
Ben Alpert
1206d8d2eb
Add feature test for document.createEvent
...
See #5157 .
2015-10-13 16:34:05 -07:00
Ben Alpert
e89e675508
Be more lenient with invalid nodes in the cache
...
This matches our old behavior. I was a little too aggressive in turning on this
error and it's still possible to trigger it (using the test added here).
2015-10-13 16:07:06 -07:00
Paul O’Shannessy
af99b2c2a3
Merge pull request #5164 from zpao/fix-csstransitiongroup-proptype
...
Correctly handle 0 in CSSTransitionGroup timeout props
2015-10-13 14:54:21 -07:00
Paul O’Shannessy
dc21b95244
Correctly handle 0 in CSSTransitionGroup timeout props
2015-10-13 14:39:55 -07:00
Ben Alpert
dddbca472a
Merge pull request #5160 from spicyj/gh-5151
...
Fetch node to unmount separately from unmounting
2015-10-13 12:19:24 -07:00
Ben Alpert
622db4ee4f
Fetch node to unmount separately from unmounting
...
My last strategy of getting each node recursively while unmounting was a pain to make work properly with ReactMount's confusing cache. Now, we get the node before unmounting anything in the subtree (and we don't try to find the nodes of descendants).
This is a temporary solution and can go away when we get rid of the giant ReactMount node hash map.
Fixes #5151 .
2015-10-13 12:07:57 -07:00
Ben Alpert
194ab16d7b
Merge pull request #5157 from spicyj/createevent
...
Use 'document.createEvent' not 'new Event'
2015-10-13 11:40:35 -07:00
Paul O’Shannessy
51c0f86ec7
Merge pull request #5147 from zpao/update-release-task
...
Stop generating gh-pages during release, update message
2015-10-13 11:20:40 -07:00
Ben Alpert
6488a4c187
Use 'document.createEvent' not 'new Event'
...
Fixes #5153 .
This seems to work in all browsers I tested, including old Android and all IE > 8 which didn't work before.
2015-10-13 11:14:23 -07:00
Ben Alpert
50c9b94552
Merge pull request #5156 from spicyj/bp-codemods
...
Mention codemods more prominently in release blog
2015-10-13 10:50:38 -07:00
Ben Alpert
4a37796f88
Mention codemods more prominently in release blog
2015-10-13 10:37:42 -07:00
Paul O’Shannessy
f7a3ac2d56
Stop generating gh-pages during release, update message
2015-10-13 09:37:32 -07:00
Jim
bffed177f4
Merge pull request #5150 from jimfb/node-v4-readme
...
Updated node version requirement in README.md
2015-10-12 18:07:29 -07:00
Jim
e46e5784ce
Updated node version requirement in README.md
2015-10-12 18:06:06 -07:00
Jim
c1c9b383a0
Merge pull request #5137 from vipulnsward/2576-add-comparison-tests
...
Added tests to compare testing of components using different types of element creation
2015-10-12 14:08:08 -07:00
Vipul A M
b4a6bc89c2
- Added tests to compare testing of components using different types of element creation
...
Fixes [#2576 ]
- Fixed Lint warnings and errors
2015-10-12 16:44:00 -04:00
Ben Alpert
b32835ea61
Merge pull request #5146 from spicyj/ce-scripts
...
Don't execute <script> tags w/ createElement mode
2015-10-12 13:43:51 -07:00
Ben Alpert
db989bf686
Don't execute <script> tags w/ createElement mode
...
Each script will execute at most once so we could also set `.textContent` to something like `;`, then add it to the document, then change the `.textContent`, but this seems like the simplest approach. See http://dev.w3.org/html5/spec-preview/the-script-element.html for details.
2015-10-12 13:43:40 -07:00
Jim
37c71a6e1f
Merge pull request #5142 from MaxPRafferty/add-selection-and-composition-events-on-reference-page
...
Add selection and composition events on reference page
2015-10-12 13:37:56 -07:00
maxprafferty
48ada00bdb
added selection and composition events to reference page
...
added composition events to reference page
added selection events to reference page
2015-10-12 15:44:44 -04:00
Paul O’Shannessy
abaf0051de
Merge pull request #5124 from bhamodi/master
...
Documentation Cleanup Round 1.
2015-10-12 12:34:54 -07:00
Baraa Hamodi
45d4296ac5
Documentation cleanup.
2015-10-12 15:33:32 -04:00
Paul O’Shannessy
875e2b36cc
Merge pull request #5144 from zpao/grunt-gulp-windows
...
Use the right gulp executable on Windows
2015-10-12 12:28:21 -07:00
Ben Alpert
b03b195759
Merge pull request #5130 from matiassingers/jasmine-spy-call-args-consistency
...
Jasmine spies call args property consistency
2015-10-12 10:24:56 -07:00
Paul O’Shannessy
227ba42f81
Use the right gulp executable on Windows
2015-10-12 10:01:23 -07:00
Jim
e45e46a567
Merge pull request #5141 from pluma/patch-2
...
Removed ESLint warning
2015-10-12 09:59:17 -07:00
Alan Plum
0e451162bc
Removed eslint warning.
2015-10-12 17:42:38 +02:00
Matias Singers
f8f2be05ce
Consistently use calls[n].args[n] instead of argsForCall[n][n] for Jasmine spies
2015-10-12 22:39:19 +08:00
Ben Alpert
01817c143c
Merge pull request #5129 from matiassingers/jasmine-spy-calls-length-consistency
...
Jasmine spies call count property consistency, take II
2015-10-11 15:03:27 -07:00
Matias Singers
dd0b1a643b
Consistently use calls.length instead of callCount for Jasmine spies, take II
...
See #3105 for take I
2015-10-11 15:42:24 +08:00