1b5f043e01
Fix for 'Attempting to use a disconnected port object'
...
Fixes https://github.com/bvaughn/react-devtools-experimental/issues/217
The error reproduces with any two React websites, e.g. `https://reactjs.org ` and `https://nextjs.org `, by keeping the DevTools Components tab open and switching between these websites in the same browser tab.
There are several issues with the code that contribute to this:
1. `Bridge` leaves behind a dangling timer that fires `_flush` after the bridge has been abandoned ("shutdown").
2. `bridge.send('shutdown')` is asynchronous, so the event handlers do not get unsubscribed in time.
3. `port.onDisconnect` does not trigger on in-tab navigation like new URL or back/forward navigation.
4. State management design of the code that uses shared variables and callbacks makes it hard to handle race conditions originating from the browser.
This commit cleans up some of the lacking symmetry when using `addListener`/`removeListener`, but the code in `shells/browser/shared/src/main.js` is hard to reason about with regards to race conditions, and there are many possible race conditions originating from the browser, so maybe there could be a better design paradigm (like a formal state machine) to manage the state changes in response to sequences of events than plain old event listeners, callbacks, and shared variables.
Unrelated, but clicking Chrome Back/Forward/Back/Forward very fast makes the browser and the DevTools and the DevTools of DevTools stall and become unresponsive for some time, then recovers but the Back/Forward/Stop/Refresh button and favicon loading indicator may remain broken. Looks like a Chrome bug, some kind of a temporary deadlock in handling the browser history.
2019-04-28 04:45:57 -07:00
c0b414d581
Node scripts should fail if not NODE_ENV specified
2019-04-18 18:13:34 -07:00
7930bad8c6
Deploy production extension builds
2019-04-18 14:45:24 -07:00
947e3c2c04
Add production mode to dev shell
2019-04-15 15:39:25 +01:00
5d6a2082cc
Updated React test utils for newer version of act()
2019-04-12 08:55:29 -07:00
9a0cf68a4d
Add Git revision to build version
2019-04-11 18:44:44 -07:00
9642d26674
Added ErrorBoundary with GitHub bug link
2019-04-11 17:19:16 -07:00
84478a41ff
Put DevTools in dev shell above the inspector
2019-04-10 14:26:33 +01:00
80d9d8d841
Fix profiler and nits
2019-04-05 23:34:27 +01:00
d6257d382d
Expand the test fixture
2019-04-05 21:49:37 +01:00
9bcd5b2576
Fix Suspense fragment edge cases
2019-04-05 21:49:37 +01:00
9170e5695a
Fix double-adding fibers when traversing
2019-04-05 18:18:39 +01:00
8d435595cd
Added truncation UI indicator for hooks. Addressed lint rule violations.
2019-04-04 14:09:10 -07:00
8478a526e6
Don't crash for deeply nested Hooks
2019-04-04 19:28:42 +01:00
ed6e34da8e
Added option to disable screenshot capturing while profiling
2019-04-03 14:32:16 -07:00
f92d2bbf83
Fixed editing props for memo and forwardRef components
2019-04-03 09:29:33 -07:00
ea5f310fe1
Webpack config injects a __DEV_ constant
2019-03-26 13:22:55 -07:00
afba752034
Clicking commits and interactions link to each other
2019-03-24 09:46:54 -07:00
5602fc5371
Added interaction tracing test harness to shell
2019-03-24 09:21:37 -07:00
17a966651c
Added suspense to TODO list and added interactions to 'Commit Info' panel
2019-03-20 09:39:14 -07:00
3118dae375
fix import file name
2019-03-09 07:03:42 +05:30
bffa72c601
Add placeholders to clarify between empty string, null, and undefined
2019-02-28 10:46:17 -08:00
bc4e8950f6
Updated test code to include a deeply nested DIV
2019-02-27 13:05:43 -08:00
89df0a6363
Yarn upgrade
2019-02-24 18:32:29 -08:00
9b96b1f809
Updated deploy scripts and pre-release template
2019-02-23 08:59:21 -08:00
290e8c6926
Fixed null input value. Tweaked useReducer test harness.
2019-02-21 13:40:23 -08:00
6f118497e8
Updated editable hooks UI and added limited undo feature
2019-02-21 13:24:01 -08:00
df4a09d9b8
Updated flow-bin from 91 -> 93 and removed unnecessary fixmes
2019-02-21 09:15:47 -08:00
bec073365d
Fix hooks warnings identified by prerelease version of react-hooks ESLint plugin
2019-02-19 13:15:57 -08:00
a4212dcdce
Support editable props, state, and context values
2019-02-17 13:07:39 -08:00
2fbacbff01
Tab bar resizes properly for narrow screens
2019-02-15 11:42:55 -08:00
0008bb00d7
Inspectable complex hook values
2019-02-14 21:55:09 -08:00
15c5396169
Re-added "Settings" panel to browser extension and (hopefully) fixed a lot of sources of error
2019-02-14 11:45:11 -08:00
79f57532b9
Split demo app into multiple roots and fixed a multi-root bug
2019-02-13 11:22:22 -08:00
aed1713154
Added NOW config file for dev shell
2019-02-12 21:09:50 -05:00
d203ebf165
Added new tabs UI and theme/display-density preferences
2019-02-12 20:41:39 -05:00
e723ec82bc
Added $r support
2019-02-05 13:19:08 +00:00
33deb79ce4
Added simple hooks support (same as in legacy DevTools for now)
...
I had to add a couple of comments because Flow was being a mysterious little shit and I got tired of trying to work around it.
2019-02-05 09:23:14 +00:00
d0d5b677de
Added better context support
2019-02-05 08:32:02 +00:00
b56bc1a626
Initial pass at properties panel. Lots of TODOs remaining.
2019-02-04 17:49:30 +00:00
406df2a617
Added properties panel and selected element context
2019-02-02 13:57:32 -08:00
bdfaeede6d
Fixed potential race cases in bridge/store/backend initialization
2019-01-31 14:27:16 -08:00
a60c8e139a
Renamed app.js to App.js for consistency
2019-01-30 10:49:50 -08:00
fdfadef928
Refactored bridge to support transferrables (e.g. typed array buffers) and added transferable param to postMessage for op codes
2019-01-29 13:17:37 -08:00
b7cbd38214
Misc updates to better handle tearing and add some future TODOs
2019-01-27 07:58:09 -08:00
d57ec69561
Added initial Chrome/Firefox shells
2019-01-23 18:06:21 -08:00
f881c32304
Added Prettier (and formatted code)
2019-01-23 08:45:19 -08:00
d02b4a2784
Throttle bridge traffic for Elements tree updates
2019-01-23 08:27:40 -08:00
5e0dfdac54
Initial commit
2019-01-22 11:04:37 -08:00
Ivan Babak
Brian Vaughn
Dan Abramov
Sriram Thiagarajan