Brian Vaughn
09029acf00
Refactored owners list to use cached metadata (and added more tests)
2019-04-25 15:06:24 -07:00
Brian Vaughn
15eacae02c
Moved owners list calculations into the store and added tests
...
This is being done to fix a drill-through bug, although the initial fix is perhaps not the most performant one. At least we have test coverage now and a temporary fix.
2019-04-25 15:06:24 -07:00
Dan Abramov
af2d1374c4
Let -> const
2019-04-25 17:39:13 +01:00
Dan Abramov
c8f8943c9a
Transfer strings in a string table
2019-04-25 17:11:24 +01:00
Dan Abramov
2993b168e5
Mutate the children array
2019-04-25 14:47:05 +01:00
Dan Abramov
949384f4ca
Select parent node if selection is removed
2019-04-24 16:29:23 +01:00
Brian Vaughn
7262a30cf3
Reverted optimization to avoid re-sending inspected fiber unless it committed
2019-04-23 18:04:25 -07:00
Brian Vaughn
c6b19cc141
Refactored insepected element cache to use the context API
2019-04-22 09:37:34 -07:00
Brian Vaughn
09b023a6e6
Naive suspense implementation for selected element panel
...
This commit leaves a few major things uunresolved:
* We aren't yet polling for updates
* We aren't yet using the two setState pattern
* The resource cache will grow unbounded over time because we aren't yet clearing items from it
* The renderer interface is not smart enough to avoid resending unchanged data between requests
2019-04-22 09:37:34 -07:00
Brian Vaughn and GitHub
76b29ad0a9
Merge pull request #201 from gaearon/scroll-fix
...
Fix scrolling to selected row in collapsed mode
2019-04-22 09:37:15 -07:00
Brian Vaughn
52652f3456
Toggle method no longer emits 'mutated' event unless it mutated the store
2019-04-21 12:20:23 -07:00
Dan Abramov
4ffdffb598
Fix scrolling to selected row in collapsed mode
2019-04-20 16:20:03 +01:00
Dan
efb5855c8c
Nits
2019-04-19 13:17:17 +01:00
Dan
3e657a6031
Prettier
2019-04-19 13:09:25 +01:00
Dan Abramov and GitHub
37dd1ec8f8
Merge branch 'master' into more-suspensey-stuff
2019-04-19 13:09:01 +01:00
Brian Vaughn
60b614f527
Renamed TREE_OPERATION_RESET_CHILDREN -> TREE_OPERATION_REORDER_CHILDREN
2019-04-18 17:59:53 -07:00
Brian Vaughn
24736e4ff5
Hardened reorder child invariants
2019-04-18 17:58:48 -07:00
Dan Abramov
b0c0a11f1b
Revert accidental change
2019-04-19 01:41:00 +01:00
Dan Abramov
534dfb0ca2
Optimize: don't recreate ID arrays all the time
2019-04-19 01:13:25 +01:00
Dan Abramov
8830ba890c
Fix more Suspense traversal bugs
2019-04-19 01:09:57 +01:00
Dan Abramov
ccecde76d1
Harden assertions
2019-04-19 00:29:49 +01:00
Brian Vaughn
3dfbf8ad6b
Added a new invariant to the store (bridge operations handler)
2019-04-18 15:40:50 -07:00
Brian Vaughn
d6e829d7a5
Fixed bug in reset-children to properly calculate new root weight
2019-04-18 09:54:26 -07:00
Brian Vaughn
358e63ac3d
Fixed a Suspense toggling bug that incorrectly impacted tree weight
2019-04-18 09:38:41 -07:00
Dan Abramov
6a13ffd231
Traverse the previous current tree when switching from primary to fallback
2019-04-18 16:22:50 +01:00
Dan Abramov
d02d93712e
Assert removal happens in the right order
2019-04-18 16:02:08 +01:00
Brian Vaughn
634d4fece2
Added more inline comments
2019-04-17 13:03:18 -07:00
Brian Vaughn
74be389124
Fixed a bug with re-ordering of children within a collapsed node
2019-04-17 09:39:54 -07:00
Brian Vaughn
178e89927a
Fixed some edge cases with collapsed by default. Still some bugs existing.
2019-04-17 07:45:33 -07:00
Brian Vaughn
037bb0034c
Throw if root node is collapsed
2019-04-16 14:10:06 -07:00
Brian Vaughn
4b64d7c017
Support configurable node/tree collapsed by default behavior
2019-04-16 13:59:36 -07:00
Brian Vaughn
b76372c93d
Fixed an edge case profiling bug where the number of commits was wrong
2019-04-13 18:29:39 -07:00
Brian Vaughn
25e918b4d9
Added [root] indicator to Store snapshot reprensentation
2019-04-12 08:55:29 -07:00
Brian Vaughn
7621df5baf
Initial example test. Will iterate from here.
2019-04-12 08:55:29 -07:00
Brian Vaughn
367249c175
Don't drill into owners list if no owner metadata is available
2019-04-11 14:00:27 -07:00
Brian Vaughn
f89f2b2146
Reverted misguided index/collapsed behavior
2019-04-10 09:23:24 -07:00
Brian Vaughn
74c9904e5d
Rewrote weightDelta calculation to be more readable based on PR feedback
2019-04-10 08:59:43 -07:00
Brian Vaughn
dd84e8ff2b
Newly selected components always auto-expand their ancestors
2019-04-10 08:57:42 -07:00
Brian Vaughn
1f7f0ea691
Update Store.getIndexOfElementID to take isCollapsed into account
2019-04-10 07:53:06 -07:00
Brian Vaughn
102267b1d6
Renamed _numElements attribute based on PR feedback
2019-04-10 07:42:32 -07:00
Brian Vaughn
79827c535b
Added isToggled boolean to tree nodes and toggleIsCollapsed() method to Store
2019-04-10 07:38:40 -07:00
Brian Vaughn
d766d3b2e5
Throttle screenshots to reduce impact on performance.
2019-04-06 13:58:55 -07:00
Dan
0f536bba5c
Rewrite the Suspense logic
2019-04-05 23:12:57 +01:00
Dan Abramov
2a5b8a9206
Hard crash
2019-04-05 18:41:26 +01:00
Dan Abramov
96a7adf49e
Add error logs in __DEBUG__
2019-04-05 18:27:02 +01:00
Dan Abramov
9170e5695a
Fix double-adding fibers when traversing
2019-04-05 18:18:39 +01:00
Dan
2928a0be74
Explicitly guard debug calls
2019-04-05 00:03:17 +01:00
Brian Vaughn
ed6e34da8e
Added option to disable screenshot capturing while profiling
2019-04-03 14:32:16 -07:00
Brian Vaughn and GitHub
d1a68c4b14
Merge pull request #45 from gaearon/rename
...
Tab name: "Elements" -> "Components"
2019-04-02 17:55:01 -07:00
Brian Vaughn
c111288c54
Store screenshots after each commit when profiling
2019-04-02 15:04:04 -07:00
Brian Vaughn
Dan Abramov
Brian VaughnandGitHub