Brian Vaughn
dbe68f7a67
Updated lint ignore for new dev shell dist folder
2019-05-08 08:52:48 -07:00
Subhan
60511aadc0
Profiler: Improve labels for times that round to 0.0ms
2019-05-08 10:11:52 +03:00
Sebastian Markbåge
c7398f3396
Add Suspense Boundary Context (and unstable_avoidThisFallback) ( #15578 )
...
* Avoidable suspense boundaries
* Move the context out of SuspenseComponent
* Use setDefaultShallowSuspenseContext instead of passing 0
2019-05-07 18:08:05 -07:00
Andrew Clark
f9e60c8a19
Warn when suspending at wrong priority ( #15492 )
...
* Warn when suspending at wrong priority
Adds a warning when a user-blocking update is suspended.
Ideally, all we would need to do is check the current priority level.
But we currently have no rigorous way to distinguish work that was
scheduled at user- blocking priority from work that expired a bit and
was "upgraded" to a higher priority. That's because we don't schedule
separate callbacks for every level, only the highest priority level per
root. The priority of subsequent levels is inferred from the expiration
time, but this is an imprecise heuristic.
However, we do store the last discrete pending update per root. So we
can reliably compare to that one. (If we broaden this warning to include
high pri updates that aren't discrete, then this won't be sufficient.)
My rationale is that it's better for this warning to have false
negatives than false positives.
Potential follow-ups:
- Bikeshed more on the message. I don't like what I landed on that much
but I think it's good enough to start.
- Include the names of the components that updated. (The ideal place to
fire the warning is during the setState call but we don't know if
something will suspend until the next update. Maybe we could be clever
and warn during a subsequent update to the same component?)
* Move Suspense priority check to throwException
2019-05-07 16:50:04 -07:00
Brian Vaughn
a54581c2dd
Fixed invalid DOM nesting warning
2019-05-07 15:25:17 -07:00
Brian Vaughn
44e90e6ef4
Upgrade @reach UI and remove tooltip fork
2019-05-07 15:22:57 -07:00
Brian Vaughn
97b7fdd2d9
Fixed a deprecated prop warning from react-window
2019-05-07 14:47:37 -07:00
Brian Vaughn
278661715c
Show import error dialog if profiling data import fails
2019-05-07 14:38:11 -07:00
Brian Vaughn
acdc9bae67
Added export+import profiling data test coverage
...
Also fixed an incomplete import feature as well as a regression in export that had gone unnoticed due to previous lack of test coverage.
2019-05-07 13:08:46 -07:00
Nicolas Gallagher
89d8d1435f
Add React.unstable_createEventComponent ( #15580 )
...
API for creating event components from event responders.
2019-05-07 12:36:42 -07:00
Brian Vaughn
90701815b6
Merge pull request #258 from bvaughn/profiler-test-experiments
...
Added profiler tests
2019-05-06 14:00:45 -07:00
Brian Vaughn
7ead699714
Prettier
2019-05-06 13:58:49 -07:00
Brian Vaughn
6ab8972345
Update to React canary release for interaction tracing bugfix
2019-05-06 13:52:27 -07:00
Brian Vaughn
c2bf71f406
Added commit tree builder test
2019-05-06 13:41:36 -07:00
Brian Vaughn
b25d996fc4
Added profiling chart data tests
2019-05-06 13:37:06 -07:00
Brian Vaughn
d86bc1020e
Hardened tests to ensure expectations are flushed
2019-05-06 13:04:14 -07:00
Brian Vaughn
6da04b5d88
Fix interaction tracing for batched update mounts ( #15567 )
...
* Added failing test for act+interaction tracing
* Mark pending interactions on root for legacy unbatched phase
2019-05-06 12:59:48 -07:00
Dominic Gannaway
d38cfd452f
Ensure TouchHitTarget element is server side rendered with hit slop ( #15385 )
...
* Follow up to 15381
* Add back in hit slop properties
* Prettier
* Fix lint
* move hydration update out of DEV block
* Remove pointer-events:auto
2019-05-06 20:13:23 +01:00
Brian Vaughn
705cd9b109
Added Flow types to profiling test
2019-05-06 09:44:01 -07:00
Brian Vaughn
c29483122c
Removed outdated TODO comment
2019-05-05 09:56:54 -07:00
Brian Vaughn
269969b645
Updated snapshot data after ReactDOM batch fix
2019-05-05 09:52:27 -07:00
Brian Vaughn
1c49a7ef59
Added remaining profiling tests. One currently fails because of a bug with act() and interaction tracing
2019-05-04 14:22:50 -07:00
Brian Vaughn
da1e5776b1
Added a second Profiling test (for CommitDetails) and fixed some module reset prolems
2019-05-04 13:11:56 -07:00
Brian Vaughn
dd96b3314c
Cleaned up tests a bit. Profiling test uses mock timers now.
2019-05-04 09:36:13 -07:00
Nicolas Gallagher
2e5d1a8b9e
React Events: fix cancel events for Press ( #15563 )
...
* Fixes a bug in the cancellation logic. The cancel events are now correctly listened to on the root.
* Fixes cancellation in Safari by using the dragstart event as a proxy for cancellation (i.e., the event dispatched when move-during-press occurs on an anchor tag)
2019-05-03 15:33:21 -07:00
Brian Vaughn
f7c8e3a05c
Experimenting with profiler tests
2019-05-03 15:01:26 -07:00
Brian Vaughn
a8ed95445c
Store profiler snapshot data by root (and clear on root unmount)
2019-05-03 14:59:20 -07:00
Nicolas Gallagher
307e0a7d7d
React Events: cancel onLongPress for large enough moves ( #15562 )
...
Implements the behaviour from React Native's Pressability.
2019-05-03 12:59:55 -07:00
Dominic Gannaway
339366c461
Event API: Support press reentry for pointer events ( #15560 )
2019-05-03 18:32:50 +01:00
Brian Vaughn
a552b7b5f7
Only clear Profiling snapshot on root-unmount
2019-05-03 10:12:45 -07:00
Brian Vaughn
73cf0fa32b
Merge branch 'master' into sompylasar-232-clear-profiling-data-for-unmounted-root
2019-05-03 10:01:43 -07:00
Brian Vaughn
542409954a
Merge pull request #257 from bvaughn/right-align-flame-graph
...
Right-align flame graph children
2019-05-03 10:01:23 -07:00
Brian Vaughn
8585ee37db
Renamed assertOneMap -> assertEmptyMap
2019-05-03 09:30:48 -07:00
Brian Vaughn
8850a9a64a
Merge branch '232-clear-profiling-data-for-unmounted-root' of https://github.com/sompylasar/react-devtools-experimental into sompylasar-232-clear-profiling-data-for-unmounted-root
2019-05-03 09:24:58 -07:00
Brian Vaughn
e71bda5257
Right-align flame graph children
2019-05-03 09:21:26 -07:00
Brian Vaughn
435e22ad1b
Fixed deploy script
2019-05-03 08:55:31 -07:00
Brian Vaughn
07281993d1
Merge pull request #242 from sompylasar/improve-flow-coverage-any
...
Improve Flow coverage by reducing typecasts through `any`
2019-05-03 08:00:47 -07:00
Brian Vaughn
868cf67aa4
Removed findCurrentFiberUsingSlowPath() in favor of findCurrentFiberUsingSlowPathById()
2019-05-03 07:56:24 -07:00
Brian Vaughn
7f4482e438
Removed optional_chaining from Flow config
2019-05-03 07:48:30 -07:00
Brian Vaughn
40ed0ca839
Merge branch '165-add-flow-types-for-fiber' of https://github.com/sompylasar/react-devtools-experimental into sompylasar-165-add-flow-types-for-fiber
2019-05-03 07:48:21 -07:00
Brian Vaughn
4bf3ac1910
Fixed broken path-selection after filter changes
2019-05-02 15:21:29 -07:00
Brian Vaughn
d7447a8458
Fixed bug in Store.getIndexOfElementID() that caused roots with multiple top-level children to return an incorrect item index
2019-05-02 15:12:57 -07:00
Brian Vaughn
4e04907d13
Added badge for enabled filter count
2019-05-02 10:53:40 -07:00
Brian Vaughn
ef596be1ef
Merge pull request #207 from sompylasar/131-highlight-all-children
...
Support highlighting of all DOM elements of Fragments, not just first
2019-05-02 08:31:22 -07:00
Brian Vaughn
1473e9efc8
Merge pull request #245 from bvaughn/custom-filtering
...
Add configurable component filters
2019-05-01 17:52:27 -07:00
Brian Vaughn
83b521c7b4
Updated Flamechart to support multiple nodes at root
2019-05-01 17:44:38 -07:00
Brian Vaughn
4a4786ac2f
Misc cleanup
2019-05-01 14:18:20 -07:00
Brian Vaughn
e6da4b9058
Renamed FilterType -> ComponentFilterType
2019-05-01 14:01:03 -07:00
Brian Vaughn
e45deb5471
Removed $FlowFixMe comments
2019-05-01 13:59:54 -07:00
Brian Vaughn
540207901d
Added some component filtering tests
2019-05-01 13:31:55 -07:00
Brian Vaughn
Subhan
Sebastian Markbåge
Andrew Clark
Nicolas Gallagher
Brian Vaughn
Dominic Gannaway