From fca5d655d78917400a2722287351c20938166669 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sebastian=20Markb=C3=A5ge?= Date: Wed, 14 Aug 2024 15:48:05 -0400 Subject: [PATCH] [DevTools] Hide props section if it is null (#30696) We use null as a marker that we don't know what the props are as opposed to knowing that they're empty. --- .../views/Components/InspectedElementPropsTree.js | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/packages/react-devtools-shared/src/devtools/views/Components/InspectedElementPropsTree.js b/packages/react-devtools-shared/src/devtools/views/Components/InspectedElementPropsTree.js index 808824816d..942d2a2490 100644 --- a/packages/react-devtools-shared/src/devtools/views/Components/InspectedElementPropsTree.js +++ b/packages/react-devtools-shared/src/devtools/views/Components/InspectedElementPropsTree.js @@ -54,11 +54,14 @@ export default function InspectedElementPropsTree({ type === ElementTypeClass || canEditFunctionPropsRenamePaths; const entries = props != null ? Object.entries(props) : null; - if (entries !== null) { - entries.sort(alphaSortEntries); + if (entries === null) { + // Skip the section for null props. + return null; } - const isEmpty = entries === null || entries.length === 0; + entries.sort(alphaSortEntries); + + const isEmpty = entries.length === 0; const handleCopy = () => copy(serializeDataForCopy(((props: any): Object)));