From fb0f7e5c39c01ee726205746439ecd7a1ceedb75 Mon Sep 17 00:00:00 2001 From: Joe Savona Date: Fri, 22 Mar 2024 11:53:29 -0700 Subject: [PATCH] Repro for closures reassigning hoisted let variables Adds examples for closures that reassign hoisted let bindings. We currently compile these as context variables without hoisting, so we hit an invariant in InferReferenceEffects when the variable is referenced before being declared. --- ...ences-later-variable-declaration.expect.md | 29 +++++++++++++++++++ ...n-references-later-variable-declaration.js | 8 +++++ ...erences-variable-its-assigned-to.expect.md | 27 +++++++++++++++++ ...ion-references-variable-its-assigned-to.js | 6 ++++ 4 files changed, 70 insertions(+) create mode 100644 compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/error.todo-function-expression-references-later-variable-declaration.expect.md create mode 100644 compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/error.todo-function-expression-references-later-variable-declaration.js create mode 100644 compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/error.todo-function-expression-references-variable-its-assigned-to.expect.md create mode 100644 compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/error.todo-function-expression-references-variable-its-assigned-to.js diff --git a/compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/error.todo-function-expression-references-later-variable-declaration.expect.md b/compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/error.todo-function-expression-references-later-variable-declaration.expect.md new file mode 100644 index 0000000000..797ea6a278 --- /dev/null +++ b/compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/error.todo-function-expression-references-later-variable-declaration.expect.md @@ -0,0 +1,29 @@ + +## Input + +```javascript +function Component() { + let callback = () => { + onClick = () => {}; + }; + let onClick; + + return
; +} + +``` + + +## Error + +``` + 1 | function Component() { + 2 | let callback = () => { +> 3 | onClick = () => {}; + | ^^^^^^^ [ReactForget] Invariant: [hoisting] Expected value kind to be initialized. read onClick$0_@1 (3:3) + 4 | }; + 5 | let onClick; + 6 | +``` + + \ No newline at end of file diff --git a/compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/error.todo-function-expression-references-later-variable-declaration.js b/compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/error.todo-function-expression-references-later-variable-declaration.js new file mode 100644 index 0000000000..5c023d6812 --- /dev/null +++ b/compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/error.todo-function-expression-references-later-variable-declaration.js @@ -0,0 +1,8 @@ +function Component() { + let callback = () => { + onClick = () => {}; + }; + let onClick; + + return
; +} diff --git a/compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/error.todo-function-expression-references-variable-its-assigned-to.expect.md b/compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/error.todo-function-expression-references-variable-its-assigned-to.expect.md new file mode 100644 index 0000000000..209f6bf447 --- /dev/null +++ b/compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/error.todo-function-expression-references-variable-its-assigned-to.expect.md @@ -0,0 +1,27 @@ + +## Input + +```javascript +function Component() { + let callback = () => { + callback = null; + }; + return
; +} + +``` + + +## Error + +``` + 1 | function Component() { + 2 | let callback = () => { +> 3 | callback = null; + | ^^^^^^^^ [ReactForget] Invariant: [hoisting] Expected value kind to be initialized. read callback$0_@0 (3:3) + 4 | }; + 5 | return
; + 6 | } +``` + + \ No newline at end of file diff --git a/compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/error.todo-function-expression-references-variable-its-assigned-to.js b/compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/error.todo-function-expression-references-variable-its-assigned-to.js new file mode 100644 index 0000000000..f5670b6371 --- /dev/null +++ b/compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/error.todo-function-expression-references-variable-its-assigned-to.js @@ -0,0 +1,6 @@ +function Component() { + let callback = () => { + callback = null; + }; + return
; +}