Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #41 from gaearon/smoother-right-pane

Browse Source 
Avoid flashing "Loading..." in right pane
This commit is contained in:
Brian Vaughn
2019-04-02 10:09:43 -07:00
committed by GitHub
parent b8ada905ff b223ec3b39
commit fa317bed61
1 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/devtools/views/Elements/SelectedElement.js
+11 -1
View File
@@ -30,7 +30,9 @@ export default function SelectedElement(_: Props) {
const element = const element =
selectedElementID !== null ? store.getElementByID(selectedElementID) : null; selectedElementID !== null ? store.getElementByID(selectedElementID) : null;
const inspectedElement = useInspectedElement(selectedElementID); const actualInspectedElement = useInspectedElement(selectedElementID);
// The UI lags behind to avoid flashing a loading state.
const inspectedElement = useLastNonNullValue(actualInspectedElement);
const highlightElement = useCallback(() => { const highlightElement = useCallback(() => {
if (element !== null && selectedElementID !== null) { if (element !== null && selectedElementID !== null) {
@@ -284,3 +286,11 @@ function useInspectedElement(id: number | null): InspectedElement | null {
return inspectedElement; return inspectedElement;
} }
function useLastNonNullValue<T>(value: T | null): T | null {
const [lastNonNullValue, setLastNonNullValue] = useState(value);
if (value !== null && value !== lastNonNullValue) {
setLastNonNullValue(value);
}
return lastNonNullValue;
}