From f4229cdb7fd53cf95bdb79209fa86f4216701c9b Mon Sep 17 00:00:00 2001 From: Lauren Tan Date: Thu, 28 Mar 2024 10:40:04 -0400 Subject: [PATCH] Rename error type --- .../packages/babel-plugin-react-forget/src/CompilerError.ts | 2 +- .../src/__tests__/envConfig-test.ts | 2 +- .../src/rules/ReactCompilerRule.ts | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/compiler/packages/babel-plugin-react-forget/src/CompilerError.ts b/compiler/packages/babel-plugin-react-forget/src/CompilerError.ts index 83c8303833..198d3a34b7 100644 --- a/compiler/packages/babel-plugin-react-forget/src/CompilerError.ts +++ b/compiler/packages/babel-plugin-react-forget/src/CompilerError.ts @@ -173,7 +173,7 @@ export class CompilerError extends Error { constructor(...args: any[]) { super(...args); - this.name = "ReactForgetCompilerError"; + this.name = "ReactCompilerError"; } override get message(): string { diff --git a/compiler/packages/babel-plugin-react-forget/src/__tests__/envConfig-test.ts b/compiler/packages/babel-plugin-react-forget/src/__tests__/envConfig-test.ts index 089dbb582b..2975d33872 100644 --- a/compiler/packages/babel-plugin-react-forget/src/__tests__/envConfig-test.ts +++ b/compiler/packages/babel-plugin-react-forget/src/__tests__/envConfig-test.ts @@ -20,7 +20,7 @@ describe("parseConfigPragma()", () => { validateHooksUsage: 1, } as any); }).toThrowErrorMatchingInlineSnapshot( - `"[ReactForget] InvalidConfig: Validation error: Expected boolean, received number at "validateHooksUsage". Update Forget config to fix the error"` + `"InvalidConfig: Validation error: Expected boolean, received number at "validateHooksUsage". Update Forget config to fix the error"` ); }); diff --git a/compiler/packages/eslint-plugin-react-compiler/src/rules/ReactCompilerRule.ts b/compiler/packages/eslint-plugin-react-compiler/src/rules/ReactCompilerRule.ts index 134d43fc9e..fb5982a55a 100644 --- a/compiler/packages/eslint-plugin-react-compiler/src/rules/ReactCompilerRule.ts +++ b/compiler/packages/eslint-plugin-react-compiler/src/rules/ReactCompilerRule.ts @@ -29,8 +29,8 @@ function assertExhaustive(_: never, errorMsg: string): never { throw new Error(errorMsg); } -function isReactForgetCompilerError(err: Error): err is CompilerError { - return err.name === "ReactForgetCompilerError"; +function isReactCompilerError(err: Error): err is CompilerError { + return err.name === "ReactCompilerError"; } function isReportableDiagnostic( @@ -131,7 +131,7 @@ const rule: Rule.RuleModule = { sourceType: "module", }); } catch (err) { - if (isReactForgetCompilerError(err) && Array.isArray(err.details)) { + if (isReactCompilerError(err) && Array.isArray(err.details)) { for (const detail of err.details) { if (!isReportableDiagnostic(detail)) { continue;