mirror of
https://github.com/facebook/react.git
synced 2026-11-18 20:15:56 +00:00
feat[react-devtools/extension]: use chrome.storage to persist settings across sessions (#30636)
Stacked on https://github.com/facebook/react/pull/30610 and whats under it. See [last commit](https://github.com/facebook/react/pull/30636/commits/248ddba18608e1bb5ef14c823085a7ff9d7a54a3). Now, we are using [`chrome.storage`](https://developer.chrome.com/docs/extensions/reference/api/storage) to persist settings for the browser extension across different sessions. Once settings are updated from the UI, the `Store` will emit `settingsUpdated` event, and we are going to persist them via `chrome.storage.local.set` in `main/index.js`. When hook is being injected, we are going to pass a `Promise`, which is going to be resolved after the settings are read from the storage via `chrome.storage.local.get` in `hookSettingsInjector.js`.
This commit is contained in:
1 parent
e33acfd67f
commit
f37c7bc653
12 files changed
+100
-52
No files matched your search
+42
@@ -0,0 +1,42 @@
|
||||
/* global chrome */
|
||||
|
||||
// We can't use chrome.storage domain from scripts which are injected in ExecutionWorld.MAIN
|
||||
// This is the only purpose of this script - to send persisted settings to installHook.js content script
|
||||
|
||||
async function messageListener(event: MessageEvent) {
|
||||
if (event.source !== window) {
|
||||
return;
|
||||
}
|
||||
|
||||
if (event.data.source === 'react-devtools-hook-installer') {
|
||||
if (event.data.payload.handshake) {
|
||||
const settings = await chrome.storage.local.get();
|
||||
// If storage was empty (first installation), define default settings
|
||||
if (typeof settings.appendComponentStack !== 'boolean') {
|
||||
settings.appendComponentStack = true;
|
||||
}
|
||||
if (typeof settings.breakOnConsoleErrors !== 'boolean') {
|
||||
settings.breakOnConsoleErrors = false;
|
||||
}
|
||||
if (typeof settings.showInlineWarningsAndErrors !== 'boolean') {
|
||||
settings.showInlineWarningsAndErrors = true;
|
||||
}
|
||||
if (typeof settings.hideConsoleLogsInStrictMode !== 'boolean') {
|
||||
settings.hideConsoleLogsInStrictMode = false;
|
||||
}
|
||||
|
||||
window.postMessage({
|
||||
source: 'react-devtools-hook-settings-injector',
|
||||
payload: {settings},
|
||||
});
|
||||
|
||||
window.removeEventListener('message', messageListener);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
window.addEventListener('message', messageListener);
|
||||
window.postMessage({
|
||||
source: 'react-devtools-hook-settings-injector',
|
||||
payload: {handshake: true},
|
||||
});
|
||||
@@ -1,10 +1,43 @@
|
||||
import {installHook} from 'react-devtools-shared/src/hook';
|
||||
|
||||
// avoid double execution
|
||||
if (!window.hasOwnProperty('__REACT_DEVTOOLS_GLOBAL_HOOK__')) {
|
||||
installHook(window);
|
||||
let resolveHookSettingsInjection;
|
||||
|
||||
// detect react
|
||||
function messageListener(event: MessageEvent) {
|
||||
if (event.source !== window) {
|
||||
return;
|
||||
}
|
||||
|
||||
if (event.data.source === 'react-devtools-hook-settings-injector') {
|
||||
// In case handshake message was sent prior to hookSettingsInjector execution
|
||||
// We can't guarantee order
|
||||
if (event.data.payload.handshake) {
|
||||
window.postMessage({
|
||||
source: 'react-devtools-hook-installer',
|
||||
payload: {handshake: true},
|
||||
});
|
||||
} else if (event.data.payload.settings) {
|
||||
window.removeEventListener('message', messageListener);
|
||||
resolveHookSettingsInjection(event.data.payload.settings);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// Avoid double execution
|
||||
if (!window.hasOwnProperty('__REACT_DEVTOOLS_GLOBAL_HOOK__')) {
|
||||
const hookSettingsPromise = new Promise(resolve => {
|
||||
resolveHookSettingsInjection = resolve;
|
||||
});
|
||||
|
||||
window.addEventListener('message', messageListener);
|
||||
window.postMessage({
|
||||
source: 'react-devtools-hook-installer',
|
||||
payload: {handshake: true},
|
||||
});
|
||||
|
||||
// Can't delay hook installation, inject settings lazily
|
||||
installHook(window, hookSettingsPromise);
|
||||
|
||||
// Detect React
|
||||
window.__REACT_DEVTOOLS_GLOBAL_HOOK__.on(
|
||||
'renderer',
|
||||
function ({reactBuildType}) {
|
||||
|
||||
Reference in new issue
Block a user