From 52b4c9eabf6c5930a906df4584c8480db5ec6e9e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Paul=20O=E2=80=99Shannessy?= Date: Mon, 31 Aug 2015 17:17:30 -0700 Subject: [PATCH] Upgrade to fbjs, fbjs-scripts @ 0.2 --- gulpfile.js | 4 ++-- package.json | 6 ++--- packages/react-dom/package.json | 1 - packages/react/package.json | 2 +- scripts/check-dev-engines.js | 41 --------------------------------- scripts/jest/preprocessor.js | 4 ++-- 6 files changed, 8 insertions(+), 50 deletions(-) delete mode 100644 scripts/check-dev-engines.js diff --git a/gulpfile.js b/gulpfile.js index 4adf9b564b..f629f6624f 100644 --- a/gulpfile.js +++ b/gulpfile.js @@ -14,8 +14,8 @@ var babel = require('gulp-babel'); var flatten = require('gulp-flatten'); var del = require('del'); -var babelPluginDEV = require('fbjs/scripts/babel/dev-expression'); -var babelPluginModules = require('fbjs/scripts/babel/rewrite-modules'); +var babelPluginDEV = require('fbjs-scripts/babel/dev-expression'); +var babelPluginModules = require('fbjs-scripts/babel/rewrite-modules'); var paths = { react: { diff --git a/package.json b/package.json index 595d41adf0..4ebcbdad50 100644 --- a/package.json +++ b/package.json @@ -15,7 +15,8 @@ "eslint": "^1.1.0", "eslint-plugin-react": "^3.2.1", "eslint-plugin-react-internal": "file:eslint-rules", - "fbjs": "0.1.0-alpha.4", + "fbjs": "^0.2.0", + "fbjs-scripts": "^0.2.0", "grunt": "^0.4.5", "grunt-cli": "^0.1.13", "grunt-compare-size": "^0.4.0", @@ -32,7 +33,6 @@ "optimist": "^0.6.1", "platform": "^1.1.0", "run-sequence": "^1.1.0", - "semver": "^5.0.1", "through2": "^2.0.0", "tmp": "~0.0.18", "typescript": "~1.4.0", @@ -50,7 +50,7 @@ "build": "grunt build", "linc": "git diff --name-only --diff-filter=ACMRTUB `git merge-base HEAD master` | grep '\\.js$' | xargs eslint --", "lint": "grunt lint", - "postinstall": "node scripts/check-dev-engines.js", + "postinstall": "node node_modules/fbjs-scripts/node/check-dev-engines.js package.json", "test": "NODE_ENV=test jest" }, "jest": { diff --git a/packages/react-dom/package.json b/packages/react-dom/package.json index dd4c93334c..17762004cd 100644 --- a/packages/react-dom/package.json +++ b/packages/react-dom/package.json @@ -16,7 +16,6 @@ }, "homepage": "https://github.com/facebook/react/tree/master/npm-react-dom", "dependencies": { - "fbjs": "0.1.0-alpha.4", "react": "^0.14.0-beta3" } } diff --git a/packages/react/package.json b/packages/react/package.json index 02dc6ad691..53fee4a13d 100644 --- a/packages/react/package.json +++ b/packages/react/package.json @@ -22,7 +22,7 @@ }, "dependencies": { "envify": "^3.0.0", - "fbjs": "0.1.0-alpha.4" + "fbjs": "^0.2.0" }, "browserify": { "transform": [ diff --git a/scripts/check-dev-engines.js b/scripts/check-dev-engines.js deleted file mode 100644 index eafebc6daf..0000000000 --- a/scripts/check-dev-engines.js +++ /dev/null @@ -1,41 +0,0 @@ -'use strict'; - -var devEngines = require('../package').devEngines; - -var assert = require('assert'); -var exec = require('child_process').exec; -var semver = require('semver'); -var f = require('util').format; - -if (devEngines.node !== undefined) { - // First check that devEngines are valid semver - assert( - semver.validRange(devEngines.node), - f('devEngines.node (%s) is not a valid semver range', devEngines.node) - ); - // Then actually check that our version satisfies - var nodeVersion = process.versions.node; - assert( - semver.satisfies(nodeVersion, devEngines.node), - f('Current node version is not supported for development, expected "%s" to satisfy "%s".', nodeVersion, devEngines.node) - ); -} - -if (devEngines.npm !== undefined) { - // First check that devEngines are valid semver - assert( - semver.validRange(devEngines.npm), - f('devEngines.npm (%s) is not a valid semver range', devEngines.npm) - ); - - // Then actually check that our version satisfies - exec('npm --version', function(err, stdout, stderr) { - assert(err === null, f('Failed to get npm version... %s'), stderr); - - var npmVersion = stdout.trim(); - assert( - semver.satisfies(npmVersion, devEngines.npm), - f('Current npm version is not supported for development, expected "%s" to satisfy "%s".', npmVersion, devEngines.npm) - ); - }); -} diff --git a/scripts/jest/preprocessor.js b/scripts/jest/preprocessor.js index 45d38b0865..cc284d757a 100644 --- a/scripts/jest/preprocessor.js +++ b/scripts/jest/preprocessor.js @@ -17,8 +17,8 @@ var ts = tsPreprocessor(defaultLibraries); // This assumes the module map has been built. This might not be safe. // We should consider consuming this from a built fbjs module from npm. var moduleMap = require('fbjs/module-map'); -var babelPluginDEV = require('fbjs/scripts/babel/dev-expression'); -var babelPluginModules = require('fbjs/scripts/babel/rewrite-modules'); +var babelPluginDEV = require('fbjs-scripts/babel/dev-expression'); +var babelPluginModules = require('fbjs-scripts/babel/rewrite-modules'); module.exports = { process: function(src, filePath) {