From ef60eee57ab8a86e47847761532cf72a1205b668 Mon Sep 17 00:00:00 2001 From: Keito Uchiyama Date: Wed, 9 Oct 2013 11:11:41 -0700 Subject: [PATCH] Make transferPropsTo() message easier to debug Summary: Made the transferPropsTo() error introduced in 325322898cc413454feede0201b61da1abe1e67e easier to use to debug. --- src/core/ReactPropTransferer.js | 8 +++++--- src/core/__tests__/ReactPropTransferer-test.js | 3 ++- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/src/core/ReactPropTransferer.js b/src/core/ReactPropTransferer.js index db8e675d5b..4430652689 100644 --- a/src/core/ReactPropTransferer.js +++ b/src/core/ReactPropTransferer.js @@ -93,9 +93,11 @@ var ReactPropTransferer = { transferPropsTo: function(component) { invariant( component.props.__owner__ === this, - 'You can\'t call transferPropsTo() on a component that you don\'t ' + - 'own. This usually means you are calling transferPropsTo() on a ' + - 'component passed in as props or children.' + '%s: You can\'t call transferPropsTo() on a component that you ' + + 'don\'t own, %s. This usually means you are calling ' + + 'transferPropsTo() on a component passed in as props or children.', + this.constructor.displayName, + component.constructor.displayName ); var props = {}; diff --git a/src/core/__tests__/ReactPropTransferer-test.js b/src/core/__tests__/ReactPropTransferer-test.js index 8b75130005..1854ef7e95 100644 --- a/src/core/__tests__/ReactPropTransferer-test.js +++ b/src/core/__tests__/ReactPropTransferer-test.js @@ -148,7 +148,8 @@ describe('ReactPropTransferer', function() { ReactTestUtils.renderIntoDocument(); }).toThrow( 'Invariant Violation: ' + - 'You can\'t call transferPropsTo() on a component that you don\'t own. ' + + 'Child: You can\'t call transferPropsTo() on a component that you ' + + 'don\'t own, span. ' + 'This usually means you are calling transferPropsTo() on a component ' + 'passed in as props or children.' );