From ed215634bea3030b9fd19c2929fcd13ab412f8fe Mon Sep 17 00:00:00 2001 From: Sebastian Markbage Date: Tue, 7 Jun 2016 17:12:41 -0700 Subject: [PATCH] Get rid of ugly and difficult to follow breaks in switch Because pattern matching or something. --- src/renderers/shared/fiber/ReactFiberCompleteWork.js | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/renderers/shared/fiber/ReactFiberCompleteWork.js b/src/renderers/shared/fiber/ReactFiberCompleteWork.js index f4d72e3d10..179e050848 100644 --- a/src/renderers/shared/fiber/ReactFiberCompleteWork.js +++ b/src/renderers/shared/fiber/ReactFiberCompleteWork.js @@ -95,14 +95,14 @@ exports.completeWork = function(current : ?Fiber, workInProgress : Fiber) : ?Fib case FunctionalComponent: console.log('/functional component', workInProgress.type.name); transferOutput(workInProgress.child, workInProgress); - break; + return null; case ClassComponent: console.log('/class component', workInProgress.type.name); transferOutput(workInProgress.child, workInProgress); - break; + return null; case HostComponent: console.log('/host component', workInProgress.type); - break; + return null; case CoroutineComponent: console.log('/coroutine component', workInProgress.input.handler.name); return moveCoroutineToHandlerPhase(current, workInProgress); @@ -110,10 +110,10 @@ exports.completeWork = function(current : ?Fiber, workInProgress : Fiber) : ?Fib transferOutput(workInProgress.stateNode, workInProgress); // Reset the tag to now be a first phase coroutine. workInProgress.tag = CoroutineComponent; - break; + return null; case YieldComponent: // Does nothing. - break; + return null; // Error cases case IndeterminateComponent: @@ -121,5 +121,4 @@ exports.completeWork = function(current : ?Fiber, workInProgress : Fiber) : ?Fib default: throw new Error('Unknown unit of work tag'); } - return null; };