From e4606c1e0ebbf397d0d4fe305e13dfb61a51e411 Mon Sep 17 00:00:00 2001 From: Jarred Sumner Date: Wed, 15 Mar 2023 19:09:49 -0700 Subject: [PATCH] Add missing `"react-dom/server.bun"` entry in package.json `"exports"` (#26402) ## Summary `react-dom/server` in Bun (correctly) chooses `react-dom/server.bun`, but `react-dom/server.bun` currently can't be imported because it is not included in package.json `"exports"` (`react-dom/server` works, `react-dom/server.bun` doesn't). Previously, I didn't think it was necessary to do that, but it is too easy to accidentally run the browser build in unit tests when importing `react-dom/server` This also aligns behavior of package.json `"exports"` of `react-dom/server.bun` with `react-dom/server.browser`, `react-dom/server.node`, and the rest. ## How did you test this change? Manually edited package.json in node_modules in a separate folder and ran tests in Bun with `react-dom/server.bun` as the import specifier --- packages/react-dom/package.json | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/react-dom/package.json b/packages/react-dom/package.json index d38382b9f2..d5f051694b 100644 --- a/packages/react-dom/package.json +++ b/packages/react-dom/package.json @@ -58,6 +58,7 @@ "default": "./server.node.js" }, "./server.browser": "./server.browser.js", + "./server.bun": "./server.bun.js", "./server.edge": "./server.edge.js", "./server.node": "./server.node.js", "./static": {