From e23690a0dc52af49d7e58e280195a4ddab575fc3 Mon Sep 17 00:00:00 2001 From: starkch Date: Mon, 27 Jun 2016 18:30:09 -0400 Subject: [PATCH] Reword invariant message about empty tags (fixes #7065) (#7066) * addresses issue #7065 * fix test to use new message * fix string in tests * fix test string * Update error message and tests (cherry picked from commit f94912516fc54f7ddd6fb3a2b6925efe6481b3d4) --- src/renderers/dom/shared/ReactDOMComponent.js | 4 ++-- .../__tests__/ReactDOMComponent-test.js | 24 +++++++++---------- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/src/renderers/dom/shared/ReactDOMComponent.js b/src/renderers/dom/shared/ReactDOMComponent.js index 3e32ed152f..a11dcb46a8 100644 --- a/src/renderers/dom/shared/ReactDOMComponent.js +++ b/src/renderers/dom/shared/ReactDOMComponent.js @@ -154,8 +154,8 @@ function assertValidProps(component, props) { if (voidElementTags[component._tag]) { invariant( props.children == null && props.dangerouslySetInnerHTML == null, - '%s is a void element tag and must not have `children` or ' + - 'use `props.dangerouslySetInnerHTML`.%s', + '%s is a void element tag and must neither have `children` nor ' + + 'use `dangerouslySetInnerHTML`.%s', component._tag, component._currentElement._owner ? ' Check the render method of ' + diff --git a/src/renderers/dom/shared/__tests__/ReactDOMComponent-test.js b/src/renderers/dom/shared/__tests__/ReactDOMComponent-test.js index b4fc9f0ced..41700fb0f6 100644 --- a/src/renderers/dom/shared/__tests__/ReactDOMComponent-test.js +++ b/src/renderers/dom/shared/__tests__/ReactDOMComponent-test.js @@ -811,8 +811,8 @@ describe('ReactDOMComponent', function() { expect(function() { ReactDOM.render(children, container); }).toThrowError( - 'input is a void element tag and must not have `children` or ' + - 'use `props.dangerouslySetInnerHTML`.' + 'input is a void element tag and must neither have `children` nor ' + + 'use `dangerouslySetInnerHTML`.' ); }); @@ -825,8 +825,8 @@ describe('ReactDOMComponent', function() { container ); }).toThrowError( - 'input is a void element tag and must not have `children` or use ' + - '`props.dangerouslySetInnerHTML`.' + 'input is a void element tag and must neither have `children` nor use ' + + '`dangerouslySetInnerHTML`.' ); }); @@ -840,8 +840,8 @@ describe('ReactDOMComponent', function() { expect(function() { ReactDOM.render(children, container); }).toThrowError( - 'menuitem is a void element tag and must not have `children` or use ' + - '`props.dangerouslySetInnerHTML`.' + 'menuitem is a void element tag and must neither have `children` nor use ' + + '`dangerouslySetInnerHTML`.' ); }); @@ -977,8 +977,8 @@ describe('ReactDOMComponent', function() { expect(function() { ReactDOM.render(, container); }).toThrowError( - 'input is a void element tag and must not have `children` ' + - 'or use `props.dangerouslySetInnerHTML`. Check the render method of X.' + 'input is a void element tag and must neither have `children` ' + + 'nor use `dangerouslySetInnerHTML`. Check the render method of X.' ); }); @@ -1007,8 +1007,8 @@ describe('ReactDOMComponent', function() { expect(function() { ReactDOM.render(children, container); }).toThrowError( - 'input is a void element tag and must not have `children` or use ' + - '`props.dangerouslySetInnerHTML`.' + 'input is a void element tag and must neither have `children` nor use ' + + '`dangerouslySetInnerHTML`.' ); }); @@ -1021,8 +1021,8 @@ describe('ReactDOMComponent', function() { container ); }).toThrowError( - 'input is a void element tag and must not have `children` or use ' + - '`props.dangerouslySetInnerHTML`.' + 'input is a void element tag and must neither have `children` nor use ' + + '`dangerouslySetInnerHTML`.' ); });