Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Move all dev *Hook tests and ComponentTreeTestUtils to expectDev (#8350)

Browse Source
This commit is contained in:
Tom Occhino
2016-11-18 18:53:48 +00:00
committed by GitHub
parent 0deb71223d
commit dfdff2b61a
6 changed files with 127 additions and 123 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/renderers/shared/hooks/__tests__/ReactComponentTreeHook-test.js
+30 -30
View File
@@ -54,11 +54,11 @@ describe('ReactComponentTreeHook', () => {
var rootDisplayNames = ReactComponentTreeTestUtils.getRootDisplayNames();
var registeredDisplayNames = ReactComponentTreeTestUtils.getRegisteredDisplayNames();
if (!expectedTree) {
expect(rootDisplayNames).toEqual([]);
expect(registeredDisplayNames).toEqual([]);
expectDev(rootDisplayNames).toEqual([]);
expectDev(registeredDisplayNames).toEqual([]);
} else if (andStayMounted) {
expect(rootDisplayNames).toContain('Wrapper');
expect(registeredDisplayNames).toContain('Wrapper');
expectDev(rootDisplayNames).toContain('Wrapper');
expectDev(registeredDisplayNames).toContain('Wrapper');
}
}
@@ -1692,48 +1692,48 @@ describe('ReactComponentTreeHook', () => {
ReactDOM.render(<div className="a" />, node);
var divID = ReactComponentTreeHook.getRootIDs()[0];
expect(ReactComponentTreeHook.getUpdateCount(divID)).toEqual(0);
expectDev(ReactComponentTreeHook.getUpdateCount(divID)).toEqual(0);
ReactDOM.render(<span className="a" />, node);
var spanID = ReactComponentTreeHook.getRootIDs()[0];
expect(ReactComponentTreeHook.getUpdateCount(divID)).toEqual(0);
expect(ReactComponentTreeHook.getUpdateCount(spanID)).toEqual(0);
expectDev(ReactComponentTreeHook.getUpdateCount(divID)).toEqual(0);
expectDev(ReactComponentTreeHook.getUpdateCount(spanID)).toEqual(0);
ReactDOM.render(<span className="b" />, node);
expect(ReactComponentTreeHook.getUpdateCount(divID)).toEqual(0);
expect(ReactComponentTreeHook.getUpdateCount(spanID)).toEqual(1);
expectDev(ReactComponentTreeHook.getUpdateCount(divID)).toEqual(0);
expectDev(ReactComponentTreeHook.getUpdateCount(spanID)).toEqual(1);
ReactDOM.render(<span className="c" />, node);
expect(ReactComponentTreeHook.getUpdateCount(divID)).toEqual(0);
expect(ReactComponentTreeHook.getUpdateCount(spanID)).toEqual(2);
expectDev(ReactComponentTreeHook.getUpdateCount(divID)).toEqual(0);
expectDev(ReactComponentTreeHook.getUpdateCount(spanID)).toEqual(2);
ReactDOM.unmountComponentAtNode(node);
expect(ReactComponentTreeHook.getUpdateCount(divID)).toEqual(0);
expect(ReactComponentTreeHook.getUpdateCount(spanID)).toEqual(0);
expectDev(ReactComponentTreeHook.getUpdateCount(divID)).toEqual(0);
expectDev(ReactComponentTreeHook.getUpdateCount(spanID)).toEqual(0);
});
it('does not report top-level wrapper as a root', () => {
var node = document.createElement('div');
ReactDOM.render(<div className="a" />, node);
expect(ReactComponentTreeTestUtils.getRootDisplayNames()).toEqual(['div']);
expectDev(ReactComponentTreeTestUtils.getRootDisplayNames()).toEqual(['div']);
ReactDOM.render(<div className="b" />, node);
expect(ReactComponentTreeTestUtils.getRootDisplayNames()).toEqual(['div']);
expectDev(ReactComponentTreeTestUtils.getRootDisplayNames()).toEqual(['div']);
ReactDOM.unmountComponentAtNode(node);
expect(ReactComponentTreeTestUtils.getRootDisplayNames()).toEqual([]);
expect(ReactComponentTreeTestUtils.getRegisteredDisplayNames()).toEqual([]);
expectDev(ReactComponentTreeTestUtils.getRootDisplayNames()).toEqual([]);
expectDev(ReactComponentTreeTestUtils.getRegisteredDisplayNames()).toEqual([]);
});
it('registers inlined text nodes', () => {
var node = document.createElement('div');
ReactDOM.render(<div>hi</div>, node);
expect(ReactComponentTreeTestUtils.getRegisteredDisplayNames()).toEqual(['div', '#text']);
expectDev(ReactComponentTreeTestUtils.getRegisteredDisplayNames()).toEqual(['div', '#text']);
ReactDOM.unmountComponentAtNode(node);
expect(ReactComponentTreeTestUtils.getRegisteredDisplayNames()).toEqual([]);
expectDev(ReactComponentTreeTestUtils.getRegisteredDisplayNames()).toEqual([]);
});
describe('stack addenda', () => {
@@ -1746,19 +1746,19 @@ describe('ReactComponentTreeHook', () => {
var Anon = React.createClass({displayName: null, render: () => null});
var Orange = React.createClass({render: () => null});
expect(getAddendum()).toBe(
expectDev(getAddendum()).toBe(
''
);
expect(getAddendum(<div />)).toBe(
expectDev(getAddendum(<div />)).toBe(
'\n in div (at **)'
);
expect(getAddendum(<Anon />)).toBe(
expectDev(getAddendum(<Anon />)).toBe(
'\n in Unknown (at **)'
);
expect(getAddendum(<Orange />)).toBe(
expectDev(getAddendum(<Orange />)).toBe(
'\n in Orange (at **)'
);
expect(getAddendum(React.createElement(Orange))).toBe(
expectDev(getAddendum(React.createElement(Orange))).toBe(
'\n in Orange'
);
@@ -1778,20 +1778,20 @@ describe('ReactComponentTreeHook', () => {
this.forceUpdate();
}
render() {
expect(getAddendum()).toBe(
expectDev(getAddendum()).toBe(
'\n in S (at **)' +
'\n in div (at **)' +
'\n in R (created by Q)' +
'\n in Q (at **)'
);
expect(getAddendum(<span />)).toBe(
expectDev(getAddendum(<span />)).toBe(
'\n in span (at **)' +
'\n in S (at **)' +
'\n in div (at **)' +
'\n in R (created by Q)' +
'\n in Q (at **)'
);
expect(getAddendum(React.createElement('span'))).toBe(
expectDev(getAddendum(React.createElement('span'))).toBe(
'\n in span (created by S)' +
'\n in S (at **)' +
'\n in div (at **)' +
@@ -1803,10 +1803,10 @@ describe('ReactComponentTreeHook', () => {
}
}
ReactDOM.render(<Q />, document.createElement('div'));
expect(renders).toBe(2);
expectDev(renders).toBe(2);
// Make sure owner is fetched for the top element too.
expect(getAddendum(rOwnedByQ)).toBe(
expectDev(getAddendum(rOwnedByQ)).toBe(
'\n in R (created by Q)'
);
});
@@ -1824,7 +1824,7 @@ describe('ReactComponentTreeHook', () => {
}
var q = ReactDOM.render(<Q />, document.createElement('div'));
expect(getAddendum(ReactInstanceMap.get(q)._debugID)).toBe(
expectDev(getAddendum(ReactInstanceMap.get(q)._debugID)).toBe(
'\n in Q (at **)'
);
src/renderers/shared/hooks/__tests__/ReactComponentTreeHook-test.native.js
+17 -17
View File
@@ -78,11 +78,11 @@ describe('ReactComponentTreeHook', () => {
var rootDisplayNames = ReactComponentTreeTestUtils.getRootDisplayNames();
var registeredDisplayNames = ReactComponentTreeTestUtils.getRegisteredDisplayNames();
if (!expectedTree) {
expect(rootDisplayNames).toEqual([]);
expect(registeredDisplayNames).toEqual([]);
expectDev(rootDisplayNames).toEqual([]);
expectDev(registeredDisplayNames).toEqual([]);
} else if (andStayMounted) {
expect(rootDisplayNames).toContain('Wrapper');
expect(registeredDisplayNames).toContain('Wrapper');
expectDev(rootDisplayNames).toContain('Wrapper');
expectDev(registeredDisplayNames).toContain('Wrapper');
}
}
@@ -1664,35 +1664,35 @@ describe('ReactComponentTreeHook', () => {
it('reports update counts', () => {
ReactNative.render(<View />, 1);
var viewID = ReactComponentTreeHook.getRootIDs()[0];
expect(ReactComponentTreeHook.getUpdateCount(viewID)).toEqual(0);
expectDev(ReactComponentTreeHook.getUpdateCount(viewID)).toEqual(0);
ReactNative.render(<Image />, 1);
var imageID = ReactComponentTreeHook.getRootIDs()[0];
expect(ReactComponentTreeHook.getUpdateCount(viewID)).toEqual(0);
expect(ReactComponentTreeHook.getUpdateCount(imageID)).toEqual(0);
expectDev(ReactComponentTreeHook.getUpdateCount(viewID)).toEqual(0);
expectDev(ReactComponentTreeHook.getUpdateCount(imageID)).toEqual(0);
ReactNative.render(<Image />, 1);
expect(ReactComponentTreeHook.getUpdateCount(viewID)).toEqual(0);
expect(ReactComponentTreeHook.getUpdateCount(imageID)).toEqual(1);
expectDev(ReactComponentTreeHook.getUpdateCount(viewID)).toEqual(0);
expectDev(ReactComponentTreeHook.getUpdateCount(imageID)).toEqual(1);
ReactNative.render(<Image />, 1);
expect(ReactComponentTreeHook.getUpdateCount(viewID)).toEqual(0);
expect(ReactComponentTreeHook.getUpdateCount(imageID)).toEqual(2);
expectDev(ReactComponentTreeHook.getUpdateCount(viewID)).toEqual(0);
expectDev(ReactComponentTreeHook.getUpdateCount(imageID)).toEqual(2);
ReactNative.unmountComponentAtNode(1);
expect(ReactComponentTreeHook.getUpdateCount(viewID)).toEqual(0);
expect(ReactComponentTreeHook.getUpdateCount(imageID)).toEqual(0);
expectDev(ReactComponentTreeHook.getUpdateCount(viewID)).toEqual(0);
expectDev(ReactComponentTreeHook.getUpdateCount(imageID)).toEqual(0);
});
it('does not report top-level wrapper as a root', () => {
ReactNative.render(<View><Image /></View>, 1);
expect(ReactComponentTreeTestUtils.getRootDisplayNames()).toEqual(['View']);
expectDev(ReactComponentTreeTestUtils.getRootDisplayNames()).toEqual(['View']);
ReactNative.render(<View><Text /></View>, 1);
expect(ReactComponentTreeTestUtils.getRootDisplayNames()).toEqual(['View']);
expectDev(ReactComponentTreeTestUtils.getRootDisplayNames()).toEqual(['View']);
ReactNative.unmountComponentAtNode(1);
expect(ReactComponentTreeTestUtils.getRootDisplayNames()).toEqual([]);
expect(ReactComponentTreeTestUtils.getRegisteredDisplayNames()).toEqual([]);
expectDev(ReactComponentTreeTestUtils.getRootDisplayNames()).toEqual([]);
expectDev(ReactComponentTreeTestUtils.getRegisteredDisplayNames()).toEqual([]);
});
});
src/renderers/shared/hooks/__tests__/ReactHostOperationHistoryHook-test.js
+1 -1
View File
@@ -38,7 +38,7 @@ describe('ReactHostOperationHistoryHook', () => {
function assertHistoryMatches(expectedHistory) {
var actualHistory = ReactHostOperationHistoryHook.getHistory();
expect(actualHistory).toEqual(expectedHistory);
expectDev(actualHistory).toEqual(expectedHistory);
}
describe('mount', () => {
src/test/ReactComponentTreeTestUtils.js
+1 -1
View File
@@ -35,7 +35,7 @@ function expectTree(rootID, expectedTree, parentPath) {
function expectEqual(actual, expected, name) {
// Get Jasmine to print descriptive error messages.
// We pass path so that we know where the mismatch occurred.
expect({
expectDev({
path,
[name]: actual,
}).toEqual({