From df319522758b7fdfed3ddfa517cc1cc298ef1602 Mon Sep 17 00:00:00 2001 From: Ricky Date: Mon, 17 Mar 2025 09:37:07 -0400 Subject: [PATCH] Remove offscreen type (#32639) Based off https://github.com/facebook/react/pull/32499 This is no longer used. [Review commit](https://github.com/facebook/react/commit/88c297d12f8b2562be3982fba867f03a137551cb) --- packages/react-reconciler/src/ReactFiber.js | 4 ---- packages/shared/ReactSymbols.js | 1 - packages/shared/isValidElementType.js | 2 -- 3 files changed, 7 deletions(-) diff --git a/packages/react-reconciler/src/ReactFiber.js b/packages/react-reconciler/src/ReactFiber.js index 7b63135c05..7f5fbe59b8 100644 --- a/packages/react-reconciler/src/ReactFiber.js +++ b/packages/react-reconciler/src/ReactFiber.js @@ -103,7 +103,6 @@ import { REACT_MEMO_TYPE, REACT_LAZY_TYPE, REACT_SCOPE_TYPE, - REACT_OFFSCREEN_TYPE, REACT_LEGACY_HIDDEN_TYPE, REACT_TRACING_MARKER_TYPE, REACT_ELEMENT_TYPE, @@ -614,8 +613,6 @@ export function createFiberFromTypeAndProps( return createFiberFromSuspense(pendingProps, mode, lanes, key); case REACT_SUSPENSE_LIST_TYPE: return createFiberFromSuspenseList(pendingProps, mode, lanes, key); - case REACT_OFFSCREEN_TYPE: - return createFiberFromOffscreen(pendingProps, mode, lanes, key); case REACT_LEGACY_HIDDEN_TYPE: if (enableLegacyHidden) { return createFiberFromLegacyHidden(pendingProps, mode, lanes, key); @@ -854,7 +851,6 @@ export function createFiberFromOffscreen( key: null | string, ): Fiber { const fiber = createFiber(OffscreenComponent, pendingProps, key, mode); - fiber.elementType = REACT_OFFSCREEN_TYPE; fiber.lanes = lanes; const primaryChildInstance: OffscreenInstance = { _visibility: OffscreenVisible, diff --git a/packages/shared/ReactSymbols.js b/packages/shared/ReactSymbols.js index 1fd00cd76d..937c01cf75 100644 --- a/packages/shared/ReactSymbols.js +++ b/packages/shared/ReactSymbols.js @@ -33,7 +33,6 @@ export const REACT_SUSPENSE_LIST_TYPE: symbol = Symbol.for( export const REACT_MEMO_TYPE: symbol = Symbol.for('react.memo'); export const REACT_LAZY_TYPE: symbol = Symbol.for('react.lazy'); export const REACT_SCOPE_TYPE: symbol = Symbol.for('react.scope'); -export const REACT_OFFSCREEN_TYPE: symbol = Symbol.for('react.offscreen'); export const REACT_ACTIVITY_TYPE: symbol = Symbol.for('react.activity'); export const REACT_LEGACY_HIDDEN_TYPE: symbol = Symbol.for( 'react.legacy_hidden', diff --git a/packages/shared/isValidElementType.js b/packages/shared/isValidElementType.js index 41370b47a0..84e4fe802a 100644 --- a/packages/shared/isValidElementType.js +++ b/packages/shared/isValidElementType.js @@ -21,7 +21,6 @@ import { REACT_LAZY_TYPE, REACT_SCOPE_TYPE, REACT_LEGACY_HIDDEN_TYPE, - REACT_OFFSCREEN_TYPE, REACT_TRACING_MARKER_TYPE, REACT_VIEW_TRANSITION_TYPE, REACT_ACTIVITY_TYPE, @@ -52,7 +51,6 @@ export default function isValidElementType(type: mixed): boolean { type === REACT_SUSPENSE_LIST_TYPE || (enableLegacyHidden && type === REACT_LEGACY_HIDDEN_TYPE) || type === REACT_ACTIVITY_TYPE || - type === REACT_OFFSCREEN_TYPE || (enableScopeAPI && type === REACT_SCOPE_TYPE) || (enableTransitionTracing && type === REACT_TRACING_MARKER_TYPE) || (enableViewTransition && type === REACT_VIEW_TRANSITION_TYPE)