From dc01c0e66d44118bec3f40beb4d2e8699a38176a Mon Sep 17 00:00:00 2001 From: Jamis Charles Date: Wed, 27 May 2015 11:37:57 -0700 Subject: [PATCH] Added challenge, keyParams and keyType on Chrome allowed some of these to be 'null' (allow `node.challenge` etc), but FF didn't work. This will tell React to use node.setAttribute() to set these values. Tested in FF, Chrome, Safari. isn't supported on IE. https://developer.mozilla.org/en-US/docs/Web/HTML/Element/keygen --- docs/docs/ref-04-tags-and-attributes.ko-KR.md | 10 +++++----- docs/docs/ref-04-tags-and-attributes.md | 10 +++++----- src/renderers/dom/shared/HTMLDOMPropertyConfig.js | 3 +++ 3 files changed, 13 insertions(+), 10 deletions(-) diff --git a/docs/docs/ref-04-tags-and-attributes.ko-KR.md b/docs/docs/ref-04-tags-and-attributes.ko-KR.md index 85b91976ee..6f1e1ad13b 100644 --- a/docs/docs/ref-04-tags-and-attributes.ko-KR.md +++ b/docs/docs/ref-04-tags-and-attributes.ko-KR.md @@ -53,13 +53,13 @@ React는 모든 `data-*`, `aria-*` 어트리뷰트와 밑에 있는 모든 어 ``` accept acceptCharset accessKey action allowFullScreen allowTransparency alt -async autoComplete autoFocus autoPlay cellPadding cellSpacing charSet checked -classID className colSpan cols content contentEditable contextMenu controls +async autoComplete autoFocus autoPlay cellPadding cellSpacing charSet challenge +checked classID className colSpan cols content contentEditable contextMenu controls coords crossOrigin data dateTime defer dir disabled download draggable encType form formAction formEncType formMethod formNoValidate formTarget frameBorder -headers height hidden high href hrefLang htmlFor httpEquiv icon id label lang -list loop low manifest marginHeight marginWidth max maxLength media mediaGroup -method min multiple muted name noValidate open optimum pattern placeholder +headers height hidden high href hrefLang htmlFor httpEquiv icon id keyParams keyType +label lang list loop low manifest marginHeight marginWidth max maxLength media +mediaGroup method min multiple muted name noValidate open optimum pattern placeholder poster preload radioGroup readOnly rel required role rowSpan rows sandbox scope scoped scrolling seamless selected shape size sizes span spellCheck src srcDoc srcSet start step style tabIndex target title type useMap value width wmode diff --git a/docs/docs/ref-04-tags-and-attributes.md b/docs/docs/ref-04-tags-and-attributes.md index 4fef3b1368..90836cdcf7 100644 --- a/docs/docs/ref-04-tags-and-attributes.md +++ b/docs/docs/ref-04-tags-and-attributes.md @@ -53,13 +53,13 @@ These standard attributes are supported: ``` accept acceptCharset accessKey action allowFullScreen allowTransparency alt -async autoComplete autoFocus autoPlay cellPadding cellSpacing charSet checked -classID className colSpan cols content contentEditable contextMenu controls +async autoComplete autoFocus autoPlay cellPadding cellSpacing charSet challenge +checked classID className colSpan cols content contentEditable contextMenu controls coords crossOrigin data dateTime defer dir disabled download draggable encType form formAction formEncType formMethod formNoValidate formTarget frameBorder -headers height hidden high href hrefLang htmlFor httpEquiv icon id label lang -list loop low manifest marginHeight marginWidth max maxLength media mediaGroup -method min multiple muted name noValidate open optimum pattern placeholder +headers height hidden high href hrefLang htmlFor httpEquiv icon id keyParams keyType +label lang list loop low manifest marginHeight marginWidth max maxLength media +mediaGroup method min multiple muted name noValidate open optimum pattern placeholder poster preload radioGroup readOnly rel required role rowSpan rows sandbox scope scoped scrolling seamless selected shape size sizes span spellCheck src srcDoc srcSet start step style tabIndex target title type useMap value width wmode diff --git a/src/renderers/dom/shared/HTMLDOMPropertyConfig.js b/src/renderers/dom/shared/HTMLDOMPropertyConfig.js index 280c2edddb..9df98bda67 100644 --- a/src/renderers/dom/shared/HTMLDOMPropertyConfig.js +++ b/src/renderers/dom/shared/HTMLDOMPropertyConfig.js @@ -61,6 +61,7 @@ var HTMLDOMPropertyConfig = { cellPadding: null, cellSpacing: null, charSet: MUST_USE_ATTRIBUTE, + challenge: MUST_USE_ATTRIBUTE, checked: MUST_USE_PROPERTY | HAS_BOOLEAN_VALUE, classID: MUST_USE_ATTRIBUTE, // To set className on SVG elements, it's necessary to use .setAttribute; @@ -102,6 +103,8 @@ var HTMLDOMPropertyConfig = { httpEquiv: null, icon: null, id: MUST_USE_PROPERTY, + keyParams: MUST_USE_ATTRIBUTE, + keyType: MUST_USE_ATTRIBUTE, label: null, lang: null, list: MUST_USE_ATTRIBUTE,