From 99cbaed83678f76e10f688bff6f976803ce57241 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Paul=20O=E2=80=99Shannessy?= Date: Mon, 16 Mar 2015 13:40:17 -0700 Subject: [PATCH] Ensure FullPageComponents are treated as DOM components We currently override a couple DOM components. We need to ensure everything we override is still treated as a DOM component, even if it has a composite component wrapper. --- .../dom/components/createFullPageComponent.js | 1 + src/test/__tests__/ReactTestUtils-test.js | 24 +++++++++++++++++++ 2 files changed, 25 insertions(+) diff --git a/src/browser/ui/dom/components/createFullPageComponent.js b/src/browser/ui/dom/components/createFullPageComponent.js index 5176cfe05e..ea4a692a77 100644 --- a/src/browser/ui/dom/components/createFullPageComponent.js +++ b/src/browser/ui/dom/components/createFullPageComponent.js @@ -33,6 +33,7 @@ function createFullPageComponent(tag) { var elementFactory = ReactElement.createFactory(tag); var FullPageComponent = ReactClass.createClass({ + tagName: tag.toUpperCase(), displayName: 'ReactFullPageComponent' + tag, componentWillUnmount: function() { diff --git a/src/test/__tests__/ReactTestUtils-test.js b/src/test/__tests__/ReactTestUtils-test.js index 53db1c856b..08789cda29 100644 --- a/src/test/__tests__/ReactTestUtils-test.js +++ b/src/test/__tests__/ReactTestUtils-test.js @@ -206,4 +206,28 @@ describe('ReactTestUtils', function() { expect(console.warn.calls.length).toBe(0); }); + + it('should support injected wrapper components as DOM components', function() { + var injectedDOMComponents = [ + 'button', + 'form', + 'iframe', + 'img', + 'input', + 'option', + 'select', + 'textarea', + 'html', + 'head', + 'body' + ]; + + injectedDOMComponents.forEach(function(type) { + var component = ReactTestUtils.renderIntoDocument( + React.createElement(type) + ); + expect(component.tagName).toBe(type.toUpperCase()); + expect(ReactTestUtils.isDOMComponent(component)).toBe(true); + }); + }); });