From d5e970b93fc0e5ab9d284c265b170eecee2ad0ad Mon Sep 17 00:00:00 2001 From: yungsters Date: Sun, 28 Jul 2013 01:05:13 -0700 Subject: [PATCH] Fix `Danger` test failures. The original tests were flawed because the `Danger` module exploits the fact that all React-generated markup has at least one attribute. This allows the module to extract node names from markup strings faster. However, the tests were passing in strings of markup with no attributes. Also, this fixes a test failure due to the test trying to set text content into a `` which is typically disallowed by browsers (and PhantomJS). This changes it to use `` instead. --- src/dom/__tests__/Danger-test.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/dom/__tests__/Danger-test.js b/src/dom/__tests__/Danger-test.js index 62bccb41d1..de1ca88b44 100644 --- a/src/dom/__tests__/Danger-test.js +++ b/src/dom/__tests__/Danger-test.js @@ -59,7 +59,7 @@ describe('Danger', function() { it('should render lists of markup with similar `nodeName`', function() { var renderedMarkup = Danger.dangerouslyRenderMarkup( - ['

1

', '

2

', '

3

'] + ['

1

', '

2

', '

3

'] ); expect(renderedMarkup.length).toBe(3); @@ -75,13 +75,13 @@ describe('Danger', function() { it('should render lists of markup with different `nodeName`', function() { var renderedMarkup = Danger.dangerouslyRenderMarkup( - ['

1

', '2', '

3

'] + ['

1

', '2', '

3

'] ); expect(renderedMarkup.length).toBe(3); expect(renderedMarkup[0].nodeName).toBe('P'); - expect(renderedMarkup[1].nodeName).toBe('TR'); + expect(renderedMarkup[1].nodeName).toBe('TD'); expect(renderedMarkup[2].nodeName).toBe('P'); expect(renderedMarkup[0].innerHTML).toBe('1');