From d3cbbe3b363e662fb46d97d6f5f87b4010395ba2 Mon Sep 17 00:00:00 2001 From: Andrew Clark Date: Tue, 21 Feb 2017 14:42:12 -0800 Subject: [PATCH] Add deprecation warning for assigning to this.state inside cWRP We'll remove support for this in a future release, though we'll likely still warn. --- .../__tests__/ReactCompositeComponentState-test.js | 8 ++++++++ src/renderers/shared/fiber/ReactFiberClassComponent.js | 9 +++++++++ .../shared/stack/reconciler/ReactCompositeComponent.js | 9 +++++++++ 3 files changed, 26 insertions(+) diff --git a/src/renderers/__tests__/ReactCompositeComponentState-test.js b/src/renderers/__tests__/ReactCompositeComponentState-test.js index 2d9351da1e..fba889a0b1 100644 --- a/src/renderers/__tests__/ReactCompositeComponentState-test.js +++ b/src/renderers/__tests__/ReactCompositeComponentState-test.js @@ -416,6 +416,8 @@ describe('ReactCompositeComponent-state', () => { }); it('should treat assigning to this.state inside cWRP as a replaceState, with a warning', () => { + spyOn(console, 'error'); + let ops = []; class Test extends React.Component { state = { step: 1, extra: true }; @@ -439,5 +441,11 @@ describe('ReactCompositeComponent-state', () => { ReactDOM.render(, container); expect(ops).toEqual(['step: 3, extra: false']); + expect(console.error.calls.count()).toEqual(1); + expect(console.error.calls.argsFor(0)[0]).toEqual( + 'Warning: Test.componentWillReceiveProps(): Assigning directly to ' + + 'this.state is deprecated (except inside a component\'s constructor). ' + + 'Use setState instead.' + ); }); }); diff --git a/src/renderers/shared/fiber/ReactFiberClassComponent.js b/src/renderers/shared/fiber/ReactFiberClassComponent.js index 13b6d78010..eae8a56a21 100644 --- a/src/renderers/shared/fiber/ReactFiberClassComponent.js +++ b/src/renderers/shared/fiber/ReactFiberClassComponent.js @@ -410,6 +410,15 @@ module.exports = function( instance.componentWillReceiveProps(newProps, newContext); if (instance.state !== workInProgress.memoizedState) { + if (__DEV__) { + warning( + false, + '%s.componentWillReceiveProps(): Assigning directly to ' + + 'this.state is deprecated (except inside a component\'s ' + + 'constructor). Use setState instead.', + getComponentName(workInProgress) + ); + } updater.enqueueReplaceState(instance, instance.state, null); } } diff --git a/src/renderers/shared/stack/reconciler/ReactCompositeComponent.js b/src/renderers/shared/stack/reconciler/ReactCompositeComponent.js index f1cc7086f4..9a572a8f6f 100644 --- a/src/renderers/shared/stack/reconciler/ReactCompositeComponent.js +++ b/src/renderers/shared/stack/reconciler/ReactCompositeComponent.js @@ -864,6 +864,15 @@ var ReactCompositeComponent = { if (beforeState !== afterState) { inst.state = beforeState; inst.updater.enqueueReplaceState(inst, afterState); + if (__DEV__) { + warning( + false, + '%s.componentWillReceiveProps(): Assigning directly to ' + + 'this.state is deprecated (except inside a component\'s ' + + 'constructor). Use setState instead.', + this.getName() || 'ReactCompositeComponent' + ); + } } }