From d1c42d2f1ec706c2d6f424f30bd6ae430e665787 Mon Sep 17 00:00:00 2001 From: Brandon Dail Date: Mon, 20 Aug 2018 04:26:06 -0700 Subject: [PATCH] Remove addEventListener check in isEventSupported (#13435) * Remove addEventListener check in isEventSupported All browsers we support also support addEventListener, so this check is unncessary * Remove capture argument from isEventSupported --- packages/react-dom/src/events/ReactBrowserEventEmitter.js | 2 +- packages/react-dom/src/events/isEventSupported.js | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/packages/react-dom/src/events/ReactBrowserEventEmitter.js b/packages/react-dom/src/events/ReactBrowserEventEmitter.js index cd9df43b7c..a89dd6bbfe 100644 --- a/packages/react-dom/src/events/ReactBrowserEventEmitter.js +++ b/packages/react-dom/src/events/ReactBrowserEventEmitter.js @@ -146,7 +146,7 @@ export function listenTo( break; case TOP_CANCEL: case TOP_CLOSE: - if (isEventSupported(getRawEventName(dependency), true)) { + if (isEventSupported(getRawEventName(dependency))) { trapCapturedEvent(dependency, mountAt); } break; diff --git a/packages/react-dom/src/events/isEventSupported.js b/packages/react-dom/src/events/isEventSupported.js index f87ecba43a..02ee2b4af4 100644 --- a/packages/react-dom/src/events/isEventSupported.js +++ b/packages/react-dom/src/events/isEventSupported.js @@ -16,13 +16,12 @@ import {canUseDOM} from 'shared/ExecutionEnvironment'; * Borrows from Modernizr. * * @param {string} eventNameSuffix Event name, e.g. "click". - * @param {?boolean} capture Check if the capture phase is supported. * @return {boolean} True if the event is supported. * @internal * @license Modernizr 3.0.0pre (Custom Build) | MIT */ -function isEventSupported(eventNameSuffix, capture) { - if (!canUseDOM || (capture && !('addEventListener' in document))) { +function isEventSupported(eventNameSuffix) { + if (!canUseDOM) { return false; }