Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

[eslint] Enforce generic array type syntax

Browse Source 
Fix and enforce generic array type syntax
This commit is contained in:
Sathya Gunasekaran
2024-04-02 15:31:25 +01:00
parent 1de6c5aea2
commit cd3f56bb18
15 changed files with 53 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiler/packages/babel-plugin-react-forget/scripts/jest/makeTransform.ts
+16 -8
View File
@@ -43,8 +43,10 @@ module.exports = (useForget: boolean) => {
? [
ReactForgetFunctionTransform,
{
// Jest hashes the babel config as a cache breaker.
// (see https://github.com/jestjs/jest/blob/v29.6.2/packages/babel-jest/src/index.ts#L84)
/*
* Jest hashes the babel config as a cache breaker.
* (see https://github.com/jestjs/jest/blob/v29.6.2/packages/babel-jest/src/index.ts#L84)
*/
compilerCacheKey: execSync(
"yarn --silent --cwd ../.. hash packages/babel-plugin-react-forget/dist"
).toString(),
@@ -70,8 +72,10 @@ module.exports = (useForget: boolean) => {
) {
const arg = path.node.arguments[0];
if (arg.type === "StringLiteral") {
// The compiler adds requires of "React", which is expected to be a wrapper
// around the "react" package. For tests, we just rewrite the require.
/*
* The compiler adds requires of "React", which is expected to be a wrapper
* around the "react" package. For tests, we just rewrite the require.
*/
if (arg.value === "React") {
arg.value = "react";
}
@@ -90,8 +94,10 @@ module.exports = (useForget: boolean) => {
esmodules: true,
},
} as any);
// typecast needed as DefinitelyTyped does not have updated Babel configs types yet
// (missing passPerPreset and targets).
/*
* typecast needed as DefinitelyTyped does not have updated Babel configs types yet
* (missing passPerPreset and targets).
*/
}
return {
@@ -104,8 +110,10 @@ function isReactComponentLike(fn: NodePath<FunctionDeclaration>): boolean {
let isReactComponent = false;
let hasNoUseForgetDirective = false;
// React components start with an upper case letter,
// React hooks start with `use`
/*
* React components start with an upper case letter,
* React hooks start with `use`
*/
if (
fn.node.id == null ||
(fn.node.id.name[0].toUpperCase() !== fn.node.id.name[0] &&
compiler/packages/babel-plugin-react-forget/scripts/jest/setupEnvE2E.js
+5 -3
View File
@@ -7,8 +7,10 @@
const React = require("react");
// Our e2e babel transform currently only compiles functions, not programs.
// As a result, our e2e transpiled code does not contain an import for `useMemoCache`
// This is a hack.
/*
* Our e2e babel transform currently only compiles functions, not programs.
* As a result, our e2e transpiled code does not contain an import for `useMemoCache`
* This is a hack.
*/
React.useMemoCache = React.unstable_useMemoCache;
globalThis.useMemoCache = React.unstable_useMemoCache;
compiler/packages/babel-plugin-react-forget/scripts/prettier.js
+4 -2
View File
@@ -7,8 +7,10 @@
"use strict";
// Based on similar script in React
// https://github.com/facebook/react/blob/main/scripts/prettier/index.js
/*
* Based on similar script in React
* https://github.com/facebook/react/blob/main/scripts/prettier/index.js
*/
const chalk = require("chalk");
const glob = require("glob");