From c80cd8ee27d24bb5b9a6136ede6875d13b9f1ba4 Mon Sep 17 00:00:00 2001 From: Dan Abramov Date: Wed, 1 Apr 2020 22:44:59 +0100 Subject: [PATCH] Revert "Fix email cursor jump (#18379)" (#18459) * Revert "Fix email cursor jump (#18379)" This reverts commit 9b88b78b3d61e8fe81968d59b74592d5a53540b7. * Leave fixtures be --- packages/react-dom/src/client/ReactDOMInput.js | 4 ++-- packages/react-dom/src/events/ChangeEventPlugin.js | 8 ++------ 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/packages/react-dom/src/client/ReactDOMInput.js b/packages/react-dom/src/client/ReactDOMInput.js index 77b908112a..884c2ad9df 100644 --- a/packages/react-dom/src/client/ReactDOMInput.js +++ b/packages/react-dom/src/client/ReactDOMInput.js @@ -410,8 +410,8 @@ export function setDefaultValue( value: *, ) { if ( - // Focused number and email inputs synchronize on blur. See ChangeEventPlugin.js - (type !== 'number' && type !== 'email') || + // Focused number inputs synchronize on blur. See ChangeEventPlugin.js + type !== 'number' || node.ownerDocument.activeElement !== node ) { if (value == null) { diff --git a/packages/react-dom/src/events/ChangeEventPlugin.js b/packages/react-dom/src/events/ChangeEventPlugin.js index d1c8259cbb..372af140fb 100644 --- a/packages/react-dom/src/events/ChangeEventPlugin.js +++ b/packages/react-dom/src/events/ChangeEventPlugin.js @@ -236,17 +236,13 @@ function getTargetInstForInputOrChangeEvent(topLevelType, targetInst) { function handleControlledInputBlur(node) { const state = node._wrapperState; - if ( - !state || - !state.controlled || - (node.type !== 'number' && node.type !== 'email') - ) { + if (!state || !state.controlled || node.type !== 'number') { return; } if (!disableInputAttributeSyncing) { // If controlled, assign the value attribute to the current value on blur - setDefaultValue(node, node.type, node.value); + setDefaultValue(node, 'number', node.value); } }