mirror of
https://github.com/facebook/react.git
synced 2025-11-01 09:12:30 +00:00
Address review
This commit is contained in:
1 parent
6538e7141a
commit
c6ee445ea9
4 files changed
+10
-10
No files matched your search
@@ -86,17 +86,17 @@ export default function ElementView({ index, style, data }: Props) {
|
||||
[id, selectElementByID]
|
||||
);
|
||||
|
||||
const rendererID = store.getRendererIDForElement(element.id) || null;
|
||||
const rendererID = store.getRendererIDForElement(element.id);
|
||||
// Individual elements don't have a corresponding leave handler.
|
||||
// Instead, it's implemented on the tree level.
|
||||
const handleMouseEnter = useCallback(() => {
|
||||
if (rendererID !== null) {
|
||||
bridge.send('highlightElementInDOM', {
|
||||
displayName: element.displayName,
|
||||
hideAfterTimeout: false,
|
||||
id: element.id,
|
||||
rendererID,
|
||||
scrollIntoView: false,
|
||||
isSticky: true,
|
||||
});
|
||||
}
|
||||
}, [bridge, element, rendererID]);
|
||||
|
||||
@@ -45,10 +45,10 @@ export default function SelectedElement(_: Props) {
|
||||
if (rendererID !== null) {
|
||||
bridge.send('highlightElementInDOM', {
|
||||
displayName: element.displayName,
|
||||
hideAfterTimeout: true,
|
||||
id: selectedElementID,
|
||||
rendererID,
|
||||
scrollIntoView: true,
|
||||
isSticky: false,
|
||||
});
|
||||
}
|
||||
}
|
||||
@@ -271,7 +271,7 @@ function useInspectedElement(id: number | null): InspectedElement | null {
|
||||
return () => {};
|
||||
}
|
||||
|
||||
const rendererID = store.getRendererIDForElement(id) || null;
|
||||
const rendererID = store.getRendererIDForElement(id);
|
||||
|
||||
// Update the $r variable.
|
||||
bridge.send('selectElement', { id, rendererID });
|
||||
|
||||
Reference in new issue
Block a user