From c416fb16ca427fd022e33372acd1e1f756f02c70 Mon Sep 17 00:00:00 2001
From: Lauren Tan <poteto@users.noreply.github.com>
Date: Thu, 15 Jun 2023 12:52:56 -0400
Subject: [PATCH] [make-read-only] Make tsconfig more consistent with other
 pkgs

---
 .../makeReadOnly-test.ts}                     |  2 +-
 .../make-read-only-util/tsconfig.json         | 29 ++++++++++---------
 2 files changed, 17 insertions(+), 14 deletions(-)
 rename compiler/forget/packages/make-read-only-util/src/{makeReadOnly.test.ts => __tests__/makeReadOnly-test.ts} (99%)

diff --git a/compiler/forget/packages/make-read-only-util/src/makeReadOnly.test.ts b/compiler/forget/packages/make-read-only-util/src/__tests__/makeReadOnly-test.ts
similarity index 99%
rename from compiler/forget/packages/make-read-only-util/src/makeReadOnly.test.ts
rename to compiler/forget/packages/make-read-only-util/src/__tests__/makeReadOnly-test.ts
index 4ac9c7e3d3..f0ee72eb7c 100644
--- a/compiler/forget/packages/make-read-only-util/src/makeReadOnly.test.ts
+++ b/compiler/forget/packages/make-read-only-util/src/__tests__/makeReadOnly-test.ts
@@ -5,7 +5,7 @@
  * LICENSE file in the root directory of this source tree.
  */
 
-import buildMakeReadOnly from "./makeReadOnly";
+import buildMakeReadOnly from "../makeReadOnly";
 
 describe("makeReadOnly", () => {
   let logger: jest.Func;
diff --git a/compiler/forget/packages/make-read-only-util/tsconfig.json b/compiler/forget/packages/make-read-only-util/tsconfig.json
index 1d62f60e23..4420706d67 100644
--- a/compiler/forget/packages/make-read-only-util/tsconfig.json
+++ b/compiler/forget/packages/make-read-only-util/tsconfig.json
@@ -1,17 +1,20 @@
 {
+  "extends": "@tsconfig/node16-strictest/tsconfig.json",
   "compilerOptions": {
-    "target": "ESNext",
-    "allowJs": true,
-    "strict": true,
-    "forceConsistentCasingInFileNames": true,
-    "esModuleInterop": true,
-    "moduleResolution": "node",
-    "resolveJsonModule": true,
-    "isolatedModules": false,
-    "jsx": "preserve",
-    "incremental": true,
-    "outDir": "dist"
+    "declaration": true,
+    "outDir": "dist",
+    "jsx": "react-jsxdev",
+
+    // weaken strictness from preset
+    "importsNotUsedAsValues": "remove",
+    "noUncheckedIndexedAccess": false,
+    "noUnusedParameters": false,
+    "useUnknownInCatchVariables": false,
+    "target": "ES2015",
+    // ideally turn off only during dev, or on a per-file basis
+    "noUnusedLocals": false,
+    "sourceMap": true
   },
-  "include": ["**/*.ts", "**/*.tsx"],
-  "exclude": ["node_modules"]
+  "exclude": ["node_modules"],
+  "include": ["src/**/*.ts"]
 }