From c308cb590598b61a7fc1766e15edf454d758d226 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sebastian=20Markb=C3=A5ge?= Date: Tue, 4 Nov 2025 23:23:25 -0500 Subject: [PATCH] Disable enablePostpone flag in experimental (#31042) I don't think we're ready to land this yet since we're using it to run other experiments and our tests. I'm opening this PR to indicate intent to disable and to ensure tests in other combinations still work. Such as enableHalt without enablePostpone. I think we'll also need to rewrite some tests that depend on enablePostpone to preserve some coverage. The conclusion after this experiment is that try/catch around these are too likely to block these signals and consider them error. Throwing works for Hooks and `use()` because the lint rule can ensure that they're not wrapped in try/catch. Throwing in arbitrary functions not quite ecosystem compatible. It's also why there's `use()` and not just throwing a Promise. This might also affect the Catch proposal. The "prerender" for SSR that's supporting "Partial Prerendering" is still there. This just disables the `React.postpone()` API for creating the holes. --- .../src/__tests__/ReactDOMFizzStatic-test.js | 66 ------------------- .../react/index.experimental.development.js | 1 - packages/react/index.experimental.js | 1 - packages/react/src/ReactClient.js | 2 - .../ReactServer.experimental.development.js | 2 - .../react/src/ReactServer.experimental.js | 2 - packages/shared/ReactFeatureFlags.js | 2 +- 7 files changed, 1 insertion(+), 75 deletions(-) diff --git a/packages/react-dom/src/__tests__/ReactDOMFizzStatic-test.js b/packages/react-dom/src/__tests__/ReactDOMFizzStatic-test.js index 6501202342..a4ac87c92c 100644 --- a/packages/react-dom/src/__tests__/ReactDOMFizzStatic-test.js +++ b/packages/react-dom/src/__tests__/ReactDOMFizzStatic-test.js @@ -400,72 +400,6 @@ describe('ReactDOMFizzStatic', () => { ); }); - // @gate enablePostpone - it('does not fatally error when aborting with a postpone during a prerender', async () => { - let postponedValue; - try { - React.unstable_postpone('aborting with postpone'); - } catch (e) { - postponedValue = e; - } - - const controller = new AbortController(); - const infinitePromise = new Promise(() => {}); - function App() { - React.use(infinitePromise); - return
aborted
; - } - - const errors = []; - const pendingResult = ReactDOMFizzStatic.prerenderToNodeStream(, { - onError: error => { - errors.push(error); - }, - signal: controller.signal, - }); - pendingResult.catch(() => {}); - - await Promise.resolve(); - controller.abort(postponedValue); - - const result = await pendingResult; - - await act(async () => { - result.prelude.pipe(writable); - }); - expect(getVisibleChildren(container)).toEqual(undefined); - expect(errors).toEqual([]); - }); - - // @gate enablePostpone - it('does not fatally error when aborting with a postpone during a prerender from within', async () => { - let postponedValue; - try { - React.unstable_postpone('aborting with postpone'); - } catch (e) { - postponedValue = e; - } - - const controller = new AbortController(); - function App() { - controller.abort(postponedValue); - return
aborted
; - } - - const errors = []; - const result = await ReactDOMFizzStatic.prerenderToNodeStream(, { - onError: error => { - errors.push(error); - }, - signal: controller.signal, - }); - await act(async () => { - result.prelude.pipe(writable); - }); - expect(getVisibleChildren(container)).toEqual(undefined); - expect(errors).toEqual([]); - }); - // @gate enableHalt it('will halt a prerender when aborting with an error during a render', async () => { const controller = new AbortController(); diff --git a/packages/react/index.experimental.development.js b/packages/react/index.experimental.development.js index b237449307..9b0e301a8c 100644 --- a/packages/react/index.experimental.development.js +++ b/packages/react/index.experimental.development.js @@ -30,7 +30,6 @@ export { cacheSignal, startTransition, Activity, - unstable_postpone, unstable_getCacheForType, unstable_SuspenseList, ViewTransition, diff --git a/packages/react/index.experimental.js b/packages/react/index.experimental.js index 37800ede07..0145e9137e 100644 --- a/packages/react/index.experimental.js +++ b/packages/react/index.experimental.js @@ -31,7 +31,6 @@ export { startTransition, Activity, Activity as unstable_Activity, - unstable_postpone, unstable_getCacheForType, unstable_SuspenseList, ViewTransition, diff --git a/packages/react/src/ReactClient.js b/packages/react/src/ReactClient.js index 9f7c5dce36..d881030b7d 100644 --- a/packages/react/src/ReactClient.js +++ b/packages/react/src/ReactClient.js @@ -34,7 +34,6 @@ import {lazy} from './ReactLazy'; import {forwardRef} from './ReactForwardRef'; import {memo} from './ReactMemo'; import {cache, cacheSignal} from './ReactCacheClient'; -import {postpone} from './ReactPostpone'; import { getCacheForType, useCallback, @@ -84,7 +83,6 @@ export { memo, cache, cacheSignal, - postpone as unstable_postpone, useCallback, useContext, useEffect, diff --git a/packages/react/src/ReactServer.experimental.development.js b/packages/react/src/ReactServer.experimental.development.js index df8b3d79b3..10d0123843 100644 --- a/packages/react/src/ReactServer.experimental.development.js +++ b/packages/react/src/ReactServer.experimental.development.js @@ -38,7 +38,6 @@ import {lazy} from './ReactLazy'; import {memo} from './ReactMemo'; import {cache, cacheSignal} from './ReactCacheServer'; import {startTransition} from './ReactStartTransition'; -import {postpone} from './ReactPostpone'; import {captureOwnerStack} from './ReactOwnerStack'; import version from 'shared/ReactVersion'; @@ -76,7 +75,6 @@ export { cacheSignal, startTransition, getCacheForType as unstable_getCacheForType, - postpone as unstable_postpone, useId, useCallback, useDebugValue, diff --git a/packages/react/src/ReactServer.experimental.js b/packages/react/src/ReactServer.experimental.js index 06c0a9bf89..9fc2634131 100644 --- a/packages/react/src/ReactServer.experimental.js +++ b/packages/react/src/ReactServer.experimental.js @@ -38,7 +38,6 @@ import {lazy} from './ReactLazy'; import {memo} from './ReactMemo'; import {cache, cacheSignal} from './ReactCacheServer'; import {startTransition} from './ReactStartTransition'; -import {postpone} from './ReactPostpone'; import version from 'shared/ReactVersion'; const Children = { @@ -75,7 +74,6 @@ export { cacheSignal, startTransition, getCacheForType as unstable_getCacheForType, - postpone as unstable_postpone, useId, useCallback, useDebugValue, diff --git a/packages/shared/ReactFeatureFlags.js b/packages/shared/ReactFeatureFlags.js index 6d45a30718..1881d3fc28 100644 --- a/packages/shared/ReactFeatureFlags.js +++ b/packages/shared/ReactFeatureFlags.js @@ -80,7 +80,7 @@ export const enableAsyncIterableChildren = __EXPERIMENTAL__; export const enableTaint = __EXPERIMENTAL__; -export const enablePostpone = __EXPERIMENTAL__; +export const enablePostpone: boolean = false; // Probably won't ship in this form. export const enableHalt: boolean = true;