From bf5dfc87dc2a422122b0addc43cabda4d3cf4c98 Mon Sep 17 00:00:00 2001 From: Ian Obermiller Date: Mon, 19 May 2014 13:17:14 -0700 Subject: [PATCH] Error in extractEvents If the event is on the window object, topScroll, for instance, the topLevelTarget will not have getAttribute defined. Restore the previous `|| !topLevelTarget.attributes` check to avoid an error on every scroll. --- src/browser/eventPlugins/AnalyticsEventPluginFactory.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/browser/eventPlugins/AnalyticsEventPluginFactory.js b/src/browser/eventPlugins/AnalyticsEventPluginFactory.js index 3bd5b7a3b8..4528cb9462 100644 --- a/src/browser/eventPlugins/AnalyticsEventPluginFactory.js +++ b/src/browser/eventPlugins/AnalyticsEventPluginFactory.js @@ -149,7 +149,7 @@ function extractEvents( topLevelTargetID, nativeEvent) { var currentEvent = topLevelTypesToAnalyticsEvent[topLevelType]; - if (!currentEvent || !topLevelTarget) { + if (!currentEvent || !topLevelTarget || !topLevelTarget.attributes) { return null; }