From bb149c817083d3b2d6473c2e8f4f89b14886b790 Mon Sep 17 00:00:00 2001 From: Vincent Taing Date: Mon, 6 Mar 2017 15:20:12 -0800 Subject: [PATCH] Fix redundant null type coercion (#9114) --- .../shared/stack/reconciler/ReactUpdateQueue.js | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/renderers/shared/stack/reconciler/ReactUpdateQueue.js b/src/renderers/shared/stack/reconciler/ReactUpdateQueue.js index 19aee0d985..8e77b3346e 100644 --- a/src/renderers/shared/stack/reconciler/ReactUpdateQueue.js +++ b/src/renderers/shared/stack/reconciler/ReactUpdateQueue.js @@ -134,8 +134,8 @@ var ReactUpdateQueue = { return; } - if (callback) { - callback = callback === undefined ? null : callback; + callback = callback === undefined ? null : callback; + if (callback !== null) { if (__DEV__) { warnOnInvalidCallback(callback, callerName); } @@ -174,8 +174,8 @@ var ReactUpdateQueue = { internalInstance._pendingStateQueue = [completeState]; internalInstance._pendingReplaceState = true; - if (callback) { - callback = callback === undefined ? null : callback; + callback = callback === undefined ? null : callback; + if (callback !== null) { if (__DEV__) { warnOnInvalidCallback(callback, callerName); } @@ -222,8 +222,8 @@ var ReactUpdateQueue = { (internalInstance._pendingStateQueue = []); queue.push(partialState); - if (callback) { - callback = callback === undefined ? null : callback; + callback = callback === undefined ? null : callback; + if (callback !== null) { if (__DEV__) { warnOnInvalidCallback(callback, callerName); }