From b8245de5a116f7c704af70dcf475bca37170bebc Mon Sep 17 00:00:00 2001 From: Dan Date: Thu, 4 Apr 2019 21:53:57 +0100 Subject: [PATCH] Nits --- shells/dev/app/index.js | 1 - src/backend/renderer.js | 6 +++--- src/devtools/views/Components/SelectedElement.js | 4 ++-- src/devtools/views/Components/types.js | 2 +- 4 files changed, 6 insertions(+), 7 deletions(-) diff --git a/shells/dev/app/index.js b/shells/dev/app/index.js index e731e64470..1daae45595 100644 --- a/shells/dev/app/index.js +++ b/shells/dev/app/index.js @@ -32,7 +32,6 @@ function mountTestApp() { mountHelper(ElementTypes); mountHelper(EditableProps); mountHelper(DeeplyNestedComponents); - mountHelper(SuspenseTree); } function unmountTestApp() { diff --git a/src/backend/renderer.js b/src/backend/renderer.js index c149a2541e..29caf523d7 100644 --- a/src/backend/renderer.js +++ b/src/backend/renderer.js @@ -226,7 +226,7 @@ export function attach( setSuspenseHandler, scheduleUpdate, } = renderer; - const supportsEditingSuspense = + const supportsTogglingSuspense = typeof setSuspenseHandler === 'function' && typeof scheduleUpdate === 'function'; @@ -1443,8 +1443,8 @@ export function attach( // Does the current renderer support editable function props? canEditFunctionProps: typeof overrideProps === 'function', - canEditSuspense: - supportsEditingSuspense && + canToggleSuspense: + supportsTogglingSuspense && // If it's showing the real content, we can always flip fallback. (!isTimedOutSuspense || // If it's showing fallback because we previously forced it to, diff --git a/src/devtools/views/Components/SelectedElement.js b/src/devtools/views/Components/SelectedElement.js index 6f4958040b..4f6295bce9 100644 --- a/src/devtools/views/Components/SelectedElement.js +++ b/src/devtools/views/Components/SelectedElement.js @@ -126,7 +126,7 @@ function InspectedElementView({ const { canEditFunctionProps, canEditHooks, - canEditSuspense, + canToggleSuspense, context, hooks, owners, @@ -165,7 +165,7 @@ function InspectedElementView({ const rendererID = store.getRendererIDForElement(id); bridge.send('overrideProps', { id, path, rendererID, value }); }; - } else if (type === ElementTypeSuspense && canEditSuspense) { + } else if (type === ElementTypeSuspense && canToggleSuspense) { overrideSuspenseFn = (path: Array, value: boolean) => { if (path.length !== 1 && path !== IS_SUSPENDED) { throw new Error('Unexpected path.'); diff --git a/src/devtools/views/Components/types.js b/src/devtools/views/Components/types.js index b26fb4edc1..00d5a45844 100644 --- a/src/devtools/views/Components/types.js +++ b/src/devtools/views/Components/types.js @@ -42,7 +42,7 @@ export type InspectedElement = {| canEditFunctionProps: boolean, // Is this Suspense, and can its value be overriden now? - canEditSuspense: boolean, + canToggleSuspense: boolean, // Can view component source location. canViewSource: boolean,