From a601c5cc81e8bea39010a956800191971f67420c Mon Sep 17 00:00:00 2001 From: Alexander Solovyov Date: Fri, 11 Oct 2013 13:32:22 +0300 Subject: [PATCH 1/4] svg properties -> attributes --- src/dom/DefaultDOMPropertyConfig.js | 52 ++++++++++++++--------------- 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/src/dom/DefaultDOMPropertyConfig.js b/src/dom/DefaultDOMPropertyConfig.js index 5c9f16b3c0..a9b62afaa2 100644 --- a/src/dom/DefaultDOMPropertyConfig.js +++ b/src/dom/DefaultDOMPropertyConfig.js @@ -110,32 +110,32 @@ var DefaultDOMPropertyConfig = { /** * SVG Properties */ - cx: MUST_USE_PROPERTY, - cy: MUST_USE_PROPERTY, - d: MUST_USE_PROPERTY, - fill: MUST_USE_PROPERTY, - fx: MUST_USE_PROPERTY, - fy: MUST_USE_PROPERTY, - points: MUST_USE_PROPERTY, - r: MUST_USE_PROPERTY, - stroke: MUST_USE_PROPERTY, - strokeLinecap: MUST_USE_PROPERTY, - strokeWidth: MUST_USE_PROPERTY, - transform: MUST_USE_PROPERTY, - x: MUST_USE_PROPERTY, - x1: MUST_USE_PROPERTY, - x2: MUST_USE_PROPERTY, - version: MUST_USE_PROPERTY, - viewBox: MUST_USE_PROPERTY, - y: MUST_USE_PROPERTY, - y1: MUST_USE_PROPERTY, - y2: MUST_USE_PROPERTY, - spreadMethod: MUST_USE_PROPERTY, - offset: MUST_USE_PROPERTY, - stopColor: MUST_USE_PROPERTY, - stopOpacity: MUST_USE_PROPERTY, - gradientUnits: MUST_USE_PROPERTY, - gradientTransform: MUST_USE_PROPERTY + cx: MUST_USE_ATTRIBUTE, + cy: MUST_USE_ATTRIBUTE, + d: MUST_USE_ATTRIBUTE, + fill: MUST_USE_ATTRIBUTE, + fx: MUST_USE_ATTRIBUTE, + fy: MUST_USE_ATTRIBUTE, + points: MUST_USE_ATTRIBUTE, + r: MUST_USE_ATTRIBUTE, + stroke: MUST_USE_ATTRIBUTE, + strokeLinecap: MUST_USE_ATTRIBUTE, + strokeWidth: MUST_USE_ATTRIBUTE, + transform: MUST_USE_ATTRIBUTE, + x: MUST_USE_ATTRIBUTE, + x1: MUST_USE_ATTRIBUTE, + x2: MUST_USE_ATTRIBUTE, + version: MUST_USE_ATTRIBUTE, + viewBox: MUST_USE_ATTRIBUTE, + y: MUST_USE_ATTRIBUTE, + y1: MUST_USE_ATTRIBUTE, + y2: MUST_USE_ATTRIBUTE, + spreadMethod: MUST_USE_ATTRIBUTE, + offset: MUST_USE_ATTRIBUTE, + stopColor: MUST_USE_ATTRIBUTE, + stopOpacity: MUST_USE_ATTRIBUTE, + gradientUnits: MUST_USE_ATTRIBUTE, + gradientTransform: MUST_USE_ATTRIBUTE }, DOMAttributeNames: { className: 'class', From 6d300527c86c6cf5a0d3cb033c4d4b875c65bec5 Mon Sep 17 00:00:00 2001 From: Alexander Solovyov Date: Fri, 11 Oct 2013 13:42:10 +0300 Subject: [PATCH 2/4] svg: rx/ry for rounded corners --- src/dom/DefaultDOMPropertyConfig.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/dom/DefaultDOMPropertyConfig.js b/src/dom/DefaultDOMPropertyConfig.js index a9b62afaa2..583967246b 100644 --- a/src/dom/DefaultDOMPropertyConfig.js +++ b/src/dom/DefaultDOMPropertyConfig.js @@ -112,6 +112,8 @@ var DefaultDOMPropertyConfig = { */ cx: MUST_USE_ATTRIBUTE, cy: MUST_USE_ATTRIBUTE, + rx: MUST_USE_ATTRIBUTE, + ry: MUST_USE_ATTRIBUTE, d: MUST_USE_ATTRIBUTE, fill: MUST_USE_ATTRIBUTE, fx: MUST_USE_ATTRIBUTE, From aa38ffc22d952e404a4ec6e0e59ad447a4a30baa Mon Sep 17 00:00:00 2001 From: Alexander Solovyov Date: Fri, 11 Oct 2013 15:48:17 +0300 Subject: [PATCH 3/4] svg attributes properly cased when assigned by react --- src/dom/DefaultDOMPropertyConfig.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/dom/DefaultDOMPropertyConfig.js b/src/dom/DefaultDOMPropertyConfig.js index 583967246b..60a07a4f34 100644 --- a/src/dom/DefaultDOMPropertyConfig.js +++ b/src/dom/DefaultDOMPropertyConfig.js @@ -145,7 +145,11 @@ var DefaultDOMPropertyConfig = { strokeLinecap: 'stroke-linecap', strokeWidth: 'stroke-width', stopColor: 'stop-color', - stopOpacity: 'stop-opacity' + stopOpacity: 'stop-opacity', + viewBox: 'viewBox', + spreadMethod: 'spreadMethod', + gradientUnits: 'gradientUnits', + gradientTransform: 'gradientTransform' }, DOMPropertyNames: { autoCapitalize: 'autocapitalize', From 3a5a82fd1893c59605fdc6f98be091dc7dd6232b Mon Sep 17 00:00:00 2001 From: Alexander Solovyov Date: Mon, 14 Oct 2013 20:45:00 +0300 Subject: [PATCH 4/4] DefaultDOMPropertyConfig: sort properties alphabetically --- src/dom/DefaultDOMPropertyConfig.js | 42 ++++++++++++++--------------- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/src/dom/DefaultDOMPropertyConfig.js b/src/dom/DefaultDOMPropertyConfig.js index 60a07a4f34..09175c7ccd 100644 --- a/src/dom/DefaultDOMPropertyConfig.js +++ b/src/dom/DefaultDOMPropertyConfig.js @@ -33,8 +33,8 @@ var DefaultDOMPropertyConfig = { /** * Standard Properties */ - accessKey: null, accept: null, + accessKey: null, action: null, allowFullScreen: MUST_USE_ATTRIBUTE | HAS_BOOLEAN_VALUE, allowTransparency: MUST_USE_ATTRIBUTE, @@ -77,12 +77,12 @@ var DefaultDOMPropertyConfig = { multiple: MUST_USE_PROPERTY | HAS_BOOLEAN_VALUE, name: null, pattern: null, + placeholder: null, poster: null, preload: null, - placeholder: null, radioGroup: null, - rel: null, readOnly: MUST_USE_PROPERTY | HAS_BOOLEAN_VALUE, + rel: null, required: HAS_BOOLEAN_VALUE, role: MUST_USE_ATTRIBUTE, rowSpan: null, @@ -112,44 +112,44 @@ var DefaultDOMPropertyConfig = { */ cx: MUST_USE_ATTRIBUTE, cy: MUST_USE_ATTRIBUTE, - rx: MUST_USE_ATTRIBUTE, - ry: MUST_USE_ATTRIBUTE, d: MUST_USE_ATTRIBUTE, fill: MUST_USE_ATTRIBUTE, fx: MUST_USE_ATTRIBUTE, fy: MUST_USE_ATTRIBUTE, + gradientTransform: MUST_USE_ATTRIBUTE, + gradientUnits: MUST_USE_ATTRIBUTE, + offset: MUST_USE_ATTRIBUTE, points: MUST_USE_ATTRIBUTE, r: MUST_USE_ATTRIBUTE, + rx: MUST_USE_ATTRIBUTE, + ry: MUST_USE_ATTRIBUTE, + spreadMethod: MUST_USE_ATTRIBUTE, + stopColor: MUST_USE_ATTRIBUTE, + stopOpacity: MUST_USE_ATTRIBUTE, stroke: MUST_USE_ATTRIBUTE, strokeLinecap: MUST_USE_ATTRIBUTE, strokeWidth: MUST_USE_ATTRIBUTE, transform: MUST_USE_ATTRIBUTE, - x: MUST_USE_ATTRIBUTE, - x1: MUST_USE_ATTRIBUTE, - x2: MUST_USE_ATTRIBUTE, version: MUST_USE_ATTRIBUTE, viewBox: MUST_USE_ATTRIBUTE, - y: MUST_USE_ATTRIBUTE, + x1: MUST_USE_ATTRIBUTE, + x2: MUST_USE_ATTRIBUTE, + x: MUST_USE_ATTRIBUTE, y1: MUST_USE_ATTRIBUTE, y2: MUST_USE_ATTRIBUTE, - spreadMethod: MUST_USE_ATTRIBUTE, - offset: MUST_USE_ATTRIBUTE, - stopColor: MUST_USE_ATTRIBUTE, - stopOpacity: MUST_USE_ATTRIBUTE, - gradientUnits: MUST_USE_ATTRIBUTE, - gradientTransform: MUST_USE_ATTRIBUTE + y: MUST_USE_ATTRIBUTE }, DOMAttributeNames: { className: 'class', + gradientTransform: 'gradientTransform', + gradientUnits: 'gradientUnits', htmlFor: 'for', - strokeLinecap: 'stroke-linecap', - strokeWidth: 'stroke-width', + spreadMethod: 'spreadMethod', stopColor: 'stop-color', stopOpacity: 'stop-opacity', - viewBox: 'viewBox', - spreadMethod: 'spreadMethod', - gradientUnits: 'gradientUnits', - gradientTransform: 'gradientTransform' + strokeLinecap: 'stroke-linecap', + strokeWidth: 'stroke-width', + viewBox: 'viewBox' }, DOMPropertyNames: { autoCapitalize: 'autocapitalize',