From b2a9f748bf85e1eb2c5969743eaca1fd39709497 Mon Sep 17 00:00:00 2001 From: Rick Hanlon Date: Fri, 7 Jul 2023 12:51:45 -0400 Subject: [PATCH] Turn on RN flags, make www dynamic --- packages/shared/forks/ReactFeatureFlags.native-fb.js | 3 +-- .../shared/forks/ReactFeatureFlags.test-renderer.native.js | 2 +- packages/shared/forks/ReactFeatureFlags.www-dynamic.js | 2 ++ 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/packages/shared/forks/ReactFeatureFlags.native-fb.js b/packages/shared/forks/ReactFeatureFlags.native-fb.js index d98e4e5081..b8d3c7b18f 100644 --- a/packages/shared/forks/ReactFeatureFlags.native-fb.js +++ b/packages/shared/forks/ReactFeatureFlags.native-fb.js @@ -10,7 +10,6 @@ import typeof * as FeatureFlagsType from 'shared/ReactFeatureFlags'; import typeof * as ExportsType from './ReactFeatureFlags.native-fb'; -// NOTE: There are no flags, currently. Uncomment the stuff below if we add one. // Re-export dynamic flags from the internal module. Intentionally using * // because this import is compiled to a `require` call. import * as dynamicFlags from 'ReactNativeInternalFeatureFlags'; @@ -86,7 +85,7 @@ export const enableTransitionTracing = false; export const enableFloat = true; -export const useModernStrictMode = false; +export const useModernStrictMode = true; export const enableDO_NOT_USE_disableStrictPassiveEffect = false; export const enableFizzExternalRuntime = false; diff --git a/packages/shared/forks/ReactFeatureFlags.test-renderer.native.js b/packages/shared/forks/ReactFeatureFlags.test-renderer.native.js index 347ff62abf..55ad418a31 100644 --- a/packages/shared/forks/ReactFeatureFlags.test-renderer.native.js +++ b/packages/shared/forks/ReactFeatureFlags.test-renderer.native.js @@ -70,7 +70,7 @@ export const enableTransitionTracing = false; export const enableFloat = true; -export const useModernStrictMode = false; +export const useModernStrictMode = true; export const enableDO_NOT_USE_disableStrictPassiveEffect = false; export const enableDeferRootSchedulingToMicrotask = true; diff --git a/packages/shared/forks/ReactFeatureFlags.www-dynamic.js b/packages/shared/forks/ReactFeatureFlags.www-dynamic.js index 775dced6d1..a414c3fbe6 100644 --- a/packages/shared/forks/ReactFeatureFlags.www-dynamic.js +++ b/packages/shared/forks/ReactFeatureFlags.www-dynamic.js @@ -43,6 +43,8 @@ export const enableDebugTracing = __EXPERIMENTAL__; export const enableSchedulingProfiler = __VARIANT__; +export const useModernStrictMode = __VARIANT__; + // These are already tested in both modes using the build type dimension, // so we don't need to use __VARIANT__ to get extra coverage. export const replayFailedUnitOfWorkWithInvokeGuardedCallback = __DEV__;