From b17b2ea3f65af0312af4bacb06e5f8df4fc335ed Mon Sep 17 00:00:00 2001 From: Jim Date: Mon, 29 Feb 2016 21:03:18 -0800 Subject: [PATCH] Merge pull request #6152 from jimfb/fix-blog-code-fragment Updated code fragment for correctness. (cherry picked from commit 56c423afd66f7f1363dee87d25795418d5e74a30) --- docs/_posts/2015-12-16-ismounted-antipattern.md | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/docs/_posts/2015-12-16-ismounted-antipattern.md b/docs/_posts/2015-12-16-ismounted-antipattern.md index b258e92e20..6390baa048 100644 --- a/docs/_posts/2015-12-16-ismounted-antipattern.md +++ b/docs/_posts/2015-12-16-ismounted-antipattern.md @@ -60,14 +60,17 @@ Where `makeCancelable` is [defined by @istarkov](https://github.com/facebook/rea const makeCancelable = (promise) => { let hasCanceled_ = false; + const wrappedPromise = new Promise((resolve, reject) => { + promise.then((val) => + hasCanceled_ ? reject({isCanceled: true}) : resolve(val) + ); + promise.catch((error) => + hasCanceled_ ? reject({isCanceled: true}) : reject(error) + ); + }); + return { - promise: new Promise( - (resolve, reject) => promise - .then(r => hasCanceled_ - ? reject({isCanceled: true}) - : resolve(r) - ) - ), + promise: wrappedPromise, cancel() { hasCanceled_ = true; },