From abe75b0e3909cd037e017a46295302a197d760af Mon Sep 17 00:00:00 2001 From: Brian Vaughn Date: Fri, 19 Jul 2019 09:19:03 -0700 Subject: [PATCH] Slight tweak to avoid setting an invalid numeric value in props editor --- src/devtools/views/Components/EditableValue.js | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/devtools/views/Components/EditableValue.js b/src/devtools/views/Components/EditableValue.js index 09b2893a06..3238315a15 100644 --- a/src/devtools/views/Components/EditableValue.js +++ b/src/devtools/views/Components/EditableValue.js @@ -59,7 +59,10 @@ export default function EditableValue({ if (key === 'Enter') { if (dataType === 'number') { - overrideValueFn(path, parseFloat(editableValue)); + const parsedValue = parseFloat(editableValue); + if (!Number.isNaN(parsedValue)) { + overrideValueFn(path, parsedValue); + } } else { overrideValueFn(path, editableValue); } @@ -72,7 +75,7 @@ export default function EditableValue({ setHasPendingChanges(false); } }, - [path, editableValue, overrideValueFn, value, dataType] + [editableValue, dataType, overrideValueFn, path, value] ); // Render different input types based on the dataType