Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert to use console.error for onRecoverableError

Browse Source
This commit is contained in:
Tianyu Yao
2024-04-12 12:12:01 -07:00
parent ba1a9797ee
commit a23bf3d076
2 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native-renderer/src/ReactFabric.js
Vendored
+5 -2
View File
@@ -22,7 +22,6 @@ import {
getPublicRootInstance,
defaultOnUncaughtError,
defaultOnCaughtError,
defaultOnRecoverableError,
} from 'react-reconciler/src/ReactFiberReconciler';
import {createPortal as createPortalImpl} from 'react-reconciler/src/ReactPortal';
@@ -100,6 +99,10 @@ function nativeOnCaughtError(
defaultOnCaughtError(error, errorInfo);
}
function nativeOnRecoverableError(error: mixed): void {
// eslint-disable-next-line react-internal/no-production-logging, react-internal/warning-args
console.error(error);
}
function render(
element: Element<ElementType>,
@@ -125,7 +128,7 @@ function render(
'',
nativeOnUncaughtError,
nativeOnCaughtError,
defaultOnRecoverableError,
nativeOnRecoverableError,
null,
);
roots.set(containerTag, root);
packages/react-native-renderer/src/ReactNativeRenderer.js
Vendored
+5 -2
View File
@@ -22,7 +22,6 @@ import {
getPublicRootInstance,
defaultOnUncaughtError,
defaultOnCaughtError,
defaultOnRecoverableError,
} from 'react-reconciler/src/ReactFiberReconciler';
// TODO: direct imports like some-package/src/* are bad. Fix me.
import {getStackByFiberInDevAndProd} from 'react-reconciler/src/ReactFiberComponentStack';
@@ -105,6 +104,10 @@ function nativeOnCaughtError(
defaultOnCaughtError(error, errorInfo);
}
function nativeOnRecoverableError(error: mixed): void {
// eslint-disable-next-line react-internal/no-production-logging, react-internal/warning-args
console.error(error);
}
function render(
element: Element<ElementType>,
@@ -129,7 +132,7 @@ function render(
'',
nativeOnUncaughtError,
nativeOnCaughtError,
defaultOnRecoverableError,
nativeOnRecoverableError,
null,
);
roots.set(containerTag, root);