From a130757cd3ed80047c5eed0afdcdf0d2f90343a0 Mon Sep 17 00:00:00 2001 From: Dan Abramov Date: Thu, 3 Aug 2017 20:24:09 +0100 Subject: [PATCH] Remove hidden functional shouldComponentUpdate API (#10371) --- src/renderers/shared/fiber/ReactFiberBeginWork.js | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/src/renderers/shared/fiber/ReactFiberBeginWork.js b/src/renderers/shared/fiber/ReactFiberBeginWork.js index 87cd7acd23..d9821063f4 100644 --- a/src/renderers/shared/fiber/ReactFiberBeginWork.js +++ b/src/renderers/shared/fiber/ReactFiberBeginWork.js @@ -198,16 +198,8 @@ module.exports = function( if (nextProps === null || memoizedProps === nextProps) { return bailoutOnAlreadyFinishedWork(current, workInProgress); } - // TODO: Disable this before release, since it is not part of the public API - // I use this for testing to compare the relative overhead of classes. - if ( - typeof fn.shouldComponentUpdate === 'function' && - !fn.shouldComponentUpdate(memoizedProps, nextProps) - ) { - // Memoize props even if shouldComponentUpdate returns false - memoizeProps(workInProgress, nextProps); - return bailoutOnAlreadyFinishedWork(current, workInProgress); - } + // TODO: consider bringing fn.shouldComponentUpdate() back. + // It used to be here. } var unmaskedContext = getUnmaskedContext(workInProgress);