From a012858ba9e35f2eacbd0a63cdc157989d1fb884 Mon Sep 17 00:00:00 2001 From: Brian Vaughn Date: Tue, 26 May 2020 13:41:27 -0700 Subject: [PATCH] Move isCustomComponent() function call outside of loop (#19007) --- packages/react-dom/src/server/ReactPartialRenderer.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/react-dom/src/server/ReactPartialRenderer.js b/packages/react-dom/src/server/ReactPartialRenderer.js index 6c700a1ac5..63693ed1b5 100644 --- a/packages/react-dom/src/server/ReactPartialRenderer.js +++ b/packages/react-dom/src/server/ReactPartialRenderer.js @@ -73,7 +73,7 @@ import {checkControlledValueProps} from '../shared/ReactControlledValuePropTypes import assertValidProps from '../shared/assertValidProps'; import dangerousStyleValue from '../shared/dangerousStyleValue'; import hyphenateStyleName from '../shared/hyphenateStyleName'; -import isCustomComponent from '../shared/isCustomComponent'; +import isCustomComponentFn from '../shared/isCustomComponent'; import omittedCloseTags from '../shared/omittedCloseTags'; import warnValidStyle from '../shared/warnValidStyle'; import {validateProperties as validateARIAProperties} from '../shared/ReactDOMInvalidARIAHook'; @@ -361,6 +361,8 @@ function createOpenTagMarkup( ): string { let ret = '<' + tagVerbatim; + const isCustomComponent = isCustomComponentFn(tagLowercase, props); + for (const propKey in props) { if (!hasOwnProperty.call(props, propKey)) { continue; @@ -376,7 +378,7 @@ function createOpenTagMarkup( propValue = createMarkupForStyles(propValue); } let markup = null; - if (isCustomComponent(tagLowercase, props)) { + if (isCustomComponent) { if (!RESERVED_PROPS.hasOwnProperty(propKey)) { markup = createMarkupForCustomAttribute(propKey, propValue); }