From 9eb288e6579333612ed736c4e088669daf90a076 Mon Sep 17 00:00:00 2001 From: Mike Vitousek Date: Tue, 6 Aug 2024 23:47:09 -0700 Subject: [PATCH] [compiler][ez] Default to using flow suppressions ghstack-source-id: b6592650e08a1b07b6ccaad025bc4b81dd61d442 Pull Request resolved: https://github.com/facebook/react/pull/30622 --- .../babel-plugin-react-compiler/src/Entrypoint/Options.ts | 2 +- .../eslint-plugin-react-compiler/src/rules/ReactCompilerRule.ts | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/compiler/packages/babel-plugin-react-compiler/src/Entrypoint/Options.ts b/compiler/packages/babel-plugin-react-compiler/src/Entrypoint/Options.ts index 01aa4deb88..722c62461d 100644 --- a/compiler/packages/babel-plugin-react-compiler/src/Entrypoint/Options.ts +++ b/compiler/packages/babel-plugin-react-compiler/src/Entrypoint/Options.ts @@ -194,7 +194,7 @@ export const defaultOptions: PluginOptions = { noEmit: false, runtimeModule: null, eslintSuppressionRules: null, - flowSuppressions: false, + flowSuppressions: true, ignoreUseNoForget: false, sources: filename => { return filename.indexOf('node_modules') === -1; diff --git a/compiler/packages/eslint-plugin-react-compiler/src/rules/ReactCompilerRule.ts b/compiler/packages/eslint-plugin-react-compiler/src/rules/ReactCompilerRule.ts index 359db08cd7..2fe34a0b7f 100644 --- a/compiler/packages/eslint-plugin-react-compiler/src/rules/ReactCompilerRule.ts +++ b/compiler/packages/eslint-plugin-react-compiler/src/rules/ReactCompilerRule.ts @@ -101,6 +101,8 @@ function makeSuggestions( const COMPILER_OPTIONS: Partial = { noEmit: true, panicThreshold: 'none', + // Don't emit errors on Flow suppressions--Flow already gave a signal + flowSuppressions: false, }; const rule: Rule.RuleModule = {